Re: [PHP-DEV] NetWare diff - 1.

2004-02-09 Thread Zeev Suraski
At 21:33 08/02/2004, Derick Rethans wrote: On Thu, 5 Feb 2004, Andi Gutmans wrote: > Hi Ananth, > > I'm sorry but your patches are kind of messy. There are far too many #ifdef > NETWARE's in there. It should be possible to improve on this by creating > abstraction for things such as stat. > I don'

Re: [PHP-DEV] NetWare diff - 1.

2004-02-08 Thread Derick Rethans
On Thu, 5 Feb 2004, Andi Gutmans wrote: > Hi Ananth, > > I'm sorry but your patches are kind of messy. There are far too many #ifdef > NETWARE's in there. It should be possible to improve on this by creating > abstraction for things such as stat. > I don't feel very comfortable with commiting them

Re: [PHP-DEV] NetWare diff - 1.

2004-02-05 Thread dv
> > Not to undermine the effort..but does anyone actually > use PHP on Netware? (or actually use netware anymore..? :) > There's at least one fairly major U.S state governmental agency (whom I happen to work for) that uses it. You can view the mailing lists for many others, mostly enterp

Re: [PHP-DEV] NetWare diff - 1.

2004-02-05 Thread Jani Taskinen
Not to undermine the effort..but does anyone actually use PHP on Netware? (or actually use netware anymore..? :) Anyway, I agree with Andi. There has to be better way to do this port.. --Jani On Thu, 5 Feb 2004, Andi Gutmans wrote: >Hi Ananth, > >I'm sorry b

Re: [PHP-DEV] NetWare diff - 1.

2004-02-05 Thread Andi Gutmans
Hi Ananth, I'm sorry but your patches are kind of messy. There are far too many #ifdef NETWARE's in there. It should be possible to improve on this by creating abstraction for things such as stat. I don't feel very comfortable with commiting them the way they are. Has anyone else here looked at

[PHP-DEV] NetWare diff - 1.

2004-02-05 Thread Ananth Kesari
Hi, Please find attached, the NetWare diff (text file) in the unified format taken using the command: cvs diff -uN. When I attached the diff of the whole php5 project, my mails were bouncing. So, I have split it up manually and then sending the diff in two mails. The first part is attached below