On Thu, 5 Feb 2004, Andi Gutmans wrote:
> Hi Ananth, > > I'm sorry but your patches are kind of messy. There are far too many #ifdef > NETWARE's in there. It should be possible to improve on this by creating > abstraction for things such as stat. > I don't feel very comfortable with commiting them the way they are. > Has anyone else here looked at them?
I just did, and found the same conclusion. Wouldn't it be much better to maintain an off-site patch to it?
I agree with Andi and think it would be best to add the necessary abstractions to allow this patch to live in the CVS. But I also agree that the way it is, it's too messy to be committed...
Zeev
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
