Re: [PHP-DEV] Cleanup and maintenance of internal C code

2007-11-23 Thread Marcus Boerger
Hello Andy, changing to const where possible is a damn good thing and on our list for long. We also wanted to get rid of TSRMLS_FETCH() wherever possible. For instance we should do this change: typedef int (*apply_func_args_t)(void *pDest, int num_args, va_list args, zend_hash_key *hash_key); Z

Re: [PHP-DEV] Cleanup and maintenance of internal C code

2007-11-22 Thread Antony Dovgal
On 23.11.2007 09:25, Andy Lester wrote: > On Nov 23, 2007, at 12:19 AM, Antony Dovgal wrote: > >> Take a look at 5_3 and HEAD, we've done this already a couple of >> months ago: >> http://news.php.net/php.cvs/46317 > > > So I see. That's a good sign. There's still plenty of other places >

Re: [PHP-DEV] Cleanup and maintenance of internal C code

2007-11-22 Thread Andy Lester
On Nov 23, 2007, at 12:19 AM, Antony Dovgal wrote: Take a look at 5_3 and HEAD, we've done this already a couple of months ago: http://news.php.net/php.cvs/46317 So I see. That's a good sign. There's still plenty of other places to hit, too. Are we interested in jacking up compiler wa

Re: [PHP-DEV] Cleanup and maintenance of internal C code

2007-11-22 Thread Antony Dovgal
On 23.11.2007 08:41, Andy Lester wrote: > Hi, I'm Andy Lester, and I'm usually a Perl person. I've worked on > the Perl 5 and Parrot internals over the past few years, working to > clean up the C code. > > The other day I was poking through the C code behind PHP 5.2 and saw > some places th

[PHP-DEV] Cleanup and maintenance of internal C code

2007-11-22 Thread Andy Lester
Hi, I'm Andy Lester, and I'm usually a Perl person. I've worked on the Perl 5 and Parrot internals over the past few years, working to clean up the C code. The other day I was poking through the C code behind PHP 5.2 and saw some places that I thought I could help clean up. If the PHP cor