Hello Andy, changing to const where possible is a damn good thing and on our list for long. We also wanted to get rid of TSRMLS_FETCH() wherever possible. For instance we should do this change: typedef int (*apply_func_args_t)(void *pDest, int num_args, va_list args, zend_hash_key *hash_key); ZEND_API void zend_hash_apply_with_arguments(HashTable *ht, apply_func_args_t apply_func, int, ...); to: typedef int (*apply_func_args_t)(void *pDest TSRMLS_DC, int num_args, va_list args, zend_hash_key *hash_key); ZEND_API void zend_hash_apply_with_arguments(HashTable *ht TSRMLS_DC, apply_func_args_t apply_func, int, ...); and there are more of those.
Since I think your offer is very good, I suggest you provide a few patches for HEAD and 5.3 and if that turns out to be good, we'll give you cvs access. Thats's how we all started. marcus Friday, November 23, 2007, 7:25:55 AM, you wrote: > On Nov 23, 2007, at 12:19 AM, Antony Dovgal wrote: >> Take a look at 5_3 and HEAD, we've done this already a couple of >> months ago: >> http://news.php.net/php.cvs/46317 > So I see. That's a good sign. There's still plenty of other places > to hit, too. Are we interested in jacking up compiler warning levels, > too? I was surprised to see that GCC doesn't default to running with - > Wall in the Makefile. > Just read through README.SUBMITTING-PATCH, so will be mailing stuff > in, as with the bug in browscap.c I just stumbled across. > xoa > -- > Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
