Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-11 Thread Pascal Martin, AFUP
On 02/12/2014 22:44, Andrea Faulds wrote: I’m putting the ZPP Failure on Overflow RFC to a vote. This RFC is an important prerequisite to the Big Integer Support RFC, as it ensures safety in implicit integer parameter conversions. The RFC requires a 2/3 majority, and voting starts today (2014-

Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-10 Thread Andrea Faulds
Hi, > On 10 Dec 2014, at 17:21, Rowan Collins wrote: > > Andrea Faulds wrote on 10/12/2014 16:04: >> >> It looks like those changes aren’t in master. Once this RFC passes, I’d very >> much like to see a new attempt to make the names consistent, it’s something >> that’s bothered me. If this wa

Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-10 Thread Rowan Collins
Andrea Faulds wrote on 10/12/2014 16:04: On 9 Dec 2014, at 15:27, Rowan Collins wrote: Andrea Faulds wrote on 09/12/2014 14:10: On 9 Dec 2014, at 13:23, Rowan Collins wrote: Note that in master, the messages have been changed to (correctly) not mention the C types, only the PHP ones, so it

Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-10 Thread Andrea Faulds
> On 9 Dec 2014, at 15:27, Rowan Collins wrote: > > Andrea Faulds wrote on 09/12/2014 14:10: >>> On 9 Dec 2014, at 13:23, Rowan Collins wrote: >>> >>> Note that in master, the messages have been changed to (correctly) not >>> mention the C types, only the PHP ones, so it would be more like "e

Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-03 Thread Xinchen Hui
On Thu, Dec 4, 2014 at 1:54 PM, Andrea Faulds wrote: > >> On 4 Dec 2014, at 05:51, Xinchen Hui wrote: >> >>> >> I am not sure if I misunderstand your proposal.. >> >> I thought you proposal is only fail if double value is out of long range >> >> but from your patch, ext/date/tests/date_sunset_var

Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-03 Thread Andrea Faulds
> On 4 Dec 2014, at 05:51, Xinchen Hui wrote: > >> > I am not sure if I misunderstand your proposal.. > > I thought you proposal is only fail if double value is out of long range > > but from your patch, ext/date/tests/date_sunset_variation9.phpt is > fails with a double value 12.*** (which

Re: [PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-03 Thread Xinchen Hui
Hey: On Wed, Dec 3, 2014 at 5:44 AM, Andrea Faulds wrote: > Good evening once again, > > I’m putting the ZPP Failure on Overflow RFC to a vote. This RFC is an > important prerequisite to the Big Integer Support RFC, as it ensures safety > in implicit integer parameter conversions. > > The RFC r

[PHP-DEV] [VOTE][RFC] ZPP Failure on Overflow

2014-12-02 Thread Andrea Faulds
Good evening once again, I’m putting the ZPP Failure on Overflow RFC to a vote. This RFC is an important prerequisite to the Big Integer Support RFC, as it ensures safety in implicit integer parameter conversions. The RFC requires a 2/3 majority, and voting starts today (2014-12-02) and ends i