On Fri, Oct 19, 2018 at 10:21 PM Sara Golemon wrote:
>
> On Fri, Oct 19, 2018 at 9:20 PM Sara Golemon wrote:
> > On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers wrote:
> > > I'd like to start a discussion on the "Improve
> > > openssl_random_pseudo_bytes()" RFC:
> > > https://wiki.php.net/rfc/
On Fri, Oct 19, 2018 at 9:20 PM Sara Golemon wrote:
> On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers wrote:
> > I'd like to start a discussion on the "Improve
> > openssl_random_pseudo_bytes()" RFC:
> > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
> >
> lgtm; though a small nit
On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers wrote:
> I'd like to start a discussion on the "Improve
> openssl_random_pseudo_bytes()" RFC:
> https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
>
lgtm; though a small nit: s/RETURN_BOOL(pzv, 1)/RETURN_TRUE(pzv)/g
Slightly more readable
Hi internals friends!
I'd like to start a discussion on the "Improve
openssl_random_pseudo_bytes()" RFC:
https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes
TL;DR:
CSPRNG implementations should always fail closed so this change would
make `openssl_random_pseudo_bytes()` fail closed.
Th
