On Fri, Oct 19, 2018 at 10:21 PM Sara Golemon <poll...@php.net> wrote: > > On Fri, Oct 19, 2018 at 9:20 PM Sara Golemon <poll...@php.net> wrote: > > On Fri, Oct 19, 2018 at 3:47 PM Sammy Kaye Powers <m...@sammyk.me> wrote: > > > I'd like to start a discussion on the "Improve > > > openssl_random_pseudo_bytes()" RFC: > > > https://wiki.php.net/rfc/improve-openssl-random-pseudo-bytes > > > > > lgtm; though a small nit: s/RETURN_BOOL(pzv, 1)/RETURN_TRUE(pzv)/g > > Slightly more readable that way. > > > Or rather: ZVAL_BOOL(pzv, 1) => ZVAL_TRUE(pzv)
Good call - done! :) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
