Re: [PHP-DEV] [RFC] Base convert changes

2019-06-12 Thread Derick Rethans
On Tue, 11 Jun 2019, Scott Dutton wrote: > Hi all, > > I plan to put this to vote early next week with the two options > > One vote for the invalid char deprecation for php7.4 and Exception in PHP8 > > One vote for negative numbers PHP8 only - due to BC concerns Could you update the relevent s

Re: [PHP-DEV] [RFC] Base convert changes

2019-06-11 Thread Scott Dutton
Hi all, I plan to put this to vote early next week with the two options One vote for the invalid char deprecation for php7.4 and Exception in PHP8 One vote for negative numbers PHP8 only - due to BC concerns Thanks Scott -- PHP Internals - PHP Runtime Development Mailing List To unsubscrib

Re: [PHP-DEV] [RFC] Base convert changes

2019-05-23 Thread Scott Dutton
Hi Nikita, Derick Thanks for your time looking at this. Not sure if this will sway you either way, Other programming languages do handle negatives correctly, for example (i can add this to the RFC if that helps) Javascript - https://jsfiddle.net/c16b4usp/ Python - https://repl.it/repls/OliveB

Re: [PHP-DEV] [RFC] Base convert changes

2019-05-23 Thread Derick Rethans
On Thu, 23 May 2019, Nikita Popov wrote: > On Sat, May 18, 2019 at 11:22 AM Scott Dutton wrote: > > > I have made some changes to base_convert which I feel would be more > > consistent with the current PHP (warning when there are errors, and > > not just returning the best value it can) > > >

Re: [PHP-DEV] [RFC] Base convert changes

2019-05-23 Thread Nikita Popov
On Sat, May 18, 2019 at 11:22 AM Scott Dutton wrote: > Hi all > > I have made some changes to base_convert which I feel would be more > consistent with the current PHP (warning when there are errors, and not > just returning the best value it can) > > The RFC has some examples of what will change

Re: [PHP-DEV] [RFC] Base convert changes

2019-05-21 Thread G. P. B.
On Tue, 21 May 2019, 06:42 Scott Dutton, wrote: > > Not sure if I can add and example to the RFC at this point, but I came > across another example of this recently. > > > https://gist.github.com/iansltx/4820b02ab276c3306314daaa41573445#file-getlines-php-L9 > > // bindec() was doing weird th

Re: [PHP-DEV] [RFC] Base convert changes

2019-05-20 Thread Scott Dutton
Not sure if I can add and example to the RFC at this point, but I came across another example of this recently. https://gist.github.com/iansltx/4820b02ab276c3306314daaa41573445#file-getlines-php-L9 // bindec() was doing weird things, hence converting through hex first // sttrev() to

[PHP-DEV] [RFC] Base convert changes

2019-05-18 Thread Scott Dutton
Hi all I have made some changes to base_convert which I feel would be more consistent with the current PHP (warning when there are errors, and not just returning the best value it can) The RFC has some examples of what will change. Currently the code works but a lot of tests fail due to extr