On Thu, 23 May 2019, Nikita Popov wrote: > On Sat, May 18, 2019 at 11:22 AM Scott Dutton <sc...@exussum.co.uk> wrote: > > > I have made some changes to base_convert which I feel would be more > > consistent with the current PHP (warning when there are errors, and > > not just returning the best value it can) > > > > The RFC has some examples of what will change. > > > > Currently the code works but a lot of tests fail due to extreme > > range's (also mentioned in the RFC) > > > > If this passes I will fix the effected tests and add some more > > covering the new behavior. > > > > https://wiki.php.net/rfc/base_convert_improvements > > I definitely agree with the part of the RFC that warns on garbage > characters in the string. I'm not so sure about the changes in sign > handling. The problem I see is that certain bases (in particular hex) are > pretty much never used with an explicit sign, instead they are understood > to be in two's complement representation. > > For example, code like this will currently work: > > var_dump(dechex(0xffffffff00000000)); > // string(16) "ffffffff00000000"
I concur with Nikita here. I don't think you should change the sign handling. I think this is something that actually use in real life projects. cheers, Derick -- https://derickrethans.nl | https://xdebug.org | https://dram.io Like Xdebug? Consider a donation: https://xdebug.org/donate.php, or become my Patron: https://www.patreon.com/derickr twitter: @derickr and @xdebug -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
