Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Christoph Becker
On 09.07.2016 at 11:18, Leigh wrote: > On Sat, 9 Jul 2016 at 10:16 Christoph Becker wrote: > >> Assuming that "Make array_rand() more efficient" is indeed only about >> performance (and not about fixes for the broken implementation), it >> wouldn't be a bug fix, but as array_rand()'s behavior wo

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Christoph Becker
On 09.07.2016 at 10:49, Pierre Joye wrote: > On Jul 9, 2016 3:19 PM, "Leigh" wrote: >> >> On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: >>> >>> So, I voted no then as it is clear that you do not see a problem to >>> break codes without a single warning or time to adapt before. >>> >>> The other

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Leigh
On Sat, 9 Jul 2016 at 10:16 Christoph Becker wrote: > > Assuming that "Make array_rand() more efficient" is indeed only about > performance (and not about fixes for the broken implementation), it > wouldn't be a bug fix, but as array_rand()'s behavior would change > anyway as noted by the RFC, it

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Christoph Becker
On 09.07.2016 at 10:18, Leigh wrote: > On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: > >> So, I voted no then as it is clear that you do not see a problem to >> break codes without a single warning or time to adapt before. >> >> The other sections are fine and voted yes. > > For the part where

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Jul 9, 2016 4:05 PM, "Leigh" wrote: > > On Sat, 9 Jul 2016 at 09:49 Pierre Joye wrote: >> >> >> I am sorry but this PR possibly breaks BC and cases have been clearly explained how and why. Asking to show production code publically is not something that you should request. >> >> I can write a

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Leigh
On Sat, 9 Jul 2016 at 09:49 Pierre Joye wrote: > > I am sorry but this PR possibly breaks BC and cases have been clearly > explained how and why. Asking to show production code publically is not > something that you should request. > > I can write a sample app to show you how but given the expla

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Jul 9, 2016 3:49 PM, "Pierre Joye" wrote: > > > On Jul 9, 2016 3:19 PM, "Leigh" wrote: > > > > > > On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: > >> > >> So, I voted no then as it is clear that you do not see a problem to > >> break codes without a single warning or time to adapt before. >

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Jul 9, 2016 3:19 PM, "Leigh" wrote: > > > On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: >> >> So, I voted no then as it is clear that you do not see a problem to >> break codes without a single warning or time to adapt before. >> >> The other sections are fine and voted yes. > > > For the par

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Leigh
On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: > So, I voted no then as it is clear that you do not see a problem to > break codes without a single warning or time to adapt before. > > The other sections are fine and voted yes. > For the part where you voted no. Still nobody has presented (publi

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Thu, Jul 7, 2016 at 7:56 PM, Pierre Joye wrote: > > On Jul 7, 2016 7:53 PM, "Leigh" wrote: >> >> On 7 July 2016 at 13:39, Pierre Joye wrote: >> > Hi >> > >> > Looks good but missing an option to choose the default mode. >> > >> > I would choose BC as default at least for one release (7.1). >

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-07 Thread Pierre Joye
On Jul 7, 2016 7:53 PM, "Leigh" wrote: > > On 7 July 2016 at 13:39, Pierre Joye wrote: > > Hi > > > > Looks good but missing an option to choose the default mode. > > > > I would choose BC as default at least for one release (7.1). > > It's been that way since 5.2.1, I think it's had enough rele

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-07 Thread Leigh
On 7 July 2016 at 13:39, Pierre Joye wrote: > Hi > > Looks good but missing an option to choose the default mode. > > I would choose BC as default at least for one release (7.1). It's been that way since 5.2.1, I think it's had enough releases already :) -- PHP Internals - PHP Runtime Developm

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-07 Thread Pierre Joye
Hi Looks good but missing an option to choose the default mode. I would choose BC as default at least for one release (7.1). I tend to vote against fixing mt_rand because of that. On Jul 7, 2016 5:39 PM, "Leigh" wrote: > As the discussion thread has been quiet for a while, moving this RFC to

[PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-07 Thread Leigh
As the discussion thread has been quiet for a while, moving this RFC to voting. https://wiki.php.net/rfc/rng_fixes https://github.com/php/php-src/pull/1986 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php