Re: [PHP-DEV] [PATCH] adding RFC3984 support to http_build_query

2011-01-05 Thread Rui Hirokawa
Hello, This is a revised patch based on the PHP constant. Rui (2011/01/05 21:50), Rui Hirokawa wrote: Hello, Thank you for the comment. How about adding two PHP constant, PHP_QUERY_RFC1738 (default) and PHP_QUERY_RFC3986 ? It is like, echo http_build_query($v, null, '&'); echo http_build_q

Re: [PHP-DEV] [PATCH] adding RFC3984 support to http_build_query

2011-01-05 Thread Rui Hirokawa
Hello, Thank you for the comment. How about adding two PHP constant, PHP_QUERY_RFC1738 (default) and PHP_QUERY_RFC3986 ? It is like, echo http_build_query($v, null, '&'); echo http_build_query($v, null, '&',PHP_QUERY_RFC1738); echo http_build_query($v, null, '&', PHP_QUERY_RFC3986); Rui (201

Re: [PHP-DEV] [PATCH] adding RFC3984 support to http_build_query

2011-01-05 Thread Tjerk Meesters
Instead of a boolean, could you add a rfc-xx selection parameter instead, like, in case one would like rfc 3986 instead? On Jan 5, 2011 8:10 PM, "Rui Hirokawa" wrote: > Hello, > > I made a patch to add the RFC-3984 based url-encoding support > into http_build_query(). > > The http_build_query() is

[PHP-DEV] [PATCH] adding RFC3984 support to http_build_query

2011-01-05 Thread Rui Hirokawa
Hello, I made a patch to add the RFC-3984 based url-encoding support into http_build_query(). The http_build_query() is quite useful, but, it isn't based on the official url-encoding scheme (RFC-3984) for ~ (tilde) and ' '(space). I added an optional (the 4th) parameter 'is_rfc3984'. If it is tr