Re: [PHP-DEV] [PATCH]#55651

On 09/12/2011 05:54 AM, Pierre Joye wrote: hi! On Mon, Sep 12, 2011 at 2:29 AM, Avi Brender wrote: Hi, Please see if the attached patch better addresses your concerns. Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only internal and is modeled after the other variables PHP_F

Re: [PHP-DEV] [PATCH]#55651

hi! On Mon, Sep 12, 2011 at 2:29 AM, Avi Brender wrote: > Hi, > > Please see if the attached patch better addresses your concerns. > > Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only internal > and is modeled after the other variables PHP_FTP_TIMEOUT_SEC and > PHP_FTP_OPT_AUTO

Re: [PHP-DEV] [PATCH]#55651

I definitely agree that the problem is with a mis-configured FTP server returning a private RFC1918 IP address. That would happen if the FTP server was on a server behind a NAT gateway and the server only knew about it's local RFC1918 IP address and not it's internet-routable IP address. Howeve

Re: [PHP-DEV] [PATCH]#55651

hmm, after deep looking, I found maybe this behavior(cann't connect to NAT server when use pasv mode) is "as expected", since this is not php ftp-ext issue, but a ftp server configure issue, that is, if we apply this patch, will make the php ftp-ext not a standard ftp protocl executor. thanks

Re: [PHP-DEV] [PATCH]#55651

2011/9/12 Avi Brender : > Hi, > > Please see if the attached patch better addresses your concerns. > > Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only internal > and is modeled after the other variables PHP_FTP_TIMEOUT_SEC and > PHP_FTP_OPT_AUTOSEEK. The variable actually passed

Re: [PHP-DEV] [PATCH]#55651

Hi, Please see if the attached patch better addresses your concerns. Regarding the variable name, the PHP_FTP_OPT_USEPASVADDRESS is only internal and is modeled after the other variables PHP_FTP_TIMEOUT_SEC and PHP_FTP_OPT_AUTOSEEK. The variable actually passed to the ftp_set_option() functio

Re: [PHP-DEV] [PATCH]#55651

hi! Please upload the patch in the bug tracker as well. It would be also better to use a more verbose name. FTP_OPT_USEPASVADDRESS is somehow cryptic. Laruence's comment is still valid, the zval should be converted if it is not int or bool. Btw, could you test cases as well please? Cheers, On

Re: [PHP-DEV] [PATCH]#55651

Hi, I've updated the patch - please see attached. Avi Brender Elite Hosts, Inc www.elitehosts.com WARNING !!! This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauth

Re: [PHP-DEV] [PATCH]#55651

hi, A simple test if it is IS_BOOL or IS_LONG should be enough, both types use the the long value (convert_to_boolean_ex is slow and duplicate the zval while it is not necessary). Then test > 0 instead of simply assigning the value. On Sun, Sep 11, 2011 at 5:59 AM, Laruence wrote: > Hi: >    aft

[PHP-DEV] [PATCH]#55651

Hi Laruence, Sure thing - I was just using the above code that verified the AUTOSEEK option as a template. I've changed it to use convert_to_boolean_ex as per your suggestion :) Thanks! Avi Brender Elite Hosts, Inc www.elitehosts.com On 09/10/2011 11:59 PM, Laruence wrote: Hi: after

Re: [PHP-DEV] [PATCH]#55651

Hi: after a quick look, I have one suggestion, if the (Z_TYPE_P(z_value) != IS_BOOL), you should call convert_to_boolean_ex to convert it to a boolean otherwise, people can not use a interge 1 as a true flag. thanks 2011/9/11 Avi Brender : > Hi, > > I've submitted bug #55651 alon

[PHP-DEV] [PATCH]#55651

Hi, I've submitted bug #55651 along with a patch to implement a fix (also attached) for the passive FTP mode issue. I was hoping that someone could review the bug report and consider the patch for inclusion in future PHP releases. Thanks so much! Avi Brender Elite Hosts, Inc www.elitehosts.