Re: [PHP-DEV] SSH2 extension maintenance

2016-12-01 Thread Sean DuBois
On Thu, Dec 01, 2016 at 01:33:53PM +0100, Libor M. wrote: > Hello, > I wonder how it is with the activity development extensions SSH2. > > The current SSH2 extension (version 0.13 and 1.0) does not work on PHP > versions 5.6 and 7.0 because it contains bug > https://bugs.php.net/bug.php?id=73524. >

Re: [PHP-DEV] automating gcov with third-party extensions

2016-07-27 Thread Sean DuBois
On Wed, Jul 27, 2016 at 05:22:24PM -0400, Adam Baratz wrote: > I had a positive experience using gcov with a C extension. I used it to get > a better sense of what the .phpt tests (and valgrind) were really telling > me. > > To get it to work in an automated way, I hacked out Makefile.gcov and some

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-08 Thread Sean DuBois
On Tue, Mar 08, 2016 at 04:42:29PM -0500, Pierrick Charron wrote: > Hi internals, > > Bronisław Białek and I would like to start a discussion about allowing > multiple exception types to be caught in a single catch statement. > > https://wiki.php.net/rfc/multiple-catch > > A working implementation

Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-20 Thread Sean DuBois
On Thu, Jan 21, 2016 at 06:55:41AM +0900, Yasuo Ohgaki wrote: > Hi ZendEngine developers, > > I'm not sure if the wiki page is maintained, but I noticed few errors. > > https://wiki.php.net/phpng-upgrading#strings > has following example. > > - ZVAL_STRING(zv, str, 1); > + ZVAL_STRING(zv, str); > >

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

2015-12-03 Thread Sean DuBois
have time, and show you > PR before commit). > > Thanks. Dmitry. > > On Tue, Oct 20, 2015 at 8:36 PM, Sean DuBois wrote: > > > Hey list, > > > > Time for a simple RFC (in theory)! > > > > I would like to add visibility modifiers to class constants, a

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

2015-10-21 Thread Sean DuBois
On Wed, Oct 21, 2015 at 12:31:58PM -0500, Aaron Piotrowski wrote: > Hi Sean, > > > On Oct 21, 2015, at 11:17 AM, Sean DuBois wrote: > > > > On Wed, Oct 21, 2015 at 03:54:48PM +, Dan Ackroyd wrote: > >> Hi Sean, internals, > >> > >>

Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility

2015-10-21 Thread Sean DuBois
On Wed, Oct 21, 2015 at 03:54:48PM +, Dan Ackroyd wrote: > Hi Sean, internals, > > While I support this RFC, it seems that the actual implementation is > still under discussion. > > In particular, whether the RFC is going to allow protected constants > in an interface is not clear. > > In the t

[PHP-DEV] Karma to vote on (my own) RFC and access to phpng-upgrading

2015-10-20 Thread Sean DuBois
Hey list, I just created an RFC, and don't have karma to vote on it https://wiki.php.net/rfc/class_const_visibility Also I would like to be able to edit https://wiki.php.net/phpng-upgrading One of the most frustrating changes for extensions was that 's' and 'p' were changed from 'int' -> 'size_

[PHP-DEV] [RFC] [VOTE] Class Constant Visibility

2015-10-20 Thread Sean DuBois
Hey list, Time for a simple RFC (in theory)! I would like to add visibility modifiers to class constants, and then as a nice added bonus give more info from the Reflection API (constants now are a dedicated class so nice things like doc comments) https://wiki.php.net/rfc/class_const_visibility

[PHP-DEV] [RFC] [DISCUSSION]: Class Constant Visibility

2015-10-06 Thread Sean DuBois
Morning internals! I am starting the discussion around adding visibility modifiers to class constants. Following in the same pattern as properties. https://wiki.php.net/rfc/class_const_visibility There was some great discussion about this before as well http://news.php.net/php.internals/87946 If

Re: [PHP-DEV] good example of unserialization fundamentals?

2015-09-30 Thread Sean DuBois
On Wed, Sep 30, 2015 at 01:39:26PM -0700, j adams wrote: > I have completed a first draft of serialization functionality which is > intended to be an updated to amfext. It's on github[0] if anyone is > interested. I would now like to write all the unserialization routines and > would like some sugg

Re: [PHP-DEV] zend_parse_parameters changes not fully documented in phpng-upgrading, PR to fix existing tools

2015-09-24 Thread Sean DuBois
On Thu, Sep 24, 2015 at 11:01:09AM +0100, Derick Rethans wrote: > On Wed, 23 Sep 2015, Sean DuBois wrote: > > > Hey list, > > > > 'l' had a change 'long' -> 'zend_long' and 's' had a change 'int' -> > >

Re: [PHP-DEV] Data serialization of objects, want to iterate 'sealed' properties then dynamic ones

2015-09-23 Thread Sean DuBois
On Wed, Sep 23, 2015 at 02:16:39PM -0700, j adams wrote: > Not my intention to be combative, but what about http://php.net/pcntl_fork > ? I've used that before in a robust distributed application that runs > without any intervention for months. It's my understanding that PHP is > thread safe, but n

[PHP-DEV] zend_parse_parameters changes not fully documented in phpng-upgrading, PR to fix existing tools

2015-09-23 Thread Sean DuBois
Hey list, 'l' had a change 'long' -> 'zend_long' and 's' had a change 'int' -> 'size_t'. These two changes are really hard to catch when porting an extension, nothing complains at compile time, you don't get segfaults when calling zend_parse* but usually later and it is platform dependent (Window

Re: [PHP-DEV] Data serialization of objects, want to iterate 'sealed' properties then dynamic ones

2015-09-22 Thread Sean DuBois
On Tue, Sep 22, 2015 at 11:16:46AM -0700, j adams wrote: > I'm working on a data serialization routine wherein I must iterate through > an object's properties while distinguishing between "sealed" properties > (i.e., those specified by class definitions) and "dynamic" properties" > (i.e., those ass

Re: [PHP-DEV] strict-api - Proposing a tool to check and enforce encapsulation

2015-09-12 Thread Sean DuBois
On Sun, Sep 13, 2015 at 03:24:13AM +0200, François Laupretre wrote: > Hi Bob, > > Le 13/09/2015 00:44, Bob Weinand a écrit : > >While I don't disagree with the idea of making accidental direct access > >harder, I see a particular disadvantage for debugging. > > > >Nobody will like to write "p > >

Re: [PHP-DEV] strict-api - Proposing a tool to check and enforce encapsulation

2015-09-12 Thread Sean DuBois
On Sun, Sep 13, 2015 at 12:44:14AM +0200, Bob Weinand wrote: > > Am 08.09.2015 um 00:41 schrieb François Laupretre : > > > > Hi, > > > > I have written a follow-up to my previous 'zstrict' PR. It is now focused > > on a simple mechanism to detect API violations : > > > > https://github.com/php/php

Re: [PHP-DEV] PHP7 PECL Extensions

2015-09-10 Thread Sean DuBois
On Thu, Sep 10, 2015 at 03:25:16PM +0100, Joe Watkins wrote: > Afternoon internals, > > Is there any concrete plan for deploying pecl extensions for PHP7 ? > > Anatol (or anyone), is there any way to get windows ext's built against > RC's while we're waiting for PECL/pickle/apples/whatever

Re: [PHP-DEV] Re: [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-09-06 Thread Sean DuBois
On Sun, Sep 06, 2015 at 06:47:56PM +0100, Andrea Faulds wrote: > Hi Sean, > > Sean DuBois wrote: > > > >I am starting this discussion to get peoples opinion on the overall feature, > >and find someone > >who would be interested in watching over my progress and mak

[PHP-DEV] RFC Karma for Sean-Der

2015-09-04 Thread Sean DuBois
Hi, I am taking over the RFC class constant visibility rfc from Reeze, and need the permissions to update it. https://wiki.php.net/rfc/class_const_visibility Reeze gave the ok on the PR I have on GitHub as a PoC (It works, but has some test fails and breaks some extensions) https://github.com/php

[PHP-DEV] [RFC] [Concept] Class Constant visibility modifiers in PHP 7.1+

2015-08-27 Thread Sean DuBois
Hey all, I am starting this discussion to get peoples opinion on the overall feature, and find someone who would be interested in watching over my progress and making sure I do the right things to hopefully get this merged. The PHP bug tracker contains a few simple entries for a adding visibilit