Hi Dmitry! Thanks for the quickly reply. That is a bummer that the patch isn't gonna work! But yes, please go ahead and take it on! You don't have to show me the PR (I am happy with what ever you choose to do). There are some tests so once every passes I will be excited to see it merge :)
On Thu, Dec 03, 2015 at 12:29:50PM +0300, Dmitry Stogov wrote: > Hi Sean, > > Although the RFC is accepted, the patch has to be significantly reworked. > Probably, it's going to be better and faster if I do it myself. > Let me know, if you are agree (I'll do this when I have time, and show you > PR before commit). > > Thanks. Dmitry. > > On Tue, Oct 20, 2015 at 8:36 PM, Sean DuBois <s...@siobud.com> wrote: > > > Hey list, > > > > Time for a simple RFC (in theory)! > > > > I would like to add visibility modifiers to class constants, and then > > as a nice added bonus give more info from the Reflection API (constants > > now are a dedicated class so nice things like doc comments) > > > > https://wiki.php.net/rfc/class_const_visibility > > > > thanks! > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php > > > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
