Re: [PHP-DEV] Done something wrong ...

2015-02-16 Thread Martin Jansen
On 16.02.15 20:46, Lester Caine wrote: > On 16/02/15 18:34, Ferenc Kovacs wrote: >> On Mon, Feb 16, 2015 at 6:55 PM, Lester Caine wrote: >>> /srv/repo/php-src_master/ext/opcache/ZendAccelerator.c:2005:19: error: >>> ‘zend_array’ has no member named ‘pDestructor’ >>> Seems to be due to changes for

Re: [PHP-DEV] RFC: Expectations

2015-02-16 Thread Martin Jansen
On 16.02.15 10:37, Joe Watkins wrote: > Please review the RFC, and provide feedback, if there are no strong > objections we will go ahead with a vote when the patch is ready, in the > coming days. > > https://wiki.php.net/rfc/expectations I like it. But why do those two INI settings use d

Re: [PHP-DEV] PHP 7: Odd behavior with exp/soap

2015-02-01 Thread Martin Jansen
On 01.02.15 17:27, Martin Jansen wrote: > Currently I'm seeing some odd behavior with PHP 7 and SoapClient > embedded deep into a Symfony2 application. That same code works with > 5.x. Unfortunately I cannot yet reproduce the issue with a short script. Please ignore that one;

[PHP-DEV] PHP 7: Odd behavior with exp/soap

2015-02-01 Thread Martin Jansen
Currently I'm seeing some odd behavior with PHP 7 and SoapClient embedded deep into a Symfony2 application. That same code works with 5.x. Unfortunately I cannot yet reproduce the issue with a short script. Basically it boils down to get_function in ext/soap/soap.c returning NULL because zend_hash

Re: [PHP-DEV] php.net - The Website Ahead Contains Malware

2013-10-24 Thread Martin Jansen
On 24.10.13 10:19, Kris Craig wrote: > Aaaand I forgot to include the link. Nice one, Kris. > > Ok, HERE are the screenshots I took: http://imgur.com/a/ZgWW0 People are already working on getting the site removed from the blacklist. Please abandon this thread now. - Martin -- PHP Interna

Re: [PHP-DEV] PHP CLI setting cooked terminal mode

2013-09-16 Thread Martin Jansen
On 14.09.13 13:45, Alain Williams wrote: > ./myScript | less > > Since less is an interactive program it puts the terminal into 'raw' mode so > that it can read characters one at a time. However, when I do the above I find > that the commands that I type to less are echoed back to me and not a

Re: [PHP-DEV] Proposed changes to PHP language

2013-03-08 Thread Martin Jansen
On 06.03.13 13:48, Max Romanovsky wrote: >4. Add handling of DateTime objects to SoapServer and SoapClient. It >will help in using this build-in datatype without typemap. This is (at least partially) covered by the patch in https://bugs.php.net/44383. Have you tried that one to see if its

[PHP-DEV] FILTER_VALIDATE_INT and +0/-0

2013-02-03 Thread Martin Jansen
Back in December I submitted a pull request to make FILTER_VALIDATE_INT accept +0/-0. That request was merged into php-src: https://github.com/php/php-src/pull/248 The other day I then stumbled upon a note on http://www.php.net/manual/en/filter.filters.validate.php saying "Numbers +0 and -0 are n

Re: [PHP-DEV] File-Paths exceeding MAX_PATH on Windows

2013-01-07 Thread Martin Jansen
On 07.01.13 20:14, Pierre Joye wrote: > functions. Next major version (6) will support unicode filenames, > which will solve the 255 chars horrible limitation. I thought the Unicode effort was abandoned long time ago. You sound like someone is still actively working on it? - Martin -- PHP Inter

Re: [PHP-DEV] [RFC] Fixing insecure cURL file uploading

2013-01-06 Thread Martin Jansen
On 06.01.13 06:38, Stas Malyshev wrote: > https://wiki.php.net/rfc/curl-file-upload > > Please review and comment. If there's a general positive feedback, I'll > try to implement a patch for it pretty soon. Looks solid to me. One thing though: The manual spells the extension "cURL" and so does h

[PHP-DEV] MAC address validation for ext/filter

2013-01-05 Thread Martin Jansen
In https://github.com/php/php-src/pull/247 I have implemented MAC address validation for ext/filter. The current implementation detects MAC addresses in three notations (IEEE 802 with colons or hyphens and EUI-64 with dots) and optionally one can specify the expected separator character (colons/h

Re: [PHP-DEV] release process with git

2012-04-17 Thread Martin Jansen
On 17.04.12 10:24, Bas van Beek wrote: > Sounds like facilitating wrong security protocols to me. In this > 365/24/7 environment, sysadmins should be willing and able to patch, fix > and secure systems at any time. Weekend should be no excuse. There are a lot of (very serious) shops out there with

[PHP-DEV] mail.add_x_header set to on in php.ini-production

2012-01-27 Thread Martin Jansen
Is there any intention behind enabling the mail.add_x_header configuration directive in php.ini-production? http://lxr.php.net/opengrok/xref/PHP_TRUNK/php.ini-production#1018 This setting exposes (sort of) sensitive information about application deployments to third parties while IMO having no ap

Re: [PHP-DEV] PHP Wiki Down?

2012-01-02 Thread Martin Jansen
On 01.01.12 05:19, Florian Anderiasch wrote: > Did the monitoring url change or is it still down? > Are there any efforts to bring munin back? The move to a new machine is underway but go stalled by recent downtimes of another important server. Here's hoping to get it done by the end of the week.

Re: [PHP-DEV] [PATCH] Making in_array a language operator

2011-11-13 Thread Martin Jansen
On 13.11.11 19:08, Pierre Joye wrote: > 2011/11/13 Antoine Delignat-Lavaud : >> On Sun, 2011-11-13 at 14:23 +0100, Pierre Joye wrote: >>> >>> There is an idea to have pseudo object for common types, where these >>> functions would be callable without actually having an instance. No >>> implementati

Re: [PHP-DEV] Re: is_a() - again - a better fix

2011-09-23 Thread Martin Jansen
On 23.09.11 18:15, Matthew Weier O'Phinney wrote: > That said, I think it would be good to have a notification system > whereby framework leads are all pinged on new betas and RCs, and a wiki Something could probably monitor http://svn.php.net/repository/php/php-src/tags/ for changes and alert peo

Re: [PHP-DEV] Adding a more logical string slicing function to PHP

2011-03-31 Thread Martin Jansen
On 31.03.11 17:05, Rasmus Lerdorf wrote: > On 03/31/2011 07:41 AM, Philip Olson wrote: >> On Mar 30, 2011, at 1:42 PM, Martin Jansen wrote: >>> I recently got around to merge them into a largely unfinished extension >>> so they are archived somewhere safe: https://github

Re: [PHP-DEV] Adding a more logical string slicing function to PHP

2011-03-31 Thread Martin Jansen
On 31.03.11 16:41, Philip Olson wrote: > On Mar 30, 2011, at 1:42 PM, Martin Jansen wrote: >> Both str_startswith and str_endswith have been suggested in the past: >> >> http://marc.info/?t=12164723011&r=1&w=2 >> >> I recently got around to merge them

Re: [PHP-DEV] Adding a more logical string slicing function to PHP

2011-03-30 Thread Martin Jansen
On 30.03.11 21:36, Dan Birken wrote: > As for adding other string functions, I agree, I think there are a lot of > them that would be great to add. starts_with & ends_with for sure. Both str_startswith and str_endswith have been suggested in the past: http://marc.info/?t=12164723011&r=1&w=2

Re: [PHP-DEV] RFC: Making T_FUNCTION optional in method declarations

2010-11-28 Thread Martin Jansen
On 28.11.10 16:14, Gustavo Lopes wrote: > On Sun, 28 Nov 2010 14:58:13 -, David Otton > wrote: >> As a plea on behalf of maintenance coders dealing with large, messy >> codebases, please, please don't impact our ability to run 'grep -rs >> "function functionName" *', or hit F8, or whatever you

Re: [PHP-DEV] Storing zvals in hash tables in resources

2010-10-22 Thread Martin Jansen
On 23.10.10 01:05, Gustavo Lopes wrote: > On Fri, 22 Oct 2010 22:22:06 +0100, Martin Jansen > wrote: > >> I'm trying to store zvals in a hash table which is part of a resource. >> Unfortunately the zvals do not seem to "persist" between function calls: > &

[PHP-DEV] Storing zvals in hash tables in resources

2010-10-22 Thread Martin Jansen
I'm trying to store zvals in a hash table which is part of a resource. Unfortunately the zvals do not seem to "persist" between function calls: Please see my code below. In foo_get_value zend_hash_find() does *not* return FAILURE, so the key is there while the value is gone. Can someone spot m

Re: [PHP-DEV] Obscure token name

2010-04-29 Thread Martin Jansen
On 29.4.2010 13:13, mathieu.suen wrote: > Johannes Schlüter wrote: >> On Mon, 2010-04-26 at 16:32 +0200, mathieu.suen wrote: >> >>> I am wondering why is the token name so incomprehensible ? >>> Like T_PAAMAYIM_NEKUDOTAYIM... >> >> I don't mind if we change the name in the error message. Seems t

Re: [PHP-DEV] Named Parameters

2010-04-06 Thread Martin Jansen
On 5.4.2010 00:45, Pierre Joye wrote: > On Mon, Apr 5, 2010 at 12:07 AM, Stanislav Malyshev wrote: > >> 3. Combining named and un-named params can get weird - i.e. foo(1,2,3) is >> simple, foo(1, 2, bar => 3) is doable, but foo(1, 2, bar => 3, 4) would be >> trouble, since it is not clear at all

Re: [PHP-DEV] What gruntwork needs to be done

2010-04-06 Thread Martin Jansen
On 6.4.2010 19:54, Rasmus Lerdorf wrote: > On 04/06/2010 10:47 AM, Scott MacVicar wrote: >> http://whisky.macvicar.net/patches/utf8-string.diff.txt > > My only issue with this is that it essentially duplicates the utf8 part > of get_next_char() from html.c. I'd like to see cs parsing in one place

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/NEWS branches/PHP_5_2/ext/filter/logical_filters.c branches/PHP_5_3/NEWS branches/PHP_5_3/ext/filter/logical_filters.c trunk/ext/filter/logi

2010-04-02 Thread Martin Jansen
On 02.04.10 19:56, Rasmus Lerdorf wrote: > rasmus Fri, 02 Apr 2010 17:56:37 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=297350 > > Log: > Update the FILTER_VALIDATE_EMAIL filter to fix bug #49576 I'm referring to the following comment:

Re: [PHP-DEV] Proposal: shorthand object property setting syntax.

2010-03-27 Thread Martin Jansen
On 27.03.10 17:29, Stefan Marr wrote: > > On 27 Mar 2010, at 17:23, Martin Jansen wrote: > >> On 27.03.10 17:02, Toorion wrote: >>> $myLongNameObject = new MyLongNameObject(); >>> $myLongNameObject->property1 = '1'; >>> $myLongNameObject

Re: [PHP-DEV] Proposal: shorthand object property setting syntax.

2010-03-27 Thread Martin Jansen
On 27.03.10 17:02, Toorion wrote: > $myLongNameObject = new MyLongNameObject(); > $myLongNameObject->property1 = '1'; > $myLongNameObject->property2 = '2'; > $myLongNameObject->property3 = '3'; > $myLongNameObject->property4 = '4'; > $myLongNameObject->property5 = '5'; [...] >

[PHP-DEV] Support for Jenkins's one-at-a-time hashing function

2010-03-24 Thread Martin Jansen
+ | lice...@php.net so we can mail you a copy immediately. | + +--+ + | Author: Martin Jansen| + +--+ +*/ + +/* $Id*/

[PHP-DEV] Issue with safe mode check in tempnam()

2010-02-09 Thread Martin Jansen
Recently we've experienced an issue regarding the safe mode check in tempnam() which was introduced in r288945 4 months ago. When calling tempnam("/tmp/foo"), with /tmp/foo being a directory, it turned out that the safe mode UID check was performed on /tmp instead of /tmp/foo. When calling tempnam

Re: [PHP-DEV] [PATCH][HEAD] Upload progress in sessions

2008-09-08 Thread Martin Jansen
On Mon, Sep 8, 2008 at 12:18 PM, Arnaud Le Blanc <[EMAIL PROTECTED]> wrote: > The patch allows to store upload progress informations in session variables. > These informations can be retrieved by an other script while the upload is > still in progress, allowing to provide feedback to the user. > Im

Re: [PHP-DEV] Patch for #41996

2008-07-21 Thread Martin Jansen
On Mon, Jul 21, 2008 at 7:36 PM, Pierre Joye <[EMAIL PROTECTED]> wrote: > On Mon, Jul 21, 2008 at 12:18 PM, Martin Jansen <[EMAIL PROTECTED]> wrote: >> Attached is a patch plus test case for PHP_5_3's PDO_OCI that fixes >> bug #41996. Should cleanly apply to HEAD,

[PHP-DEV] Patch for #41996

2008-07-21 Thread Martin Jansen
Attached is a patch plus test case for PHP_5_3's PDO_OCI that fixes bug #41996. Should cleanly apply to HEAD, too. Martin Index: oci_statement.c === RCS file: /repository/php-src/ext/pdo_oci/oci_statement.c,v retrieving revision 1.25

[PHP-DEV] Patch for #44301

2008-07-20 Thread Martin Jansen
Attached is a patch plus test case for bug #44301. The patch is for the PDO_OCI that comes with the PHP_5_3 branch, but it should fit for HEAD, too. Martin Index: oci_statement.c === RCS file: /repository/php-src/ext/pdo_oci/oci_stat

[PHP-DEV] New string functions: str_startswith() and str_endswith()

2008-07-19 Thread Martin Jansen
Attached you'll find a patch against PHP_5_3 that implements two new string functions: str_startswith(haystack, needle [, case_sensitivity]) checks if haystack starts with needle. The check is performed case-insensitively, but this can be overridden by passing TRUE as the value for the third para

Re: [PHP-DEV] OpenSSL and Phar

2008-06-22 Thread Martin Jansen
On Sun, Jun 22, 2008 at 10:32 PM, Steph Fox <[EMAIL PROTECTED]> wrote: > It seems we don't use the openssl extension API at all in ext/phar, just the > actual OpenSSL headers and libs. That means Phar with OpenSSL support can be > both built and run without ext/openssl being built at all, but requi

Re: [PHP-DEV] Patch for #42589

2007-10-13 Thread Martin Jansen
Martin Jansen wrote: On Sat Oct 13, 2007 at 11:4625AM +0200, Martin Jansen wrote: Attached is a patch for the MySQL and SQLite drivers of PDO that implements the feature request from #42589 by adding the name of the table where the column is from to the output of getColumnMeta(). Antony

[PHP-DEV] Patch for bug #42322

2007-10-13 Thread Martin Jansen
Attached is a patch and a corresponding test case for bug #42322 against the PHP_5_3 branch. (Antony suggested I don't supply PDO patches against HEAD.) - Martin Index: ext/pdo_mysql/mysql_statement.c === RCS file: /repository/php

Re: [PHP-DEV] Patch for #42589

2007-10-13 Thread Martin Jansen
On Sat Oct 13, 2007 at 11:4625AM +0200, Martin Jansen wrote: > Attached is a patch for the MySQL and SQLite drivers of PDO that > implements the feature request from #42589 by adding the name of the > table where the column is from to the output of getColumnMeta(). Antony already impleme

Re: [PHP-DEV] Unification of phpinfo() output for PDO drivers

2007-10-13 Thread Martin Jansen
On Fri Oct 12, 2007 at 01:5229PM -0700, Stanislav Malyshev wrote: > Martin Jansen wrote: > >The attached patch against HEAD attempts to unify the phpinfo() output > >of the PDO drivers for Oracle, MySQL, and PostgreSQL by always including > >the PECL module version string and

[PHP-DEV] Patch for #42589

2007-10-13 Thread Martin Jansen
Attached is a patch for the MySQL and SQLite drivers of PDO that implements the feature request from #42589 by adding the name of the table where the column is from to the output of getColumnMeta(). The change for MySQL seems to be pretty straightforward, but for SQLite I had to add the SQLITE_ENA

[PHP-DEV] Unification of phpinfo() output for PDO drivers

2007-10-12 Thread Martin Jansen
The attached patch against HEAD attempts to unify the phpinfo() output of the PDO drivers for Oracle, MySQL, and PostgreSQL by always including the PECL module version string and the $Id$ CVS keyword. (Akin to how it is done for the SQLite driver.) Assuming that you are interested in the changes,

[PHP-DEV] Stray \ in ext/mysql/php_mysql.c

2007-10-12 Thread Martin Jansen
When building HEAD, GCC complains about a stray backslash in ext/mysql/php_mysql.c. The attached patch fixes this. - Martin Index: php_mysql.c === RCS file: /repository/php-src/ext/mysql/php_mysql.c,v retrieving revision 1.244 diff -u

Re: [PHP-DEV] PHP Release Process Sucks

2006-05-17 Thread Martin Jansen
On Tue May 16, 2006 at 09:5439PM +0100, Phil Driscoll wrote: > I guess as well as a software list, we need an important platform list so we > know that an RC has been exercised on at least: > Linux X86 Apache module > Linux X86_64 Apache module > BSD Apache module > Solaris Apache module > Windows

Re: [PHP-DEV] Re: PHP 5.1 (Or How to break tousands of apps outthere)

2005-11-26 Thread Martin Jansen
On Sat Nov 26, 2005 at 09:5522AM +0100, Ron Korving wrote: > > Speaking of this, I like Greg's suggestion about prefixing all internal > > classes with PHP_. While there are certainly classes out there that are > > prefixed with it, we could tell developers that starting with e.g. PHP 6 > > the PH

Re: [PHP-DEV] Re: PHP 5.1 (Or How to break tousands of apps outthere)

2005-11-26 Thread Martin Jansen
On Fri Nov 25, 2005 at 09:1028PM +0100, Marcus Boerger wrote: > i think you didn't understand the whole point here. Naming something > after an every day word just like 'Date' is like screaming for problems in > bigger scenarios. It is a beginners mistake to not prefix such stuff. Assuming this

[PHP-DEV] Typo fix for tests/lang/038.phpt

2004-07-13 Thread Martin Jansen
Attached is a patch that fixes a typo in the test case tests/lang/038.phpt. -- - Martin Martin Jansen http://martinjansen.com/ Index: tests/lang/038.phpt === RCS file

[PHP-DEV] Improving error messages when using indirect references

2004-02-13 Thread Martin Jansen
on line 4"? -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Warnings in include files suddenly treated as fatal

2004-01-30 Thread Martin Jansen
-- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/xsl php_xsl.c php_xsl.h xsl_fe.h xsltprocessor.c

2004-01-19 Thread Martin Jansen
unctions() (Christian) Shouldn't the method be called registerPHPFunctions() (PHP in uppercase letters) instead? -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] implicit_clone

2003-06-22 Thread Martin Jansen
add "backwards compatibility" to a whole project without much work. -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PEAR-DEV] [RFC] Binary pecl packages

2003-06-19 Thread Martin Jansen
ard. Agreed. Just a minor note: If the -t option isn't specified, it should default to "-t pear", as packaging this format will happen most times, imo. -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Moving to PECL

2003-06-10 Thread Martin Jansen
net being equivalent (== same machine, same codebase) to pear.php.net but with a slightly different logo/color scheme and only showing the PECL packages. -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Why Move to PECL?

2003-06-10 Thread Martin Jansen
isible and we'll only have to maintain one site instead of two. -- - Martin Martin Jansen http://martinjansen.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] If you want to avoid annoying CS commits

2003-04-04 Thread Martin Jansen
On Fri, 2003-04-04 at 19:35, Sterling Hughes wrote: > On Fri, 2003-04-04 at 12:42, Martin Jansen wrote: > > On Fri, 2003-04-04 at 19:15, Sterling Hughes wrote: > > > On Fri, 2003-04-04 at 12:26, Martin Jansen wrote: > > > > "In PECL all code has to follow the P

RE: [PHP-DEV] If you want to avoid annoying CS commits

2003-04-04 Thread Martin Jansen
On Fri, 2003-04-04 at 19:15, Sterling Hughes wrote: > On Fri, 2003-04-04 at 12:26, Martin Jansen wrote: > > "In PECL all code has to follow the PHP coding standards." > > (http://pear.php.net/manual/en/developers.meaning.php) > > > > Then the manual is wrong.

RE: [PHP-DEV] If you want to avoid annoying CS commits

2003-04-04 Thread Martin Jansen
On Fri, 2003-04-04 at 18:26, Sterling Hughes wrote: > No, in PEAR. In PECL your code can look however it likes, at least > that's my understanding. The manual states it differently: "In PECL all code has to follow the PHP coding standards." (http://pear.php.net/manual/en/developers.meaning.php)

Re: [PHP-DEV] socket_iovec_alloc segfault && security advisory

2003-03-27 Thread Martin Jansen
On Thu, 2003-03-27 at 09:42, Marcus Börger wrote: > At 19:17 26.03.2003, Martin Jansen wrote: > >On Wed, 2003-03-26 at 15:29, Antony Dovgal wrote: > > > I just don't see any reasons to include experimental extensions, > > > that will cause such "security ad

Re: [PHP-DEV] socket_iovec_alloc segfault && security advisory

2003-03-26 Thread Martin Jansen
On Wed, 2003-03-26 at 15:29, Antony Dovgal wrote: > I just don't see any reasons to include experimental extensions, > that will cause such "security advisories", into the core distribution. > Someone can explain this to me, maybe I'm wrong? The plan is to move a lot of extension to PECL, once th

Re: [PHP-DEV] socket_iovec_alloc segfault && security advisory

2003-03-26 Thread Martin Jansen
On Wed, 2003-03-26 at 10:39, Antony Dovgal wrote: > On Wed, 26 Mar 2003 01:30:11 -0800 (Pacific Standard Time) > Rasmus Lerdorf <[EMAIL PROTECTED]> wrote: > > > I don't see how it is in any way exploitable. > That's what I wanted to say indeed. > > IMHO it will be much better to move this extensi