[PHP-DEV] Re: Issuing CVEs for PHP

2019-04-29 Thread Lior Kaplan
On Mon, Apr 29, 2019 at 6:51 AM Stanislav Malyshev wrote: > Hi! > > I have set up PHP as CNA (CVE Identifiers authority) with MITRE. That > means that we will be assigning our own CVEs from now on. The process in > broad strokes works like this: > > 1. We request a block of numbers > 2. When we h

Re: [PHP-DEV] pdo_dblib pull requests

2016-02-06 Thread Lior Kaplan
Hi Adam, First, thanks for contributing. I think the best way would be to try and provide tests (part of the PR) and test environment for this change. If the latter can't be provided, maybe instructions how to create one (as you guys probably have far more experience then us). Kaplan ___

[PHP-DEV] Re: compiling php 5.6.# fails with sun CC 12.3 sparc sol 10, no problem 5.5 or 5.3

2016-01-25 Thread Lior Kaplan
Please try the sources available from the website (e.g. 5.6.17), these are already have some files pre-generated. Regradless, which versions of re2c/bison do you have on that system? Kaplan From: Ross, Christine Sent: Saturday, January 23, 2016 11:29 PM

Re: [PHP-DEV] mcrypt extermination plan

2016-01-07 Thread Lior Kaplan
On Jan 7, 2016 6:59 PM, "Remi Collet" wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 07/01/2016 17:54, Scott Arciszewski a écrit : > > All, > > > > I propose the following timeline to give ext/mcrypt the viking > > funeral it deserves: > > > > PHP 7.1 - all mcrypt functions rais

Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

2015-12-24 Thread Lior Kaplan
On Thu, Dec 24, 2015 at 1:09 PM, Tom Sommer wrote: > On 2015-12-16 14:41, Tom Sommer wrote: > >> Hi >> >> I realise 7.0.1 is already out in RC1, but there is a bug in the >> Litespeed 6.8 sapi which breaks php_flag and php_value. It's causing >> our customers a lot of headaches. >> >> I see Lites

Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

2015-12-16 Thread Lior Kaplan
George, Can you take a look at Tom's comment about this problem. Thanks, Kaplan On Wed, Dec 16, 2015 at 3:51 PM, Lior Kaplan wrote: > Hi Tom, > > The patch isn't even committed to the 7.0 branch, only exists on master. > > And also 7.0.1 is already tagged a few

Re: [PHP-DEV] Push Litespeed SAPI 6.9 to PHP 7.0.1

2015-12-16 Thread Lior Kaplan
Hi Tom, The patch isn't even committed to the 7.0 branch, only exists on master. And also 7.0.1 is already tagged a few hours ago. So, do the change on 7.0 branch and it will be part of 7.0.2. Kaplan On Wed, Dec 16, 2015 at 3:41 PM, Tom Sommer wrote: > Hi > > I realise 7.0.1 is already out i

[PHP-DEV] Travis CI is failing

2015-12-15 Thread Lior Kaplan
Hi, Travis CI reports show quite a lot of failures with recent commits to few of the branches. >From a quick look it fails due to tests and not due to compilation issues. Please check the status of the build/tests after your commits: https://travis-ci.org/php/php-src/branches At the moment ext/s

Re: [PHP-DEV] PHP 5.6 life cycle

2015-12-06 Thread Lior Kaplan
Well, August 2015 has already passed. I guess 5.6 will be extended till Dec 2016 and security support till Dec 2017. But that's for the community to decide. Kaplan On Sun, Dec 6, 2015 at 2:14 PM, Jan Ehrhardt wrote: > See http://php.net/supported-versions.php > > Will PHP 5.6 go into 'security

Re: [PHP-DEV] 7.1 release date ?

2015-12-05 Thread Lior Kaplan
A year is the general time frame. 5.6 was August 2014. But don't forget you need to aim for 9 months due to feature freeze and such. Thanks for contributing. Kaplan On Dec 5, 2015 3:09 PM, "François Laupretre" wrote: > Hi, > > It may seem an obvious or odd question but do we have an estimated >

Re: [PHP-DEV] PHP 7.0.0 final RTM delay

2015-12-03 Thread Lior Kaplan
They just released: https://mta.openssl.org/pipermail/openssl-announce/2015-December/49.html Kaplan On Thu, Dec 3, 2015 at 5:10 PM, Andi Gutmans wrote: > Is there an update on the OpenSSL front...? > Is this release of OpenSSL going to be binary compatible or just source > compatible? >

Re: [PHP-DEV] Re: Pear fetch script problem on PHP 7.0

2015-11-23 Thread Lior Kaplan
35dad4 in do_cli [inlined] () at /php-7.0.0RC7/sapi/cli/php_cli.c:974 #16 0x00010035dad4 in main (argc=1606416352, argv=0x7fff5fbff7e0) at php_cli.c:1345 (again, works fine on Linux) Kaplan On Sun, Nov 22, 2015 at 10:51 PM, Andrea Faulds wrote: > Hi Lior, > > Lior Kaplan wro

[PHP-DEV] Pear fetch script problem on PHP 7.0

2015-11-22 Thread Lior Kaplan
Hi, Trying to build PHP 7 RC7 on Darwin I get: [activating module `php7' in /usr/local/zend/apache2/conf/httpd.conf] Installing PHP CLI binary:/usr/local/zend/bin/ Installing PHP CLI man page: /usr/local/zend/share/man/man1/ Installing phpdbg binary: /usr/local/zend/bin/ Inst

Re: [PHP-DEV] SQLite 3.9.X in PHP 7.0.0RC6?

2015-10-21 Thread Lior Kaplan
I think it's too soon to update to the 3.9 branch (let it get a little more stable). But if the RM ask for this change I'll be happy to do that. Kaplan On Wed, Oct 21, 2015 at 12:13 PM, Mark Tomlin wrote: > Will we see the bundled SQLite updated to the 3.9.x released in PHP > 7.0.0RC6? > > -

Re: [PHP-DEV] mysqli_get_cache_stats() has vanished

2015-08-25 Thread Lior Kaplan
This might help: https://github.com/php/php-src/commit/f9ad56eab9e0010231643d51a0e0038f99f2f94b Kaplan On Tue, Aug 25, 2015 at 2:25 PM, Christoph Becker wrote: > Hi! > > Does anybody know what happened to mysqli_get_cache_stats()? > Apparently, its implementation has vanished between two conse

[PHP-DEV] Introducing ChangeLog-7.php to the website

2015-07-13 Thread Lior Kaplan
Hi, With the release of 7.0.0 beta 1 I think it's time we introduce ChangeLog-7.php to the website. Both ChangeLog-4.php and ChangeLog-5.php have started with the first Beta of the major releases. Any objections ? Kaplan

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-20 Thread Lior Kaplan
Just my two cent for background: Debian / Ubuntu has decided to drop this due to dead upstream and lack of maintenance. So this seem also reasonable for us. Kaplan

[PHP-DEV] Re: PHP-7.0.0 branch

2015-06-09 Thread Lior Kaplan
On Tue, Jun 9, 2015 at 4:29 PM, Ferenc Kovacs wrote: > > On Tue, Jun 9, 2015 at 3:23 PM, Lior Kaplan wrote: > >> Hi Guys, >> >> A quick question - I saw PHP-7.0.0 branch, should it be PHP-7.0 branch >> (while master continues to 7.1). >> >> The PH

Re: [PHP-DEV] error git push - You have insufficient Karma for gtk-src.git!

2015-06-07 Thread Lior Kaplan
What about sending pull requests against https://github.com/php/php-gtk-src ? Kaplan On Sun, Jun 7, 2015 at 3:20 PM, Alexandre Pereira Bühler < alexan...@simaoebuhler.com.br> wrote: > Desire to develop and update the source code of php-gtk > (http://git.php.net/?p=php/gtk-src.git;a=summary0 but

Re: [PHP-DEV] libpcre 8.37 requires extra flags (at least on AIX)

2015-05-25 Thread Lior Kaplan
Hi, It seems to be AIX only thing, as it builds fine for me for Linux/Darwin. Any hints ? Kaplan On Wed, May 20, 2015 at 9:28 PM, Stanislav Malyshev wrote: > Hi! > > > While building the PHP 5.6.9 (which has libpcre 8.37) it seems we're > > missing -lpthreads build flag (for cli SAPI), as thi

Re: [PHP-DEV] About merging Pull Request workflow

2015-05-21 Thread Lior Kaplan
Yep, is a real problem. We should keep the credit / commit info. I think we should remove "--no-ff" so it would just add the relevant commits instead of actually merging them without history (or even rebase the pull request to recent branch before merging). Kaplan On Thu, May 21, 2015 at 10:16

[PHP-DEV] libpcre 8.37 requires extra flags (at least on AIX)

2015-05-20 Thread Lior Kaplan
Hi, While building the PHP 5.6.9 (which has libpcre 8.37) it seems we're missing -lpthreads build flag (for cli SAPI), as this library upgrade added this requirement. The files requiring is pcrelib/sljit/sljitUtils.c 5.5.25, which doesn't have this file, works fine without the flag. I think thi

Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

2015-05-20 Thread Lior Kaplan
On Wed, May 20, 2015 at 2:31 PM, Anatol Belski wrote: > Hi, > > -Original Message- > From: Stanislav Malyshev [mailto:smalys...@gmail.com] > Sent: Wednesday, May 20, 2015 10:45 AM > To: Lior Kaplan; PHP internals list > Subject: Re: [PHP-DEV] pcrelib version d

Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

2015-05-20 Thread Lior Kaplan
1:07 PM, Ferenc Kovacs wrote: > > > On Wed, May 20, 2015 at 10:56 AM, Lior Kaplan wrote: > >> On Wed, May 20, 2015 at 11:44 AM, Stanislav Malyshev > > >> wrote: >> >> > Hi! >> > >> > > 1. Just noticed that 5.5.25 has pcrelib 8.36 while

Re: [PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

2015-05-20 Thread Lior Kaplan
On Wed, May 20, 2015 at 11:44 AM, Stanislav Malyshev wrote: > Hi! > > > 1. Just noticed that 5.5.25 has pcrelib 8.36 while 5.6.9 has 8.37. > > That's probably because of a slight difference between the branch points. > > > > I'll update the news / changelog > > 8.37 contains some important fixes.

[PHP-DEV] pcrelib version differs between 5.5.25 / 5.6.9

2015-05-20 Thread Lior Kaplan
Hi, 1. Just noticed that 5.5.25 has pcrelib 8.36 while 5.6.9 has 8.37. That's probably because of a slight difference between the branch points. I'll update the news / changelog 2. It seems that changes to 8.37 doesn't include all files (e.g. ext/pcre/pcrelib/pcre.h which still states 8.36). (c

[PHP-DEV] odbc extension build issues (shared vs. standalone)

2015-03-26 Thread Lior Kaplan
Hi, Following Remi's revert of my commit [1] I'd like to suggest a better solution for master which would be introducing --enable-odbc and having the ODBC drivers default to no (similar to DBA). Current problem is fixing build as a standalone (phpize...) breaks support with builds as "./configure

Re: [PHP-DEV] 7.0 Release Management

2015-03-21 Thread Lior Kaplan
On Sun, Mar 22, 2015 at 3:38 AM, Leigh wrote: > Hi all, > > With 7.0 feature freeze in effect, and proposals and RFCs still coming in > that are going to target 7.1, I think it's time we branched master and > selected a release manager (or two) for 7.0. > I would branch only in time for the firs

Re: [PHP-DEV] Can we remove "NEWS" tag ?

2015-02-11 Thread Lior Kaplan
Renamed to NEWS-cvs2svn Kaplan On Feb 11, 2015 5:11 PM, "Andrea Faulds" wrote: > Hi, > > > On 11 Feb 2015, at 09:52, Lior Kaplan wrote: > > > > Hi, > > > > I've been doing some editing to the NEWS files, and keep getting this > > prob

[PHP-DEV] Can we remove "NEWS" tag ?

2015-02-11 Thread Lior Kaplan
Hi, I've been doing some editing to the NEWS files, and keep getting this problem $ git diff NEWS fatal: ambiguous argument 'NEWS': both revision and filename Use '--' to separate filenames from revisions Although I can do as it suggests, I would prefer to remove the NEWS tag we have since 2008

Re: [PHP-DEV] Enable opcache by default in PHP7?

2015-02-02 Thread Lior Kaplan
On Feb 3, 2015 7:59 AM, "Pierre Joye" wrote: > > On Feb 3, 2015 11:26 AM, "Xinchen Hui" wrote: > > > > Hey: > > > > opcache is disabled by default configure, I am plan to enable it > > by default > > > > and also add zend_extension=opcache.so in > php.ini-product/developmement > > > >

Re: [PHP-DEV] Delete PHPNG branch from repo?

2015-01-30 Thread Lior Kaplan
+1 On Jan 30, 2015 4:15 PM, "Ferenc Kovacs" wrote: > On Fri, Jan 30, 2015 at 3:04 PM, Xinchen Hui wrote: > > > Hey: > > > >there already are more than 2 people tell me they are trying to > > play with PHP7, but turns out they are playing with PHPNG branch(since > > we used to call it phpng).

Re: [PHP-DEV] Question about patch for bug 61285 - SSL connections do not timeout

2015-01-04 Thread Lior Kaplan
Hi Brad, The fix should go to the lowest relevant branch, in this case probably the 5.5 branch. >From there it will be merged to 5.6 and master (future 7.0)/ I took a quick look at the build, and which it compiles successfully, it seems to be a diff in the test. I suspect it comes from changes in

Re: [PHP-DEV] CVE-2014-8142 is not mentioned in 5.6.4 changelog

2014-12-25 Thread Lior Kaplan
Fixed. http://git.php.net/?p=web/php.git;a=commitdiff;h=52cb11fca4c343f0529ceecfdc5372b49b966435 (should be refreshed on the website soon enough) On Wed, Dec 24, 2014 at 6:58 AM, Yasuo Ohgaki wrote: > Hi, > > http://php.net/ChangeLog-5.php#5.4.36 > does not mention CVE-2014-8142. > > Fixed bug

[PHP-DEV] Re: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file

2014-12-17 Thread Lior Kaplan
Ignore this, already fixed by Stas... didn't notice. http://git.php.net/?p=php-src.git;a=commitdiff;h=b75867fff0d141bf2f81646dd5fae991e85b26ca Kaplan On Wed, Dec 17, 2014 at 4:05 PM, Lior Kaplan wrote: > > Hi, > > Can someone please do this minor change in the PHP 5.4 tests ?

[PHP-DEV] Re: PHPT curl tests - PHP 5.3.4 branch misses the skipif.inc file

2014-12-17 Thread Lior Kaplan
Hi, Can someone please do this minor change in the PHP 5.4 tests ? Kaplan On Wed, Dec 3, 2014 at 6:08 PM, Lior Kaplan wrote: > > Hi Stas, > > I don't have permissions to fix this myself as the 5.4 branch is closed > for security only. > > You've added ext

Re: [PHP-DEV] bison 3.0

2014-12-11 Thread Lior Kaplan
AFAIK, PHP builds fine with bison 3. At least with the common scenarios on UNIX like systems. TS builds might be the problem if my memory serves me right. Kaplan On Thu, Dec 11, 2014 at 9:36 AM, Ferenc Kovacs wrote: > On Thu, Dec 11, 2014 at 8:52 AM, Sebastian Bergmann > wrote: > > > Hi! > >

Re: [PHP-DEV] PHP 5.4.35's ChangLog is misplaced

2014-12-03 Thread Lior Kaplan
The change was to make sure it's ordered by date first, than by version number. Before the change a version released in October appears higher than one released in November. Kaplan On Wed, Dec 3, 2014 at 3:25 PM, Ferenc Kovacs wrote: > > > On Wed, Dec 3, 2014 at 2:44 PM, Lior

Re: [PHP-DEV] PHP 5.4.35's ChangLog is misplaced

2014-12-03 Thread Lior Kaplan
Fixed. (allow a few minutes for the change to take affect). Kaplan On Mon, Nov 17, 2014 at 6:44 AM, Yasuo Ohgaki wrote: > Hi webmasters and/or RMs, > > PHP 5.4.35's ChangLog is misplaced. > > http://php.net/ChangeLog-5.php#5.4.35 > > It should be after 5.5.19, not after 5.6.2. > > Regards, > >

Re: [PHP-DEV] Re: PowerPC64 patchs

2014-12-02 Thread Lior Kaplan
Remi, Any chance to have these fixes for 5.5/5.6 as well? Kaplan On Mon, Dec 1, 2014 at 11:09 AM, Remi Collet wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 27/11/2014 13:39, Gustavo Frederico Temple Pedrosa a écrit : > > Hi, internals! > > > > There are some PRs for supports

Re: [PHP-DEV] Bug 55700 fix

2014-09-01 Thread Lior Kaplan
On Sep 2, 2014 8:55 AM, "Michael Wallner" wrote: > > On 2 Sep 2014 00:13, "Chris Wright" wrote: > > > > If no-one has any objections to this, I would like to merge it into > > 5.6 and master. > > > > +1 Why not 5.5 ? Kaplan

Re: [PHP-DEV] master is broken on Travis

2014-08-20 Thread Lior Kaplan
On Thu, Aug 21, 2014 at 12:29 AM, Stas Malyshev wrote: > Hi! > > > Removed phpdbg build from configure, and master builds fine. > > > > Removed its tests as well to have travis finish green. > > Did you commit it? I see Travis CI build is still broken. > Committed and it works, the build done at

Re: [PHP-DEV] master is broken on Travis

2014-08-20 Thread Lior Kaplan
On Tue, Aug 19, 2014 at 1:46 AM, Bob Weinand wrote: > Am 19.8.2014 um 00:09 schrieb Stas Malyshev : > > Hi! > > > > Since we've had phpng branch merged to master the build on Travis CI is > > broken for master (as in, doesn't even build). Could it be fixed? It's > > not a good thing that we have

Re: [PHP-DEV] Re: 5.6.0 final is near

2014-08-19 Thread Lior Kaplan
Please make sure these security fixes are included: fileinfo: Fixed bug #67716 (Segfault in cdf.c). (CVE-2014-3587) gd: Fixed bug #67730 (Null byte injection possible with imagexxx functions). (CVE-2014-5120) Thanks, Kaplan On Mon, Aug 18, 2014 at 5:46 PM, Ferenc Kovacs wrote: > On Sun, Aug

Re: [PHP-DEV] FW: PowerPC64 support

2014-07-24 Thread Lior Kaplan
On Thu, Jul 24, 2014 at 5:23 PM, Andrea Faulds wrote: > > On 24 Jul 2014, at 12:17, Gustavo Frederico Temple Pedrosa < > gustavo.pedr...@eldorado.org.br> wrote: > > > I and my team are involved in changes for architecture-specific > implementations, > > specifically PowerPC64, in favor of expand

[PHP-DEV] Pull requests report (28/10/2013)

2013-10-28 Thread Lior Kaplan
php/php-src/pull/502>Allow unlimited line length in fpm config files Kaplan On Mon, Oct 21, 2013 at 1:36 PM, Lior Kaplan wrote: > Hi, > > This week we've reached to PR #500 after 2 years of getting PRs > officially. > The more steady stream of PRs started in March 2012... s

[PHP-DEV] PR #479

2013-10-22 Thread Lior Kaplan
Can someone with Zend karma take a look at this ? https://github.com/php/php-src/pull/479/files Replace invalid code with a proper #error > This code creates a nasty error as mentioned in bugs #31131, #37062 > Patch taken from Debian's PHP package: 044-strtod_arm_fix I would have merged myself,

[PHP-DEV] Pull requests report (21/10/2013)

2013-10-21 Thread Lior Kaplan
;https://github.com/php/php-src/pull/295> Call zend_throw_exception_hook before no stack frame check #490 <https://github.com/php/php-src/pull/490> Add "honor_server_ciphers" ssl context option to mitigate BEAST #492 <https://github.com/php/php-src/pull/492> fix set_magic_quotes_runtim

Re: [PHP-DEV] Gnu/Hurd support

2013-10-02 Thread Lior Kaplan
On Sat, Sep 28, 2013 at 3:44 PM, Lior Kaplan wrote: > On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans wrote: > >> And bug 31347 is that was a fix for a specific issue on Windows: >> https://bugs.php.net/bug.php?id=31347 >> > > The patch originates in Debian,

[PHP-DEV] Pull requests report (30/9/2013)

2013-09-30 Thread Lior Kaplan
; Allow ini files to have a [SAPI=] section in exactly the same manner as [PATH=] and [HOST=] #469 <https://github.com/php/php-src/pull/469> Streams: Configure crypto method for ssl:// transports #470 <https://github.com/php/php-src/pull/470> anon class objects Kaplan On Mon, Se

Re: [PHP-DEV] Gnu/Hurd support

2013-09-28 Thread Lior Kaplan
On Sat, Sep 28, 2013 at 12:57 PM, Derick Rethans wrote: > And bug 31347 is that was a fix for a specific issue on Windows: > https://bugs.php.net/bug.php?id=31347 > The patch originates in Debian, and I can assure you that they don't build for Windows (: So that's a good point, thanks. We could

Re: [PHP-DEV] Gnu/Hurd support

2013-09-28 Thread Lior Kaplan
On Fri, Sep 27, 2013 at 3:02 PM, Derick Rethans wrote: > On Thu, 26 Sep 2013, Lior Kaplan wrote: > > > Hi, > > > > In Debian we build PHP for GNU/Hurd system, which need some minor fixes > > available here: > > > > > http://anonscm.debian.org/gitweb/?

Re: [PHP-DEV] Gnu/Hurd support

2013-09-27 Thread Lior Kaplan
On Thu, Sep 26, 2013 at 5:04 PM, Christopher Jones < christopher.jo...@oracle.com> wrote: > > Can you create a PR on github for them? > Of course. https://github.com/php/php-src/pull/476 Kaplan

[PHP-DEV] Gnu/Hurd support

2013-09-26 Thread Lior Kaplan
Hi, In Debian we build PHP for GNU/Hurd system, which need some minor fixes available here: http://anonscm.debian.org/gitweb/?p=pkg-php/php.git;a=blob;f=debian/patches/116-posixness_fix.patch (per the guidelines here: http://www.gnu.org/software/hurd/hurd/porting/guidelines.html#PATH_MAX_tt_MAX_

[PHP-DEV] Pull requests report (23/9/2013)

2013-09-23 Thread Lior Kaplan
error number any more #447 <https://github.com/php/php-src/pull/447> Bug 52124 #448 <https://github.com/php/php-src/pull/448> Bug 45543 #449 <https://github.com/php/php-src/pull/449> Bug 48225 #451 <https://github.com/php/php-src/pull/451> Bug 65672 #453 <https://github.c

[PHP-DEV] Pull requests report (16/9/2013)

2013-09-16 Thread Lior Kaplan
n: pcntl_daemonize & pcntl_setaffinity #421 <https://github.com/php/php-src/pull/421> Dedicated syntax for variadic parameters #424 <https://github.com/php/php-src/pull/424> Signature is valid if there are less args #426 <https://github.com/php/php-src/pull/426> Parameter skip

[PHP-DEV] Pull requests report (9/9/2013)

2013-09-09 Thread Lior Kaplan
f there are less args #426 <https://github.com/php/php-src/pull/426> Parameter skipping in function calls Kaplan On Tue, Sep 3, 2013 at 9:31 AM, Lior Kaplan wrote: > New: > #422 <https://github.com/php/php-src/pull/422> Add test for bug #60598 > #424 <https://github.com/ph

[PHP-DEV] Pull requests report (3/9/2013)

2013-09-03 Thread Lior Kaplan
cntl_setaffinity #421 <https://github.com/php/php-src/pull/421> Dedicated syntax for variadic parameters Kaplan On Tue, Aug 27, 2013 at 9:00 PM, Lior Kaplan wrote: > Hi, > > I'm please to say that we keep processing the requests faster and faster, > leaving only few n

Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)

2013-08-28 Thread Lior Kaplan
On Wed, Aug 28, 2013 at 10:45 PM, Stas Malyshev wrote: > Hi! > > > http://marc.info/?l=php-internals&m=136768085009866&w=2 > > This is great but this is not exactly what I'm talking about. There's a > big difference between having an extension that does JSON in PECL and > replacing part of PHP cor

Re: [PHP-DEV] Attitude against distributions... (Was: JSON non-free license)

2013-08-28 Thread Lior Kaplan
On Wed, Aug 28, 2013 at 9:50 PM, Stas Malyshev wrote: > Hi! > > > I would like to react on Stat's "it's-not-our-problem" comment in > > https://bugs.php.net/bug.php?id=63520 > > However, given all that, I think the matter would be handled better if, > before taking decisions that can influence man

[PHP-DEV] Pull requests report (27/8/2013)

2013-08-27 Thread Lior Kaplan
ages and error output binary safe #416 <https://github.com/php/php-src/pull/416> New function: pcntl_daemonize & pcntl_setaffinity Kaplan On Thu, Aug 22, 2013 at 2:24 AM, Lior Kaplan wrote: > (reporting about two weeks) > > Merged requests (past 7 days): > #359 <https://g

[PHP-DEV] Pull requests report (21/8/2013)

2013-08-21 Thread Lior Kaplan
& lineno for the DTRACE_FUNCTION_ENTRY/RETURN cases #416 <https://github.com/php/php-src/pull/416> New function: pcntl_daemonize & pcntl_setaffinity Kaplan p.s. For those of you who want some perspective on merges done in the last month: http://liorkaplan.wordpress.com/2013/08/11/gett

[PHP-DEV] Pull requests report (7/8/2013)

2013-08-07 Thread Lior Kaplan
p-src/pull/398> Fix #65069: GlobIterator fails to access files inside an open_basedir restricted dir Kaplan On Tue, Jul 30, 2013 at 11:56 AM, Lior Kaplan wrote: > The last week was characterized with less merges but more comments > on the open and new pull requests (thanks Anatol

[PHP-DEV] Pull requests report (30/7/2013)

2013-07-30 Thread Lior Kaplan
mespaced functions #390 <https://github.com/php/php-src/pull/390> Add DateInterval::add method #393 <https://github.com/php/php-src/pull/393> Fix #60873: Add read_property handler for DateTime object Kaplan On Tue, Jul 23, 2013 at 10:41 AM, Lior Kaplan wrote: > This is the 3rd

[PHP-DEV] Pull requests report (23/7/2013)

2013-07-23 Thread Lior Kaplan
This is the 3rd report, and I'm glad to see more people reviewing & commenting the requests. Thanks. Merged requests (past 7 days): #99 Added recursivetreeiterator::setPostfix() method #231 Bringing CSS up to th

Re: [PHP-DEV] Pull requests report (17/7/2013)

2013-07-18 Thread Lior Kaplan
On Thu, Jul 18, 2013 at 10:00 PM, Stas Malyshev wrote: > > Also, we have more than a few PR which the patch is OK, but are stuck due > > to a > > missing test. This is fair enough, but should also have some rule of > thumb > > for > > these cases. > > Again, it would not be hard to add tests for m

Re: [PHP-DEV] Pull requests report (17/7/2013)

2013-07-18 Thread Lior Kaplan
On Thu, Jul 18, 2013 at 4:21 AM, Sherif Ramadan wrote: > On Wed, Jul 17, 2013 at 6:47 PM, Lior Kaplan wrote: > >> What do you think about closing older PR ( > 28 days) ? >> > > First off, thanks for all the hard work. PRs aren't getting as much > attention

[PHP-DEV] Pull requests report (17/7/2013)

2013-07-17 Thread Lior Kaplan
ps://bugs.php.net/bug.php?id=65225>: PHP_BINARY incorrectly set #382 <https://github.com/php/php-src/pull/382> Added support for not canonicalizing the SASL realm on sasl_binds for LDAP What do you think about closing older PR ( > 28 days) ? Kaplan On Wed, Jul 10, 2013 at 3:36 PM,

[PHP-DEV] Pull requests report (10/7/2013)

2013-07-10 Thread Lior Kaplan
Hi, Following my suggestion to help with pull requests, I'm going to send a report about new & ongoing pull requests. I hope it will help us to handle them more efficiently and lower the response time for patches. Feedback is much appriciated. New (last 7 days): #375

Re: [PHP-DEV] VCS Account Request: kaplan

2013-07-09 Thread Lior Kaplan
hgaki wrote: > If you are people from Zend, it's faster to ask Zeev or anyone else who > already have karma. > > -- > Yasuo Ohgaki > yohg...@ohgaki.net > > > 2013/7/9 Lior Kaplan > >> Ping ? >> >> On Thu, Jun 27, 2013 at 2:01 PM, Lior Kapla

Re: [PHP-DEV] VCS Account Request: kaplan

2013-07-09 Thread Lior Kaplan
Ping ? On Thu, Jun 27, 2013 at 2:01 PM, Lior Kaplan wrote: > Helping with merging patches and pull requests > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >

Re: [PHP-DEV] Cherry picking #60560 for php 5.4

2013-06-29 Thread Lior Kaplan
On Fri, Jun 28, 2013 at 11:47 PM, Stas Malyshev wrote: > Hi! > > > Bug #60560 was fixed in trunk while PHP 5.4 was in its RC phases. The fix > > was never merged back to the 5.4 branch, meaning it's only avaailable on > > the 5.5 release. > > > > Could we cherry pick it for the 5.4 branch ? > > >

[PHP-DEV] Cherry picking #60560 for php 5.4

2013-06-27 Thread Lior Kaplan
Hi, Bug #60560 was fixed in trunk while PHP 5.4 was in its RC phases. The fix was never merged back to the 5.4 branch, meaning it's only avaailable on the 5.5 release. Could we cherry pick it for the 5.4 branch ? The relevant commit is http://git.php.net/?p=php-src.git;a=commit;h=37272e46def5673

[PHP-DEV] VCS Account Request: kaplan

2013-06-27 Thread Lior Kaplan
Helping with merging patches and pull requests -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Who's incharge of github pull requests?

2013-06-26 Thread Lior Kaplan
ost > of we are volunteers), and cares about testing the patch for such > extension, to get it applied. > > Thanks for contributing! > > > 2013/6/16 Lior Kaplan : > > Hi, > > > > It seems the list of pull requests on github is getting bigger, who's > &

[PHP-DEV] Who's incharge of github pull requests?

2013-06-16 Thread Lior Kaplan
Hi, It seems the list of pull requests on github is getting bigger, who's inchange to review it? https://github.com/php/php-src/pulls I must say that my experience so far in trying to push patches through the bug system or pull request is quite deprsing (comparing to other open source projects):

Re: [PHP-DEV] PHP 5.3 - end of live schedule

2012-12-11 Thread Lior Kaplan
On Tue, Dec 11, 2012 at 12:48 PM, Pierre Joye wrote: > what's about: > > - announce 5.3 EOL plan with 5.5 final release > > then: > > - EOL by release of php-next (a year later) > > or > > - EOL by release of php-next+1 (two years later) > > depending on which option got accepted. In all these

[PHP-DEV] Non ASCII char in php.ini [patch]

2012-06-25 Thread Lior Kaplan
PREF_WRITE_FILE = 44 +; XSL_SECPREF_CREATE_DIRECTORY | XSL_SECPREF_WRITE_NETWORK | XSL_SECPREF_WRITE_FILE = 44 ; Set it to 0 to allow all operations ;xsl.security_prefs = 44 (this is the diff with LC_ALL=c, notice the "" removal. The change isn't visible with UTF-8 locales) Thanks, Lior Kaplan Zend Te

[PHP-DEV] 5.4.0 RC7

2012-02-02 Thread Lior Kaplan
Hi, RC7 is already tagged but misses http://svn.php.net/viewvc?view=revision&revision=323013 for earlier today. Guessing we try to avoid another RC, shouldn't we re-tag to include this fix? It might delay the upcoming release tomorrow of RC7, but might help to have a better final version based on

Re: [PHP-DEV] Uploading 5.4 RC to unstable (Was: Upcoming transition of php5 to 5.4)

2012-02-01 Thread Lior Kaplan
Hi Ondřej, I'd wait for RC7 in any case, and with some luck it will be the final RC for 5.4.0. With my Debian hat on, I would wait for the official release, as to minimize the noise we'll get in Debian from testing RCs. The recent RCs all had some major issues fixed/changed in them (which is bett

Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-02-01 Thread Lior Kaplan
On Tue, 2012-01-31 at 03:58 -0500, Michael Wallner wrote: > On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: > > > Sorry, problem is not solved yet. > > I committed a possible fix to trunk. It's pretty much along > the patch from you, I just hat to fix crashes in the cli server > and ne

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-30 Thread Lior Kaplan
> On Wed, 25 Jan 2012 09:13:43 -0800, Stas Malyshev wrote: > > > Hi! > > > >> We've just found one more critical problem in 5.4. > >> > >> Apache/PHP crashes in case of error on startup, when > >> display_startup_errors=1. It's probably related to new output API. > >> > >> I afraid it may affect