Hi Felipe, Indeed I saw more responsiveness for the pull requests (mine and others), thanks.
The question was about the process of reviewing these requests. 1. Do we have someone in charge (making sure they pass some minimum requirements) or this is done sporadically ? 2. If we do it sporadically, how do we make sure things aren't lost or get stuck (causing us to lose good patches). Yes, most of us are volunteers (both the developers and the patch senders) and this reflects on time issues. With that said, both sides have interest of seeing more patches sent and accepted. As I have experience with this on other projects, I'm trying to help improve the status here. Of course, I'm willing to personally help here, so I'm not just asking you guys to handle this yourselves. Kaplan On Wed, Jun 26, 2013 at 5:28 PM, Felipe Pena <felipe...@gmail.com> wrote: > Hi, > > I saw some patches from you (mentioned in the blog post) has been pushed > to git. > > About the FTP patch, as it requires further testing and an environment > for such, and we do not have an active maintainer currently for the > extension. It tend to have a delay until anyone with free time (most > of we are volunteers), and cares about testing the patch for such > extension, to get it applied. > > Thanks for contributing! > > > 2013/6/16 Lior Kaplan <lio...@zend.com>: > > Hi, > > > > It seems the list of pull requests on github is getting bigger, who's > > inchange to review it? > > https://github.com/php/php-src/pulls > > > > I must say that my experience so far in trying to push patches through > the > > bug system > > or pull request is quite deprsing (comparing to other open source > projects): > > https://liorkaplan.wordpress.com/2013/06/05/getting-patches-into-php/ > > > > Kaplan > > > > -- > Regards, > Felipe Pena >
