Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix PDO_DBLIB bugs - FreeTDS dependency

2013-07-03 Thread Felipe Pena
ion: GnuPG v2.0.19 (GNU/Linux) > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iEYEARECAAYFAlHUXlkACgkQYUppBSnxahhWuwCgkH+mFuqpzFnrm97IGLmzsKP2 > R3sAoLTZFzUfpEYIHoCnh+MfSmSFBWuJ > =iyUp > -END PGP SIGNATURE- > > -- > PHP Internals - PHP Run

Re: [PHP-DEV] Who's incharge of github pull requests?

2013-06-26 Thread Felipe Pena
m trying to help improve > the status here. Of course, I'm willing to personally help here, so I'm not > just asking you guys to handle this yourselves. > > Kaplan > > Cool, so ask for a git account and join us! http://www.php.net/git-php.php > On Wed, Jun 26, 2013 at 5

Re: [PHP-DEV] Who's incharge of github pull requests?

2013-06-26 Thread Felipe Pena
src/pulls > > I must say that my experience so far in trying to push patches through the > bug system > or pull request is quite deprsing (comparing to other open source projects): > https://liorkaplan.wordpress.com/2013/06/05/getting-patches-into-php/ > > Kaplan -- Rega

Re: [PHP-DEV] PHP 5.5.0beta1 ZTS broken build

2013-06-20 Thread Felipe Pena
ed bison 2.7. After locally patching Zend/acinclude.m4 to >> allow "2.7", then the PHP 5.5 testsuite has only five fails, all in gd. > > Which? Should be max 2 (merge issue). -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: About to end 5.3

2013-06-19 Thread Felipe Pena
k you for taking care of this branch for so long. Keep the good > job up. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] PHP 5.5.0beta1 ZTS broken build

2013-03-24 Thread Felipe Pena
ore on how > %parse-param and %lex-param work. If someone wants to do a little light > reading and report back it would be appreciated. > http://www.gnu.org/software/bison/manual/html_node/Parser-Function.html#Parser-Function This page explain how to use it. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Allow (...)->foo() expressions not only for `new`

2013-02-26 Thread Felipe Pena
at we already had with foo()->prop. So it actually was a bug fix. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: Non-pointer params, zend_parse_parameters, and the "!" modifier

2013-02-02 Thread Felipe Pena
if the func is called with NULL as the argument, num will still be >> overwritten to 0, but we'll get the flag indicating that NULL got >> passed in, and we're forced to reset it to the default value (assuming >> that was our intent). >> >> [...] >> Thought

Re: [PHP-DEV] Poor date() performance (v 5.4.9) [PATCH]

2012-12-01 Thread Felipe Pena
is to start tracing through actual > execution and see if I can't find any other obvious issues. My initial > thoughts are that it may be faster to try and cache some of this (for > fcgi purposes), or even have a compile time option to allow a build to > use old 4.4.9 functionality that uses localtime_r() and actually > trusts that the server has the right information set. > > Thanks in advance for looking at this with me! > > As far I remember, the patch must be in a .txt extension to be sent to the list. Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] Incomprehension with preg_match and utf8

2012-11-06 Thread Felipe Pena
\p{Ll} [:space:] becomes \p{Xps} [:upper:] becomes \p{Lu} [:word:] becomes \p{Xwd} Negated versions, such as [:^alpha:] use \P instead of \p. The other POSIX classes are unchanged, and match only characters with code points less than 128. - [1] - http://svn.php.net/viewvc/?view=revision&revision=303963 [2] - http://pcre.org/man.txt -- Regards, Felipe Pena

Re: [PHP-DEV] New String Function: str_replace_limit

2012-07-15 Thread Felipe Pena
tell you how many times it done the > replacement. > > mixed str_replace_limit ( mixed $search , mixed $replace , mixed > $subject [, int $limit ] ) > > Thoughts? > Surely a 5th param is preferred. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] boolval() again

2012-06-06 Thread Felipe Pena
time Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > Pull it! About the RFC, I think isn't necessary as the behavior is obvious, i.e. it behaves like a cast to bool. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] concatenation operator

2012-06-05 Thread Felipe Pena
Hi, 2012/6/5 Adi Mutu : > > > Hello, > > Can somebody point me to where the concatenation operator is implemented ?   > "." operator. > > Thanks, See http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_def.h#133 -- Regards, Felipe Pena -- PHP Internals - PHP R

Re: [PHP-DEV] 5.4.3 type hint handling

2012-06-01 Thread Felipe Pena
IS_LONG, 1) > ZEND_END_ARG_INFO(); > > We do not use ZEND_ARG_TYPE_INFO() with scalar types that are not covered with the type hint supports. (i.e. string, integer, double, resource) -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-QA] Parallel run-tests

2012-05-19 Thread Felipe Pena
> implemented if anyone thought of one. If anyone wants to pick up this aspect > I'd be happy to get them started. > > Zoe > > -- > PHP Quality Assurance Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php > -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Trouble with zend_language_parser.y

2012-05-05 Thread Felipe Pena
                         accessor_function >                                accessor_function >                |              accessor_function >                                accessor_function >                |              accessor_function >                | /* Empty */ > ; > This rule is weird too, do you want a limited number of accessor? -- Regards, Felipe Pena

Re: [PHP-DEV] Patch: getters/setters syntax Implementation

2011-12-04 Thread Felipe Pena
2011/12/4 Felipe Pena : > Hi, > > 2011/12/4 Clint M Priest : >> Updated patch w/o white-space: >> http://www.clintpriest.com/patches/accessors_v1.patch >> >> In the end it is a relatively simple patch.  The new syntax effectively >> creates internal funct

Re: [PHP-DEV] Patch: getters/setters syntax Implementation

2011-12-04 Thread Felipe Pena
ing List > To unsubscribe, visit: http://www.php.net/unsub.php > I've fixed the zend_compile.c and zend_object_handlers.c to build with --enable-maintainer-zts. (some TSRMLS_CC missing and TSRMLS_DC usage instead of TSRMLS_CC) Other thing I have noticed that you have not followed our cod

Re: [PHP-DEV] Fixing string offsets of strings.

2011-12-04 Thread Felipe Pena
eturn. >> >> In theory.. the fetch_dim behavior should be return a empty string if an >> invalid offset is used, or uninitialized zval if ISSET is calling it >> >> Regards >> Alan >> > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > Take a look at Zend/tests/offset_assign.phpt, there is a path hardcoded. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] tweaking "configure --help" for autoconf changes

2011-12-01 Thread Felipe Pena
brackets themselves. > > Can someone please apply this? > > Thanks, > > Applied, thanks! -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] 5.4 regression: non-existent sub-sub keys now have values

2011-11-24 Thread Felipe Pena
The function array dereferencing is unrelated to these changes (it just touched the parser), i.e. it uses the same code used to access the array directly. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Bug 52389

2011-11-18 Thread Felipe Pena
. And which patch have you tried exactly, the pgsql-fixed.diff one? Thanks. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Phar::createDefaultStub on cli-server

2011-11-18 Thread Felipe Pena
bug explaining such behavior. Thanks. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] What's the correct way to report a regression?

2011-11-18 Thread Felipe Pena
into it and decides if it's worth fixing? > > Since I'm not the original reporter of bug #48555, I can't edit it to update > the affected PHP version. Should I have opened a new bug report instead? > Would that have gotten someone's attention? > Please open a

Re: [PHP-DEV] array_key_exists with float keys (bug #60039)

2011-11-18 Thread Felipe Pena
a > bug. > > Therefore I would rather have both throw warnings than none of them. > > So -1 from me for the proposed unification. > Same opinion here. I do prefer not having such implict data repair. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Freeing $1 from zend_language_parser.y

2011-11-18 Thread Felipe Pena
yyparse(). > And in doing so it is causing a memory leak, only if I add: > > efree($1.u.constant.value.str.val); > It's normal when not using the alloc'ed string into the op_array. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Results of testing ZF against PHP 5.4.0RC1

2011-11-18 Thread Felipe Pena
2011/11/18 Pierre Joye : > same here, and for any other places in the ob_* APIs. Functions > returns false on error, cleaning something already cleaned or empty is > not an erro. > Same opinion here. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mai

Re: [PHP-DEV] pecl sqlite

2011-11-16 Thread Felipe Pena
t is to > use the one bundled in core, however for 5.4 and trunk, you can only > install it from pecl. > Maybe we could supersed it with ext/sqlite3? As it is in the core since > 5.3, so all supported branches has it.. It's not intentional, the text weren't updated. -- Regards, F

Re: [PHP-DEV] [RFC] new foo()->bar()

2011-11-06 Thread Felipe Pena
t; substantial changes. > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > Committed! -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Felipe Pena
eb > interface for that. > > -- > Ferenc Kovács > @Tyr43l - http://tyrael.hu > Nice work with this Jenkins stuff! The system seems pretty useful. I like the idea to have a mailing list for build result notification, as well as send mail to the build breaker. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] php 5.4 next iteration

2011-10-19 Thread Felipe Pena
: https://wiki.php.net/todo/undoc54 > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > (408)454-6900 ext. 227 > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > W

Re: [PHP-DEV] Ternary operator performance improvements

2011-10-17 Thread Felipe Pena
eliminated. There is however a slowdown in some >> of the cases, but overall there is no completely unexpected performance hit >> as >> it is the case currently. >> >> What do you think ? Is there any objection ? >> >> Best regards, >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > +1 from me too. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC] new foo()->bar()

2011-10-16 Thread Felipe Pena
Hi, 2011/10/7 Ferenc Kovacs : > On Tue, Nov 30, 2010 at 9:57 AM, Michael Wallner wrote: >> On 11/26/2010 08:36 PM, Felipe Pena wrote: >>> >>> Hi all, >> >> ... >>> >>> Other examples which describes the feature at >>> http:

Re: [PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is provided in run-tests.php

2011-09-24 Thread Felipe Pena
' as well: > $ cd ext/ > $ ../run-tests.php zlib > > Please, review this patch and, if there's no objections, I will > prepare 5.4 and 5.3 versions too. > > -- > Regards, > Shein Alexey > +1 I have no tried the patch, but the additions sounds good to me. --

Re: [PHP-DEV] 答复: [PHP-DEV] full LFS support

2011-09-06 Thread Felipe Pena
t;> > If this gets fixed, will this be included into the 5.3 branch, or this >>> > can only be added with the next major version? >>> > >>> > Tyrael >>> > >>> > >>> > -- >>> > PHP Internals - PHP Runtime Devel

Re: [PHP-DEV] New run-tests.php feature

2011-09-01 Thread Felipe Pena
> >> Being able to run the tests for two directories in parallel however.. >> that would be awesome. > > I reckon Felipe had a patch for this back in the early 5.3 development > days, Felipe? > > > > -- > regards, > > Kalle Sommer Nielsen > ka...@php.net

Re: [PHP-DEV] [Bug #55311] Static methods invoke __call when called from within class

2011-07-29 Thread Felipe Pena
Hi, 2011/7/29 Laruence : > Hi: >  hmm, this make sense, >  thanks for your explaining. > Actually this behavior change was introduced in 5.3.3 [1] and reverted in 5.3.4. I.e. the BC just happens for 5.3.3 version. [1] - https://bugs.php.net/bug.php?id=51176 -- Regards, Felipe

Re: [PHP-DEV] new gcov.php.net machine is up

2011-07-25 Thread Felipe Pena
oday, a couple the next day, >>> etc., is within my abilities (including making sure no regressions are >>> introduced, of course). >> >> That's fine if it is done carefully. Note that the code needs to compile >> on many different platforms, on many d

Re: [PHP-DEV] E_STRICT in production

2011-07-23 Thread Felipe Pena
2011/7/23 Pierre Joye : > hi Stas, > > The idea of E_STRICT when we introduced it was to help developers. So > I tend to think that we should not enable it in php.ini-production. > Agreed. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To uns

Re: [PHP-DEV] new gcov.php.net machine is up

2011-07-23 Thread Felipe Pena
s, > and so on. > > Thanks to Nexcess for offering a new machine to replace the old one. > > Nuno > Nice! I see the mail now works too. :) Thanks Nuno++ -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] is gcov.php.net still useful?

2011-07-18 Thread Felipe Pena
tc. reports. > > BTW parameters report needs to be updated - it doesn't know about new 'p' > parameter. > It already was updated, but wasn't synced with svn. And I used to read the test failures and valgrind logs on gcov as well. -- Regards, Felipe Pena --

Re: [PHP-DEV] Re: $arr = array('Hello', 'world'); $arr();

2011-07-14 Thread Felipe Pena
2011/7/14 Rune Kaagaard : > Will this work: > >    array('foo', 'bar')('arg1', 'arg2') > > ? > No, and it isn't supposed to either. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] sockets broken in 5.4 on Mac OS X

2011-07-10 Thread Felipe Pena
as no member named ‘ifr_ifindex’ > > Redoing buildconf/configure didn't help. Any ideas? There's a report about this: - https://bugs.php.net/bug.php?id=55111 -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Make primitive type names reserved words (Was: Re: [PHP-DEV] [RFC] 5.4 features for vote (long))

2011-07-10 Thread Felipe Pena
Hi, 2011/7/10 Lars Strojny : > Hi Felipe, > > Am 11.07.11 00:41 schrieb "Felipe Pena" unter : > >>I'm against this patch, because we will just add more inconsistency. >>Allow reserved words in method name, OK. But what about class >>name/namespace nam

Re: [PHP-DEV] Make primitive type names reserved words (Was: Re: [PHP-DEV] [RFC] 5.4 features for vote (long))

2011-07-10 Thread Felipe Pena
identify a method name 'include' as T_INCLUDE. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Make primitive type names reserved words (Was: Re: [PHP-DEV] [RFC] 5.4 features for vote (long))

2011-07-10 Thread Felipe Pena
rely on CG(active_class_entry) data. I'm against this patch, because we will just add more inconsistency. Allow reserved words in method name, OK. But what about class name/namespace name etc? And in the begin of thread the topic was type name as class name, nothing to do with methods. -- Regards,

Re: [PHP-DEV] [RFC] -W option for CLI "strict mode"

2011-07-05 Thread Felipe Pena
, but I know we already have used -w in PHP to output source with stripped comments and whitespaces. However I guess it's more useful to have something like Perl does with -W. -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Object oriented session handlers

2011-07-03 Thread Felipe Pena
is lead to following behavior: $x = new SessionHandler $x->open(1,2,3,4); // param is not used, and no param check at all It's missing void param check for the close method as well. Thank you for helping us make PHP better. :) -- Regards, Felipe Pena -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Compilation warning on offsetof in 5.4 and trunk

2011-07-02 Thread Felipe Pena
f))) - ((char *) ((void *)0 > > which is defined at the end of main/php.h. > > Two questions: > 1- is this possible to change Zend/zend_operators.h to use the old > macros ? (short term solution) I've removed this offsetof definition introduced in r311662, it seems have be

Re: [PHP-DEV] Re: [RFC] Improved parser error message

2011-06-23 Thread Felipe Pena
cted 'foo' (T_STRING), expecting '{' in Command line code on line 1 As can be noticed, I added the actual scanned string in the "unexpected" part. This might be useful for finding really which makes the parser error. (It was a bit tricky though :D) Any thoughts? h

Re: [PHP-DEV] [RFC] 5.4 features for vote (long)

2011-06-21 Thread Felipe Pena
2011/6/21 Etienne Kneuss : > Hello, > > On Tue, Jun 21, 2011 at 05:17, Rasmus Lerdorf wrote: >> On 06/20/2011 08:09 PM, Felipe Pena wrote: >> >>> I'm ok with this, I just think it's ugly to repeat the token name in >>> the definition in

Re: [PHP-DEV] [RFC] 5.4 features for vote (long)

2011-06-20 Thread Felipe Pena
2011/6/20 Derick Rethans > > On Mon, 20 Jun 2011, Felipe Pena wrote: > > > 2011/6/20 Etienne Kneuss > > > > > > I'd love to see the proposal from Felipe about the improved parse > > > errors in that list. I believe that the patch was ready or almos

Re: [PHP-DEV] [RFC] 5.4 features for vote (long)

2011-06-20 Thread Felipe Pena
nd has good chance for community support, please tell. > > I'd love to see the proposal from Felipe about the improved parse > errors in that list. I believe that the patch was ready or almost > ready? I can't find the RFC though, but maybe the RFC never existed... > > Best, > https://wiki.php.net/rfc/improved-parser-error-message -- Regards, Felipe Pena

Re: [PHP-DEV] Negative string offsets

2011-06-20 Thread Felipe Pena
] = '0'; > $str[-4] = "4"; > > will result in "H4ll0" > > Would be glad to see this in 5.4 > > Robert > I like this one, +1. -- Regards, Felipe Pena

Re: [PHP-DEV] Re: $arr = array('Hello', 'world'); $arr();

2011-06-08 Thread Felipe Pena
2011/6/8 Christian Kaps > On Wed, 8 Jun 2011 08:57:48 -0300, Felipe Pena wrote: > >> Hi, >> >> 2011/6/8 Christian Kaps >> >> Hi, >>> >>> >>> what happens if I use this code. >>> >>> class Foo { >>> >&

Re: [PHP-DEV] Re: $arr = array('Hello', 'world'); $arr();

2011-06-08 Thread Felipe Pena
$this->bar = array($this, 'baz'); > $this->bar(); > } > > public function bar() { > echo 'bar'; > } > > public function baz() { > echo 'baz'; > } > } > > new Foo(); > > What is the output of this snippet? > > Are there the same rules as for closures? > > Christian > > Yes, the same rules. -- Regards, Felipe Pena

Re: [PHP-DEV] Inline constructing/cloning and inline foreach listing

2011-06-07 Thread Felipe Pena
constructing (which I think has already previously been > discussed), but also cloning, e.g: > > // Inline constructing: > $car = (new CarFactory())->makeCar(); > I've already proposed such feature: https://wiki.php.net/rfc/instance-method-call Thread: http://markmail.org/thread/4rr3w52k5hfxi4qs -- Regards, Felipe Pena

Re: [PHP-DEV] bug #39863 in trunk/5.4

2011-06-06 Thread Felipe Pena
l with filenames. > > Ok, I've committed in 5.4 and trunk the argument parser part. Now I need to fix some tests and try to found other places needing for related checks. Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] $arr = array('Hello', 'world'); $arr();

2011-06-06 Thread Felipe Pena
iki for the record. All: Committed in 5.4 and trunk now. Thanks for the comments, folks! :) -- Regards, Felipe Pena

Re: [PHP-DEV] $arr = array('Hello', 'world'); $arr();

2011-06-05 Thread Felipe Pena
ch >> stuff. >> > > What about call_user_func() implementation? It must be doing pretty much > the same thing. > > 1. We do not use zend_fcall_info stuff in the VM (which zend_is_callable works in) 2. We have to use zend_do_fcall_common_helper instead of zend_call_function() in the VM -- Regards, Felipe Pena

Re: [PHP-DEV] $arr = array('Hello', 'world'); $arr();

2011-06-05 Thread Felipe Pena
o other place doing such stuff. -- Regards, Felipe Pena

Re: [PHP-DEV] $arr = array('Hello', 'world'); $arr();

2011-06-05 Thread Felipe Pena
Hi, 2011/6/5 Zeev Suraski > > -Original Message- > > class Hello { > >public function world($x) { > > echo "Hello, $x\n"; return $this; > >} > > } > > > > $f = array(new Hello, 'foo'); > > $f(); > > Am I the only one who doesn't understand what this one is supposed to do..?

Re: [PHP-DEV] bug #39863 in trunk/5.4

2011-06-05 Thread Felipe Pena
ot;);' >> >> Warning: fopen() expects parameter 1 to be valid path, string given in >> Command line code on line 1 >> > > This should be applied not only to fopen but to any function that does > anything with filenames (and include/require/etc. also, I guess)

Re: [PHP-DEV] RFC: Zend Signal Handling

2011-06-05 Thread Felipe Pena
Fixed crash in fastcgi due startup order... SIGG() were being used before tsrm_startup(). 2011/6/4 Felipe Pena > Fixed invalid sigaction() call passing NSIG as signal number. > > - for (signo = 1; signo <= NSIG; ++signo) { > + for (signo = 1; signo < NSIG; ++signo) { > &

Re: [PHP-DEV] $arr = array('Hello', 'world'); $arr();

2011-06-05 Thread Felipe Pena
, the array one can help on this just like the call_user_func() approach with arrays. $callback) { if (is_callable($callback)) { $callback($k); } } Output: Hello, 0 Hello, 1 Hello, 2 -- Regards, Felipe Pena

[PHP-DEV] $arr = array('Hello', 'world'); $arr();

2011-06-05 Thread Felipe Pena
d string only. (just like our zend_is_callable() check and opcodes related to init call) Any thoughts? [1] - http://bugs.php.net/bug.php?id=47160 [2] - http://felipe.ath.cx/diff/fr47160.diff phpt: http://felipe.ath.cx/diff/fr47160.phpt -- Regards, Felipe Pena

Re: [PHP-DEV] bug #39863 in trunk/5.4

2011-06-05 Thread Felipe Pena
ath, string given in Command line code on line 1 Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/reflection/php_reflection.c trunk/ext/reflection/php_reflection.c

2011-06-05 Thread Felipe Pena
This method doesn't seem to be very useful without scalar types, so > reverting it too > > It is still useful for array | class/interface name. Or? > > This method was included by the type-hint patch... For array/class/interface we already have ->isArray() and ->getClass() met

Re: [PHP-DEV] RFC: Zend Signal Handling

2011-06-04 Thread Felipe Pena
l. > > On Fri, Jun 3, 2011 at 2:41 AM, Felipe Pena wrote: > > 2011/6/2 Felipe Pena > > > >> Hi, > >> > >> 2011/6/2 Michael Maclean > >> > >>> On 02/06/11 18:20, Gustavo Lopes wrote: > >>> > >&

Re: [PHP-DEV] RFC: Zend Signal Handling

2011-06-02 Thread Felipe Pena
2011/6/2 Felipe Pena > Hi, > > 2011/6/2 Michael Maclean > >> On 02/06/11 18:20, Gustavo Lopes wrote: >> >>> Em Thu, 02 Jun 2011 18:10:50 +0100, Ilia Alshanetsky >>> escreveu: >>> >>> Killing TSRMLS_FETCH is a noble goal, but let&#

Re: [PHP-DEV] RFC: Zend Signal Handling

2011-06-02 Thread Felipe Pena
trunk we have 4 SIGSEGVs with ext/pcntl tests: pcntl_alarm() [ext/pcntl/tests/pcntl_alarm.phpt] pcntl_signal() [ext/pcntl/tests/pcntl_signal.phpt] pcnt_signal_dispatch() [ext/pcntl/tests/pcntl_signal_dispatch.phpt] Closures as a signal handler [ext/pcntl/tests/signal_closure_handler.phpt] And 1 test hanging: ext/pcntl/tests/002.phpt -- Regards, Felipe Pena

Re: [PHP-DEV] Constructor object instance dereferentiation

2011-05-22 Thread Felipe Pena
often one-off use cases. > > No, such feature was not planned in the RFC, the patch doesn't change the grammar to allow it. -- Regards, Felipe Pena

[PHP-DEV] Re: [RFC] Improved parser error message

2011-05-17 Thread Felipe Pena
2011/5/16 Felipe Pena > Hi all, > As I have proposed previously in an old thread... What about we name all > the tokens to have an improved parser error message? (i.e. anymore > T_PAAMAYIM_NEKUDOTAYIM, T_DOLLAR_OPEN_CURLY_BRACES in the messages etc) > > [...] > > Oth

Re: [PHP-DEV] [RFC] Improved parser error message

2011-05-16 Thread Felipe Pena
ed > that they are getting meaningful error messages, but I think they can live > with that. :) > > Tyrael > There is no BC. The changes doesn't affects token_*() functions for example. $ sapi/cli/php -r 'var_dump(token_name(318));' string(6) "T_ECHO" I added such information to the wiki page. Thanks. :) -- Regards, Felipe Pena

[PHP-DEV] [RFC] Improved parser error message

2011-05-16 Thread Felipe Pena
echo ::a;' Patched: Parse error: syntax error, unexpected :: in Command line code on line 1 Current: Parse error: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in Command line code on line 1 Other examples and patch at: https://wiki.php.net/rfc/improved-parser-error-message Any thoughts? Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] SVN Account Request: eyalt

2010-12-05 Thread Felipe Pena
t; >> -- > >> PHP Internals - PHP Runtime Development Mailing List > >> To unsubscribe, visit: http://www.php.net/unsub.php > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Regards, Felipe Pena

Re: [PHP-DEV] [RFC] new foo()->bar()

2010-11-29 Thread Felipe Pena
2010/11/29 Felipe Pena > It also probably makes sense to add array deference chaining e.g. new >> Foo()[] (just for language consistency). >> >> > Hmm, looks good to me. :) > > I've updated the patch with the bracketed version to include the array dereferecing

Re: [PHP-DEV] [RFC] new foo()->bar()

2010-11-29 Thread Felipe Pena
e consistency). > > Hmm, looks good to me. :) Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] RFC: Making T_FUNCTION optional in method declarations

2010-11-28 Thread Felipe Pena
2010/11/28 Ross Masters > From what I understand T_FUNCTION would be optional, rather than removed > altogether, is this the case? This would allow those who want to use it the > option of using it and would not break existing code. > Yes, exaclty... -- Regards, Felipe Pena

Re: [PHP-DEV] RFC: Making T_FUNCTION optional in method declarations

2010-11-27 Thread Felipe Pena
s.de/~johannes/php/zend_optional_t_function.diff > > +1 -- Regards, Felipe Pena

Re: [PHP-DEV] [RFC] new foo()->bar()

2010-11-27 Thread Felipe Pena
Hi, 2010/11/26 Felipe Pena > 2010/11/26 Johannes Schlüter > > On Fri, 2010-11-26 at 17:36 -0200, Felipe Pena wrote: >> > var_dump(new foo()->bar()->x); // string(3) "PHP" >> >> It has some readability issues. One might assume it is >> >

Re: [PHP-DEV] [RFC] new foo()->bar()

2010-11-26 Thread Felipe Pena
2010/11/26 Johannes Schlüter > On Fri, 2010-11-26 at 17:36 -0200, Felipe Pena wrote: > > var_dump(new foo()->bar()->x); // string(3) "PHP" > > It has some readability issues. One might assume it is > >new (foo()->bar()->x) > > not > &g

[PHP-DEV] [RFC] new foo()->bar()

2010-11-26 Thread Felipe Pena
.php.net/rfc/instance-method-call Thoughts? -- Regards, Felipe Pena

[PHP-DEV] Hold off 5.4

2010-11-22 Thread Felipe Pena
approved. Thanks. -- Regards, Felipe Pena

[PHP-DEV] [RFC] Release Process

2010-11-22 Thread Felipe Pena
breaks in bugs fix releases * feature(s) preview release [1] http://wiki.php.net/rfc/releaseprocess -- Regards, Felipe Pena

Re: [PHP-DEV] break/continue $var

2010-11-21 Thread Felipe Pena
2010/11/18 Dmitry Stogov > Hi, > Previously we decided to remove "break/continue $var" syntax. > I even implemented it in PHP6 brunch, however it wasn't backported into > trunk. Could I do it? > > +1 to removing it. -- Regards, Felipe Pena

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Felipe Pena
, we need contributions... making patches... testing fixes... reviewing fixes... As it's said in the bugsweb... "Help us make PHP better." :) -- Regards, Felipe Pena

Re: [PHP-DEV] [PATCH] fix extract w.r.t GLOBALS again

2010-11-19 Thread Felipe Pena
;foo" => "bar"); > +var_dump(extract(array("GLOBALS" => $splat, EXTR_OVERWRITE))); > + > +unset ($splat); > + > +debug_zval_dump($GLOBALS["str"]); > + > +echo "\nDone"; > +?> > + > +--EXPECTF-- > +string(4) "John" refcount(2) > +int(0) > +string(4) "John" refcount(2) > + > +Done > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > I committed your fix in the 5.2, 5.3 and trunk. Thanks for the patch! -- Regards, Felipe Pena

Re: [PHP-DEV] Restructuring NEWS?

2010-11-19 Thread Felipe Pena
ee that change but yeah something like that. Aybody volunteers > to go through the 5.3 NEWS? :-) > > I groupped the the 5.3.4RC1 entries: http://dpaste.com/277482/plain/ Is it okay to commit? :) -- Regards, Felipe Pena

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_functions.h main/php_streams.h main/streams/memory.c main/streams/streams.c

2010-11-15 Thread Felipe Pena
ash() which are defined in zend_builtin_functions.c in > > debug mode only or did I miss something here? > > It's only in the debug build. In any case, it would be indeed better among > leak() and crash(). The attached patch moves it there, but it will have to > be someone else commiting it. > Done. -- Regards, Felipe Pena

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Restructuring the QA team

2010-11-14 Thread Felipe Pena
re active in the developement, and others became inactive... and we don't updated the credits list. What about an update in the credits list (especially in the QA team)? How will be decided? I guess many people deserve credits (e.g. Dmitry, Pierre, etc), and this practice doesn't happens since many years. -- Regards, Felipe Pena

Re: [PHP-DEV] BC break in 5.3.2 -> 5.3.3 with "parent::" and __call/__callStatic

2010-11-02 Thread Felipe Pena
gt; assumptions that my design is good and that I don't know anything about the > parent class except there is a getFoo() method implemented somehow. > > My wish is that you restore the 5.3.2 behaviour, which sounds very > reasonable, and maybe introduce another way when you actually want to get > rid of the context, something like static:: > > The change has been reverted in SVN. Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] [PATCH] Delegate type hint/checks to alternative locations (Re: [PHP-DEV] back to 5.4 alpha)

2010-11-01 Thread Felipe Pena
; variables. > > I've just committed that patch, the implements the 3 first elements from > this list. I've also updated my little extension to behave in the same > way as it did with the previous patch: > There is a BC in the changes, I don't know if it is expected for the next version, at least it is very strange. -- Regards, Felipe Pena

Re: [PHP-DEV] rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2010-11-01 Thread Felipe Pena
token, to have a legible error message, without the T_ being shown. For example, we could use in the Bison grammar file: %token T_PAAMAYIM_NEKUDOTAYIM "::" So that the error message become: $ sapi/cli/php -r '::' Parse error: syntax error, unexpected :: in Command line code on line 1 Instead of the known "unexpected T_PAAMAYIM_NEKUDOTAYIM" one. -- Regards, Felipe Pena

Re: [PHP-DEV] Re: Bug #47643 - array_diff slowdown

2010-11-01 Thread Felipe Pena
on IRC had disagreed with me > so I want more opinions before I do anything. > > The slowdown on array_diff has been fixed right now. Thanks. -- Regards, Felipe Pena

Re: [PHP-DEV] [RFC] Return type-hint

2010-07-29 Thread Felipe Pena
Hi 2010/7/29 Ferenc Kovacs > >> Hi, I would love this feature. > >> But I have some concerns. > >> AFAIK you can declare classes with the name int ,scalar, etc. so > >> hinting anything else than class names can be ambiguous. > >> Or we have to set these keywords as reserved, so nobody could dec

[PHP-DEV] [RFC] Return type-hint

2010-07-28 Thread Felipe Pena
quot; pseudo-types. http://wiki.php.net/rfc/returntypehint Thoughts? -- Regards, Felipe Pena

Re: [PHP-DEV] [PATCH] string_offset access optimization

2010-07-15 Thread Felipe Pena
; I think it's not a problem at all. > "b" makes sense because "abs"[1] -> "b" and "b"[0] -> "b". > > I'm going to commit the patch in case of no objections. > > Thanks. Dmitry. > > The patch looks good, I did some tests, not found anything strange. Good simplyfication! :) -- Regards, Felipe Pena

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_2/Zend/tests/bug51421.phpt branches/PHP_5_2/Zend/zend_compile.c branches/PHP_5_3/Zend/tests/bug51421.phpt branches/PHP_5_3/Zend/zend_compile

2010-06-28 Thread Felipe Pena
2010/6/28 Johannes Schlüter > Hi, > > On Sat, 2010-06-26 at 22:05 +0000, Felipe Pena wrote: > > felipe Sat, 26 Jun 2010 22:05:13 + > > > > Revision: http://svn.php.net/viewvc?view=revision&revision=300770 > > >

Re: [PHP-DEV] [RFC] Array Dereferencing

2010-06-07 Thread Felipe Pena
P I have committed the patch and added new tests. Thanks guys for the feedback. -- Regards, Felipe Pena

  1   2   3   >