Re: [PHP-DEV] PHP socket ethernet support - step 2

On Tue, 4 Mar 2025 at 22:34, Tim Düsterhus wrote: > Hi > > On 3/4/25 23:18, Gina P. Banyard wrote: > > Those two classes predate the Namespaces in bundled PHP extensions [1] > RFC, I do think adding a namespace is better. > > And we could also move the two classes into the new namespace and add >

Re: [PHP-DEV] PHP socket ethernet support - step 2

On Mon, 3 Mar 2025 at 21:21, Jakub Zelenka wrote: > Hi, > > >> I am working on the second pass of this feature and write here because of >> the legitimate concern regarding new classes to add. >> >> PR here >> > > For those that want to quickly see the

[PHP-DEV] PHP socket ethernet support - step 2

Hi, I am working on the second pass of this feature and write here because of the legitimate concern regarding new classes to add. PR here I agree also on adding a namespace on top (Sockets ?) and changing the class names. Note that after that I plan

Re: [PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC

Ok fair enough, will revert it. Cheers. On Wed, 29 Jan 2025 at 12:04, Jakub Zelenka wrote: > > > > On Wed, Jan 29, 2025 at 4:22 AM David CARLIER wrote: >> >> Hi, >> >> Working on this PR #17440, I wanted to ask if the BC from these two calls >> wer

[PHP-DEV] ext/sockets: socket_getpeername/socket_getsockname BC

Hi, Working on this PR #17440 , I wanted to ask if the BC from these two calls were ok because : Before function socket_getsockname(Socket $socket, &$address, *&$port = null*): bool {} After function socket_getsockname(Socket $socket, &$address, *?int

Re: [PHP-DEV] [RFC] Change Directory class to behave like an opaque object

Seems right thing to do. I saw some usage like final class Dir extends Directory { } also did not see much in *new* codes Directory being extended so 8.5 sure. Cheers. On Sat, 14 Sept 2024 at 16:36, Gina P. Banyard wrote: > Hello internals, > > I came across the Directory class while doing s

Re: [PHP-DEV] strrchr with needle with multiple characters

Hi, On Mon, 2 Sept 2024 at 12:20, Vincent Langlet wrote: > I was today old when I discovered the big difference between strchr and > strrchr in the way they handle needle with multiple characters. > > It's explained in the doc > https://www.php.net/manual/en/function.strrchr.php > - If needle co

Re: [PHP-DEV] ext/gd adding imagecompare

Hi On Tue, 9 Jul 2024 at 19:16, Tim Düsterhus wrote: > Hi > > On 7/9/24 19:53, David CARLIER wrote: > > Agreed, I ll likely just commit as is sometime this week. > > I hereby formally claim that this is not a simple self-contained > feature. It does require an RFC. &g

Re: [PHP-DEV] ext/gd adding imagecompare

On Tue, 9 Jul 2024 at 18:31, Saki Takamachi wrote: > Hi David, > > It seems to be the opposite regarding his proposition gdImageCompare(im1, > im2) & GD_CMP_IMAGE. Then yes you are right, we are losing the specifics. > If you want to figure out how the image 1 and image 2 differ, you need to > us

Re: [PHP-DEV] ext/gd adding imagecompare

Hi, On Tue, 9 Jul 2024 at 17:59, Kamil Tekiela wrote: > Boolean is a much more confusing value here. A bit mask is ok, but I would > prefer a better solution. Maybe a simple value object? > That could be an option too sure.

Re: [PHP-DEV] ext/gd adding imagecompare

Hi Saki. On Tue, 9 Jul 2024 at 17:49, Saki Takamachi wrote: > Hi David, > > > Hi, > > > > I plan to add imagecompare to the gd extension. No problem so far > however a little discussion of the returned value > > > > https://github.com/php/php-src/pull/14877#issuecomment-2217686123 > > > > I pers

[PHP-DEV] ext/gd adding imagecompare

Hi, I plan to add imagecompare to the gd extension . No problem so far however a little discussion of the returned value https://github.com/php/php-src/pull/14877#issuecomment-2217686123 I personally see a value of a bitmask rather than just boolean whi

[PHP-DEV] pcntl_exec update proposal

Hi, Through this existing PR , I wanted to know how would appeal to you adding some access restriction upon this existing call, using the open basedir check. So if the sysadmin wants the php user having no business calling `/bin` commands for examples wou

Re: [PHP-DEV] Bumping minimum PostgreSQL version to 10.0

Hi, I m all for the changes this update should not preclude any 10.0 client to connect to a 9.x server. cheers.

[PHP-DEV] gd heif support

Hi, I m trying to address an old ticket regarding HEIF support for gd. Here the PR One of the last bit concerns the imagecreatefromstring support part where I would need a custom stream handler for this format. Would you mind adding a dependency like it

Re: [PHP-DEV] ext/pgsql: pg_put_line deprecation proposal

Hi Matteo, On Mon, 20 May 2024 at 14:08, Matteo Beccati wrote: > Hi, > > Il 20/05/2024 14:03, David CARLIER ha scritto: > > I would like to know if it would be fine to deprecate pg_put_line > > <http://pg_put_line>. > > > > Reasoning is PQPutLine is part

[PHP-DEV] ext/pgsql: pg_put_line deprecation proposal

I would like to know if it would be fine to deprecate pg_put_line. Reasoning is PQPutLine is part of the obsolete list of calls for COPY purpose since the PostgreSQL protocol 3.0 version (supported since postgresql 7.4 relea

Re: [PHP-DEV] Requiring GPG Commit Signing

No problem with this, I apply this since couple of days. Cheers. On Tue, 2 Apr 2024 at 15:37, Jakub Zelenka wrote: > On Tue, Apr 2, 2024 at 3:36 PM Jakub Zelenka wrote: > >> On Tue, Apr 2, 2024 at 3:17 PM Derick Rethans wrote: >> >>> Hi, >>> >>> What do y'all think about requiring GPG signed

Re: [PHP-DEV][RFC] grapheme cluster for str_split, grapheme_str_split function

I second this, I think it is a good addition which makes a lot of sense. Cheers. On Mon, 25 Mar 2024 at 20:36, Ayesh Karunaratne wrote: > > > > 2024年3月9日(土) 15:26 youkidearitai : > > > > > > Hello, Internals > > > > > > I created an wiki for `grapheme_str_split` function. > > > Please see: > >

Re: [PHP-DEV] Filesystem path APIs

On Fri, 8 Dec 2023 at 16:10, Niels Dossche wrote: > Hi David > > On 08/12/2023 10:08, David CARLIER wrote: > > I think these would be great additions to PHP as working with paths > and files is a core part of any programming language. > > > > > > Seems

Re: [PHP-DEV] Filesystem path APIs

Hi Niels, On Wed, 6 Dec 2023 at 19:20, Niels Dossche wrote: > Hi internals > > I'd like to start a pre-RFC discussion about filesystem path APIs in PHP. > The reason I bring this up is because of this recent feature request: > https://github.com/php/php-src/issues/11258 > > The feature request i

Re: [PHP-DEV] How to deal with bugs in vendored libraries?

Hi, On Thu, 9 Feb 2023 at 12:38, Rowan Tommins wrote: > On Thu, 9 Feb 2023 at 10:19, Max Kellermann wrote: > > > Hi, > > > > > Firstly, let's try to keep this discussion civil, and assume good faith on > both sides. > > > That a kind of constant with you, Max, through your PR too. If you could

[PHP-DEV] VCS Account Request: devnexen

phpdoc php-src -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Early feedback on encrypted session PR

Thanks all for the early feedback. So it is an attempt to mitigate tampering attacks basically on session stored on filesystems. So it appears to be a subset of session usage overall indeed but doing so in a native manner is what drove the PR. On Wed, 18 May 2022 at 18:43, Christoph M. Becker wr

[PHP-DEV] Early feedback on encrypted session PR

Hi, I wanted a more general but early feedback on the idea itself https://github.com/php/php-src/pull/3759 which is encrypting/decrypting the session on the fly with openssl (assuming as an improvement it would need a more complex key than the session id to make it more useful and being configura

[PHP-DEV] RFC: operating system specific features

Hi, I wanted first to know if php source code can welcome oses specific features or should it remain as separated php modules ? For instance awhile ago I implemented a wrapper around OpenBSD's pledge for suhosin (php 5.x series) here https://github.com/sektioneins/suhosin/blob/master/pledge.c T