Re: [PHP-DEV] [PATCH] Clean up struct initalizations

On Tue, Nov 27, 2007 at 10:30:35AM -0800, Stanislav Malyshev ([EMAIL PROTECTED]) wrote: > No, the compiler makes sure I got them all, and it does it with {0}. I can tell where this is going. I'll back away now. xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com =

Re: [PHP-DEV] [PATCH] Clean up struct initalizations

> Not sure I see how it helps - suppose we add a field into structure, > does it mean one has to go over all the code that ever mentioned this > structure and add zeroes? How helpful is that? Makes sure you got them all, doesn't it? xoa -- Andy Lester => [EMAIL PROTECTED] =&

Re: [PHP-DEV] [PATCH] Clean up struct initalizations

;s just so much that's slop that I'm trying to get the low-hanging fruit early. xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] Clean up struct initalizations

mated magic where possible. If this is not useful to the PHP core team, then that's fine, I'll walk away. Let me know either way. xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] [PATCH] Clean up struct initalizations

t the compiler doesn't squawk about it at high levels of warnings. Then when you do have real squawk-worthy problems, they don't get lost in the noise of meaningless warnings. -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance -- PHP Internals - PHP Runt

Re: [PHP-DEV] [PATCH] Clean up struct initalizations

C standard mandate filling up uninitialized fields with 0? Yes. My patch is for human benefit, not the compiler's. -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] [PATCH] Clean up struct initalizations

I've been working on making PHP build under more stringent error checking, specifically -Wextra under GCC. This patch cleans up dozens of struct initializations that are valid C, but could hide future problems. xoxo, Andy -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com =>

[PHP-DEV] [PATCH] consting ext/standard/dl.c

Here's dl.c Is the Zend directory doable as well, or is that off-limits for some reason or another? That's really the place I should be working on first, because it's the lowest level. xoxo, Andy -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance

[PHP-DEV] [PATCH] Constifying ext/standard/md5.c

Here's some patchy goodness to constify the input args to the md5 functions. xoxo, Andy -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance Index: ext/standard/md5.c === --- ext/standard/md5.

Re: [PHP-DEV] Cleanup and maintenance of internal C code

ing up compiler warning levels, too? I was surprised to see that GCC doesn't default to running with - Wall in the Makefile. Just read through README.SUBMITTING-PATCH, so will be mailing stuff in, as with the bug in browscap.c I just stumbled across. xoa -- Andy Lester

[PHP-DEV] Cleanup and maintenance of internal C code

Hi, I'm Andy Lester, and I'm usually a Perl person. I've worked on the Perl 5 and Parrot internals over the past few years, working to clean up the C code. The other day I was poking through the C code behind PHP 5.2 and saw some places that I thought I could help clean