On Nov 27, 2007, at 9:57 AM, Ilia Alshanetsky wrote:
There is absolutely nothing wrong with trying to make the code more maintainable, in fact I think everyone, myself included welcome any work in that direction. But at the same time we need to keep in mind that compiler is not always right and often will generate meaningless warnings even when there is absolutely nothing wrong the code. Changes for the sake of making the compiler happy with - Winsane-warnings ;-) does not really help maintainability. In the case of {0} vs {NULL,0,0}, my opinion is that the former is far more readable and understandable.
I'm trying to look at the code with the eyes of a human, trying to use the compiler as my ally, not something to be circumvented. GCC has most of the features of a good lint, if we take advantage of it. Think of it as compiler-enforced coding standards. My goal has been to try to raise up the coding level of the code that I see, that I'm using in my day-to-day work. The more seat belts the better, and initializing structs is just one of them.
Adding consts and fixing signed/unsigned mismatches are on my list, too, but there's just so much that's slop that I'm trying to get the low-hanging fruit early.
xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
