Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Dmitry Stogov
On Mon, Sep 18, 2023 at 8:01 AM Pierre Joye wrote: > Great work! This is a massive jump for PHP. Thank you :) > > I don't have much concerns about the license etc as the ZE is already > under Zend the ZE license (never updated since Perforce acquired them, > tho'): > > https://github.com/php/php-

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-17 Thread Stephen Reay
> On 17 Sep 2023, at 18:28, Niels Dossche wrote: > > Hi Alexandru > > On 9/17/23 11:59, Alexandru Pătrănescu wrote: >> On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: >> >>> >>> We'll add a common abstract base class DOM\Document (name taken from the >>> DOM spec & Javascript world). >>> D

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Dmitry Stogov
Hi Ben, On Fri, Sep 15, 2023 at 6:50 PM Ben Ramsey wrote: > On 9/15/23 09:35, Derick Rethans wrote: > > > I understand that working on an RFC for such a complex issue is going to > > take time, but that also gives to opportunity to pair with somebody, > > who, while writing it, will also learn h

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Dmitry Stogov
Hi Derick, On Fri, Sep 15, 2023 at 5:35 PM Derick Rethans wrote: > I think this is great work. It looks like the new JIT-IR approach is > more suitable. I have however concerns with a few things here. > > This is a lot of new code, that very few other people understand in > great detail. > > I t

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Dmitry Stogov
On Fri, Sep 15, 2023 at 4:03 PM Juliette Reinders Folmer < php-internals_nos...@adviesenzo.nl> wrote: > If merged to `master`, will that automatically mean that the next > version of PHP will be PHP 9.0 ? > > If so, would that warrant a separate discussion ? (whether there should > still be a 8.4/

Re: [PHP-DEV] A new JIT engine for PHP-8.4/9

2023-09-17 Thread Pierre Joye
Hello :) Posting again, I just realized I used "reply" not "reply all" On Mon, Sep 11, 2023 at 4:29 PM Dmitry Stogov wrote: > > Hi internals, > > I'm glad to present a new JIT engine that is going to be used in the next > major PHP version. Now it's a real optimizing compiler with Intermediate >

Re: [PHP-DEV] RFC: Increasing the default BCrypt cost

2023-09-17 Thread Alexandru Pătrănescu
On Sun, Sep 10, 2023 at 7:06 PM Tim Düsterhus wrote: > Hi > > On 9/8/23 18:49, Alexandru Pătrănescu wrote: > > > > I think 12 looks reasonable. > > I've performed some tests myself on private hosted servers with > > newer hardware with good results for 12 around 0.1 seconds. > > wow, that is a 33

Re: [PHP-DEV] adding serialize_precision's value that uses mode2 and long double

2023-09-17 Thread Saki Takamachi
Sorry, please forget… I must have been very sleepy… Saki -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] adding serialize_precision's value that uses mode2 and long double

2023-09-17 Thread Saki Takamachi
Hi, internals. I had incorrect knowledge the `serialize_precision` until recently. I knew that setting this to `-1` would use a `long double`, but I didn't know that the number of digits would not be `17`. I've looked through RFC related to this. https://wiki.php.net/rfc/precise_float_value The

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-17 Thread Tim Düsterhus
Hi On 9/16/23 01:17, Niels Dossche wrote: […] Thank you for the fruitful discussion. This updated API is much better. When reading the updated RFC yesterday, I initially wanted to complain about the "The options argument" section still existing, but the $options argument nowhere to be seen.

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-17 Thread Niels Dossche
Hi Alexandru On 9/17/23 11:59, Alexandru Pătrănescu wrote: > On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: > >> >> We'll add a common abstract base class DOM\Document (name taken from the >> DOM spec & Javascript world). >> DOM\Document contains the properties and abstract methods common to b

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-17 Thread Alexandru Pătrănescu
On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: > > We'll add a common abstract base class DOM\Document (name taken from the > DOM spec & Javascript world). > DOM\Document contains the properties and abstract methods common to both > HTML and XML documents. > > Hi, Yes looks a lot better. Great