On Sat, Sep 16, 2023, 02:17 Niels Dossche <dossche.ni...@gmail.com> wrote:
> > We'll add a common abstract base class DOM\Document (name taken from the > DOM spec & Javascript world). > DOM\Document contains the properties and abstract methods common to both > HTML and XML documents. > > Hi, Yes looks a lot better. Great work overall! And thank you for taking on this effort. I would have a small suggestion: to make the abstract class an interface. This will allow even more flexibility on how things can be build further, suggesting composition over inheritance. In user land we cannot have interfaces with properties (yet) but in php internal interfaces we have example with interface UnitEnum that has name property, extendes by BackedEnum that adds value property. Thank you, Alex
