[PHP-DEV] Re: Potential RFC around PDO

2021-02-17 Thread Mark Randall
On 18/02/2021 03:37, Mark Randall wrote: Long ago, PHP had a similar feature called Magic Quotes. My apologies, I had only that top paragraph visible in my preview and responded to entirely the wrong part of your post :-( -- PHP Internals - PHP Runtime Development Mailing List To unsubscr

[PHP-DEV] Re: Potential RFC around PDO

2021-02-17 Thread Mark Randall
On 18/02/2021 00:57, Daniel Beardsley wrote: At iFixit we use a forked version of php with a small change to allow automatically html-escaping echoed strings: https://github.com/iFixit/php-src/commit/cb6eb5c35a07c843e5b357884186d77e3a1a2981 Long ago, PHP had a similar feature called Magic Quote

Re: [PHP-DEV] preg_replace(string, null) is allowed?

2021-02-17 Thread David Rodrigues
Thanks! There is a reason why it is not supported anymore? There is a difference in output or performance, maybe? Atenciosamente, David Rodrigues Em qua., 17 de fev. de 2021 às 17:37, Nikita Popov escreveu: > On Wed, Feb 17, 2021 at 9:28 PM David Rodrigues > wrote: > >> Hello! >> >> I am i

[PHP-DEV] Potential RFC around PDO

2021-02-17 Thread Daniel Beardsley
wiki username: danielbeardsley === Background I was told to introduce myself. I've been in software development for more than 20 years and have been working with php for 10 or so of that. I've only had a little contact with this group, but I've got at least one past pull merged on the php-src repo

Re: [PHP-DEV] preg_replace(string, null) is allowed?

2021-02-17 Thread Nikita Popov
On Wed, Feb 17, 2021 at 9:28 PM David Rodrigues wrote: > Hello! > > I am in doubt if passing null as the second argument to preg_replace() is > valid. Actually, it works as expected. > > https://3v4l.org/0TITS > > But doc only accepts array|string. > > I am asking for it because PhpStorm will not

[PHP-DEV] preg_replace(string, null) is allowed?

2021-02-17 Thread David Rodrigues
Hello! I am in doubt if passing null as the second argument to preg_replace() is valid. Actually, it works as expected. https://3v4l.org/0TITS But doc only accepts array|string. I am asking for it because PhpStorm will not accept it. So if it is valid, I will do a PR to PS stubs. Thanks! Ate

Re: [PHP-DEV] [VOTE] Enumerations

2021-02-17 Thread Ben Ramsey
> On Feb 17, 2021, at 12:08, Rowan Tommins wrote: > > On 17/02/2021 17:51, Ben Ramsey wrote: >>> On Feb 17, 2021, at 11:48, Chase Peeler wrote: >>> >>> If that were to not pass, though, it seems supporting enum cases as keys >>> would be worth exploring. Fully support allowing all objects as k

Re: [PHP-DEV] [VOTE] Enumerations

2021-02-17 Thread Rowan Tommins
On 17/02/2021 17:51, Ben Ramsey wrote: On Feb 17, 2021, at 11:48, Chase Peeler wrote: If that were to not pass, though, it seems supporting enum cases as keys would be worth exploring. Fully support allowing all objects as keys though. Others, please correct me if I’m wrong, but I believe ea

Re: [PHP-DEV] [VOTE] Enumerations

2021-02-17 Thread Ben Ramsey
> On Feb 17, 2021, at 11:48, Chase Peeler wrote: > > If that were to not pass, though, it seems supporting enum cases as keys > would be worth exploring. Fully support allowing all objects as keys though. Others, please correct me if I’m wrong, but I believe each enum case is already an objec

Re: [PHP-DEV] [VOTE] Enumerations

2021-02-17 Thread Chase Peeler
On Wed, Feb 17, 2021 at 12:41 PM Ben Ramsey wrote: > > On Feb 17, 2021, at 09:26, Chase Peeler wrote: > > > > On Wed, Feb 17, 2021 at 10:09 AM Rowan Tommins > > wrote: > > > >> On 17/02/2021 14:30, Larry Garfield wrote: > >>> The Enum RFC has been approved. > >> > >> > >> Thank you and Ilija so

Re: [PHP-DEV] [VOTE] Enumerations

2021-02-17 Thread Ben Ramsey
> On Feb 17, 2021, at 09:26, Chase Peeler wrote: > > On Wed, Feb 17, 2021 at 10:09 AM Rowan Tommins > wrote: > >> On 17/02/2021 14:30, Larry Garfield wrote: >>> The Enum RFC has been approved. >> >> >> Thank you and Ilija so much for putting in the effort to make such a >> carefully thought-t

Re: [PHP-DEV] Re: [VOTE] Enumerations

2021-02-17 Thread Chase Peeler
On Wed, Feb 17, 2021 at 10:09 AM Rowan Tommins wrote: > On 17/02/2021 14:30, Larry Garfield wrote: > > The Enum RFC has been approved. > > > Thank you and Ilija so much for putting in the effort to make such a > carefully thought-through proposal, and I'm really looking forward to > being able to

Re: [PHP-DEV] Re: [VOTE] Enumerations

2021-02-17 Thread Rowan Tommins
On 17/02/2021 14:30, Larry Garfield wrote: The Enum RFC has been approved. Thank you and Ilija so much for putting in the effort to make such a carefully thought-through proposal, and I'm really looking forward to being able to use it. I realise not everyone agrees with the approach, but a

Re: [PHP-DEV] Re: [VOTE] Enumerations

2021-02-17 Thread Pierre
Le 17/02/2021 à 15:30, Larry Garfield a écrit : The Enum vote has now closed. Final results: For: 44 Against: 7 Approval rate: 86% The Enum RFC has been approved. Ilija is still fixing up some bugs and edge cases in the code itself but it should be merged soon. Thank you to everyone for you

Re: [PHP-DEV] Re: [VOTE] Enumerations

2021-02-17 Thread Benjamin Morel
Congratulations 🎉 and thank you Larry and Ilija, this will be a great addition to PHP! — Benjamin On Wed, 17 Feb 2021 at 15:31, Larry Garfield wrote: > On Wed, Feb 3, 2021, at 11:28 AM, Larry Garfield wrote: > > The vote on the Enumerations RFC is hereby opened. It will run until > > 17 Februa

[PHP-DEV] Re: [VOTE] Enumerations

2021-02-17 Thread Larry Garfield
On Wed, Feb 3, 2021, at 11:28 AM, Larry Garfield wrote: > The vote on the Enumerations RFC is hereby opened. It will run until > 17 February 2021. > > https://wiki.php.net/rfc/enumerations > > Vote now, or forever hold your memory allocations. The Enum vote has now closed. Final results: Fo