Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed variables

2018-06-10 Thread Hoffman, Zachary Robert
On Sun, 2018-06-10 at 23:49 +0100, Rowan Collins wrote: > On 10/06/2018 19:41, Hoffman, Zachary Robert wrote: > > Deprecating compact() would hurt workflows where you use the same > > variable names > > several times in different contexts, even though they are only > > declared locally > > for the

[PHP-DEV] PHP7.1.19RC1 ready for testing

2018-06-10 Thread Joe Watkins
Morning all, PHP 7.1.19RC1 is ready for testing and can be downloaded from: https://downloads.php.net/~ab There is already one known problematic commit contained in this release which will be reverted before the final release, for reference it is: https://github.com/php/php-src/commit/d6e81f0bf

Re: [PHP-DEV] [VOTE] Fiber API

2018-06-10 Thread Levi Morrison
Replying to Joe's email because I didn't get the original. On Sun, Jun 10, 2018 at 1:09 PM Joe Watkins wrote: > > This is not ready for voting, please stop the vote. > > Bringing stuff to vote that is incomplete, where there is no clear > consensus, is dangerous. > > > On Sun, Jun 10, 2018 at 2:0

Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed variables

2018-06-10 Thread Rowan Collins
On 10/06/2018 19:41, Hoffman, Zachary Robert wrote: Deprecating compact() would hurt workflows where you use the same variable names several times in different contexts, even though they are only declared locally for the purposes of compact() itself. I am not convinced that building logic aroun

Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed variables

2018-06-10 Thread Hoffman, Zachary Robert
>The existence of anything that internally relies on `get_defined_vars()` is a >blocker for applying further optimisations to the engine (think stack frames), >which is probably why Dmitry suggested its removal. I did not know it was an optimization issue. I suppose I could substitute a userland

Re: [PHP-DEV] [VOTE] Fiber API

2018-06-10 Thread Joe Watkins
This is not ready for voting, please stop the vote. Bringing stuff to vote that is incomplete, where there is no clear consensus, is dangerous. On Sun, Jun 10, 2018 at 2:09 PM, Haitao Lv wrote: > Hello Internals, > > The RFC for fiber is now open for a vote. The RFC is available at > https://w

Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed variables

2018-06-10 Thread Marco Pivetta
The existence of anything that internally relies on `get_defined_vars()` is a blocker for applying further optimisations to the engine (think stack frames), which is probably why Dmitry suggested its removal. On Sun, 10 Jun 2018, 20:42 Hoffman, Zachary Robert, wrote: > >> > >> Hi Gabriel, > >> >

Re: [PHP-DEV] [VOTE] Make compact function reports undefined passed variables

2018-06-10 Thread Hoffman, Zachary Robert
>> >> Hi Gabriel, >> >>> compact(), extract(), parse_str() (with 1 argument) and >>> get_defined_vars() are bad functions, because they access local variables >>> indirectly. >>> >>> They might be considered to be removed in the next major PHP version, >>> despite of this fix. >>> >>> >>> Thanks. D

Re: [PHP-DEV] [VOTE] Fiber API

2018-06-10 Thread Niklas Keller
Hey Haitao, there doesn't seem to be any voting snipped on that page, so there's no actual vote yet. Also, the open issues section should usually be empty when the vote starts. The implementation in its current state is very limited and not really useful to real-world applications. Written code c

[PHP-DEV] [VOTE] Fiber API

2018-06-10 Thread Haitao Lv
Hello Internals, The RFC for fiber is now open for a vote. The RFC is available at https://wiki.php.net/rfc/fiber. Voting will be open until June 22th, 2018. Thank you. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] A replacement for the Serializable interface

2018-06-10 Thread Nicolas Grekas
Please allow me to up vote for this proposal. I'm working on some serialization logic these days, and `Serializable` is totally broken: it breaks internal references in serialized data structures, and breaks custom serializers (e.g. igbinaryà from inspecting nested structures. The proposal here wou