Re: [PHP-DEV] Wiki karma for mixed type RFC

2017-07-18 Thread Joe Watkins
Granted. Thanks. On Tue, Jul 11, 2017 at 2:10 AM, Michael Moravec wrote: > Hello everyone, > > I'd like to request a Wiki karma to be able to create an RFC for adding the > mixed type. > There is already a PR for this: https://github.com/php/php-src/pull/2603 > Wiki username in question is "maj

[PHP-DEV] UGLY Benchmark Results for PHP Master 2017-07-17

2017-07-18 Thread lp_benchmark_robot
Results for project PHP master, build date 2017-07-17 19:21:54-07:00 commit: a39fd99 previous commit:09d3b73 revision date: 2017-07-18 00:35:01+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] Re: [VOTE] Unary null coalescing operator

2017-07-18 Thread Andrea Faulds
Andrea Faulds wrote: Hi everyone, There seems no reason not to put this to a vote, so I have: https://wiki.php.net/rfc/unary_null_coalescing_operator Voting starts immediately and ends in 7 days' time, so 2017-07-18. Thanks! The RFC was declined, 12 to 4. Thanks for voting. -- Andrea Faul

[PHP-DEV] Re: Minimum MySQL version

2017-07-18 Thread Jan Ehrhardt
Nikita Popov in php.internals (Tue, 18 Jul 2017 21:37:07 +0200): >I just found out that some of the PDO code contains MySQL version checks >going all the way back to MySQL 3.22.30, which has been released in 2000. > >What is the minimum MySQL version we support? can I drop checks for MySQL >3.x and

Re: [PHP-DEV] gcov cron/tags.inc

2017-07-18 Thread Nuno Lopes
Done; thanks for the ping! cc'ing Nuno, our GCOV guy! 2017-07-18 21:32 GMT+02:00 Sara Golemon : Looks like I don't have karma to add PHP_7_2 to gcov runs, could someone do that for me? Thanks. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Maili

[PHP-DEV] Re: Minimum MySQL version

2017-07-18 Thread Andreas Treichel
On 18.7.2017 21:37, Nikita Popov wrote: What is the minimum MySQL version we support? can I drop checks for MySQL 3.x and 4.x? The "oldoldstable" Debian Wheezy from 2013 supports MySQL 5.5. The unsupported Debian Lenny has MySQL 5.0 since 2009. In my opinion the next release of PHP no longer

Re: [PHP-DEV] [RFC] [Voting] Class Naming

2017-07-18 Thread Nikita Popov
On Sat, Jul 1, 2017 at 7:42 PM, Fleshgrinder wrote: > https://wiki.php.net/rfc/class-naming > > Voting starts now and will be open for two weeks (July 15). > As it's already July 18, I've closed the vote. The RFC has been accepted (17:9) and the option "PascalCase except Acronyms" received more

Re: [PHP-DEV] gcov cron/tags.inc

2017-07-18 Thread Kalle Sommer Nielsen
cc'ing Nuno, our GCOV guy! 2017-07-18 21:32 GMT+02:00 Sara Golemon : > Looks like I don't have karma to add PHP_7_2 to gcov runs, could > someone do that for me? Thanks. -- regards, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, vis

Re: [PHP-DEV] Minimum MySQL version

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 21:37 schrieb Nikita Popov: I just found out that some of the PDO code contains MySQL version checks going all the way back to MySQL 3.22.30, which has been released in 2000. What is the minimum MySQL version we support? can I drop checks for MySQL 3.x and 4.x? wouldn't it be

[PHP-DEV] Minimum MySQL version

2017-07-18 Thread Nikita Popov
Hi, I just found out that some of the PDO code contains MySQL version checks going all the way back to MySQL 3.22.30, which has been released in 2000. What is the minimum MySQL version we support? can I drop checks for MySQL 3.x and 4.x? Nikita

[PHP-DEV] gcov cron/tags.inc

2017-07-18 Thread Sara Golemon
Looks like I don't have karma to add PHP_7_2 to gcov runs, could someone do that for me? Thanks. -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Michael Morris
On Tue, Jul 18, 2017 at 3:11 PM, li...@rhsoft.net wrote: > > > Am 18.07.2017 um 21:02 schrieb Michael Morris: > >> >> >> On Tue, Jul 18, 2017 at 2:56 PM, li...@rhsoft.net > li...@rhsoft.net> mailto:li...@rhsoft.net>> wrote: >> >> >> >> Am 18.07.2017 um 20:39 schrieb Michael Morris: >> >>

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 21:02 schrieb Michael Morris: On Tue, Jul 18, 2017 at 2:56 PM, li...@rhsoft.net mailto:li...@rhsoft.net>> wrote: Am 18.07.2017 um 20:39 schrieb Michael Morris: Personally, I no longer directly use these calls, preferring in

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Michał Brzuchalski
Hi Michael, 2017-07-18 21:02 GMT+02:00 Michael Morris : > On Tue, Jul 18, 2017 at 2:56 PM, li...@rhsoft.net > wrote: > > > > > > > Am 18.07.2017 um 20:39 schrieb Michael Morris: > > > >> Personally, I no longer directly use these calls, preferring instead to > >> use > >> Symfony's HTTP foundati

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Michael Morris
On Tue, Jul 18, 2017 at 2:56 PM, li...@rhsoft.net wrote: > > > Am 18.07.2017 um 20:39 schrieb Michael Morris: > >> Personally, I no longer directly use these calls, preferring instead to >> use >> Symfony's HTTP foundation classes. Those in turn are, I understand, in the >> process of being conve

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 20:56 schrieb li...@rhsoft.net: Am 18.07.2017 um 20:39 schrieb Michael Morris: Personally, I no longer directly use these calls, preferring instead to use Symfony's HTTP foundation classes. Those in turn are, I understand, in the process of being converted to implement the

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 20:39 schrieb Michael Morris: Personally, I no longer directly use these calls, preferring instead to use Symfony's HTTP foundation classes. Those in turn are, I understand, in the process of being converted to implement the common interface outlined here: http://www.php-fig.or

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Michael Morris
Personally, I no longer directly use these calls, preferring instead to use Symfony's HTTP foundation classes. Those in turn are, I understand, in the process of being converted to implement the common interface outlined here: http://www.php-fig.org/psr/psr-7/ I would be much more interested in se

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Andrey Andreev
Hi Andreas, On Tue, Jul 18, 2017 at 7:39 PM, Andreas Treichel wrote: > Hello Andrey, > >>> $options are equal to the optional parameters of setcookie and >>> setrawcookie. >>> $options may contain: >>> >>> expires: int >>> path: string >>> domain: string >>> secure: bool >>> httponly: bool > > >>

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Michał Brzuchalski
Hi Andreas, 2017-07-18 18:39 GMT+02:00 Andreas Treichel : > Hello Andrey, > > $options are equal to the optional parameters of setcookie and >>> setrawcookie. >>> $options may contain: >>> >>> expires: int >>> path: string >>> domain: string >>> secure: bool >>> httponly: bool >>> >> > 1. The wor

[PHP-DEV] Re: PHP 7.2 forked

2017-07-18 Thread Jan Ehrhardt
Sara Golemon in php.internals (Tue, 18 Jul 2017 10:48:16 -0400): >That's it! Feature freeze is on. Congrats. Question, maybe for Anatol: what did change in the Windows Build environment? It was taking ages for 'Generating code', for each extension. Now it is as fast as building PHP 7.1. -- Jan -

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Andreas Treichel
Hello Andrey, $options are equal to the optional parameters of setcookie and setrawcookie. $options may contain: expires: int path: string domain: string secure: bool httponly: bool 1. The wording here implies that these are the *only* attributes allowed. In the interest of forward-compatibi

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Rowan Collins
On 18 July 2017 11:08:10 BST, Dan Ackroyd wrote: >On 18 July 2017 at 00:22, Andreas Treichel wrote: >> Hi, >> >> i want some feedback, about the following idea before i write a rfc. >> >> ... Most of them >> are optional and extensions (e.g. same-site) make it even more messy. > > >Two thoughts:

[PHP-DEV] Images on Workflow Wiki

2017-07-18 Thread Sara Golemon
Who does the art for https://wiki.php.net/vcs/gitworkflow ? It could use updating for 7.1 and 7.2 if you don't mind. If I tried it would look something like this: http://bit.ly/2uzjX7A -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.p

[PHP-DEV] PHP 7.2 forked

2017-07-18 Thread Sara Golemon
That's it! Feature freeze is on. Please include branch PHP-7.2 in all merges from 7.1 and earlier. Please commit all 7.2 fixes to PHP-7.2 and merge to master which is now targetting 7.3 This is real. https://github.com/php/php-src/commit/5230541ef59e0637d5522293a7d099bf18ce6af3 -Sara -- PHP I

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Andrey Andreev
Hi again, On Tue, Jul 18, 2017 at 4:23 PM, Frederik Bosch | Genkgo wrote: > Hi Andrey, > > Thanks for your feedback. If we are going to wait for http_cookie_set, > then my guess will be that it will take a while before we see samesite > cookie implemented. While I totally agree there is need for

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 16:00 schrieb Marco Pivetta: On Tue, Jul 18, 2017 at 3:50 PM, li...@rhsoft.net mailto:li...@rhsoft.net>> wrote: i don't share your optinion, especially talking about 'should be deprecated' where i get the feeling some peoples hobby is deprec

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Marco Pivetta
On Tue, Jul 18, 2017 at 3:50 PM, li...@rhsoft.net wrote: > i don't share your optinion, especially talking about 'should be > deprecated' where i get the feeling some peoples hobby is deprecate working > things > > comparing cookie params with encryption is hopefully just kidding > It could be a

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Marco Pivetta
Hey Andrey, On Mon, Jul 17, 2017 at 11:11 PM, Frederik Bosch | Genkgo wrote: > LS, > > Today I finished writing the RFC for implementing same site cookies in > PHP, https://wiki.php.net/rfc/same-site-cookie. I am happy to receive > your remarks on the proposal, and improve when necessary. > > For

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Frederik Bosch | Genkgo
Hi Marco, Great feedback. I have to think about it, but your concerns are valid for sure. The RFC is, however, broader then only setcookie and setrawcookie. How about session_set/get_cookie_params? Would you be able to accept the RFC if samesite would only be added to session? Why or why not?

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 15:45 schrieb Marco Pivetta: Hey Andrey, On Mon, Jul 17, 2017 at 11:11 PM, Frederik Bosch | Genkgo wrote: LS, Today I finished writing the RFC for implementing same site cookies in PHP, https://wiki.php.net/rfc/same-site-cookie. I am happy to receive your remarks on the pro

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Marco Pivetta
Hey Andrey, On Mon, Jul 17, 2017 at 11:11 PM, Frederik Bosch | Genkgo wrote: > LS, > > Today I finished writing the RFC for implementing same site cookies in > PHP, https://wiki.php.net/rfc/same-site-cookie. I am happy to receive > your remarks on the proposal, and improve when necessary. > > For

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Paul Jones
> On Jul 18, 2017, at 08:37, li...@rhsoft.net wrote: > > > > Am 18.07.2017 um 15:23 schrieb Frederik Bosch | Genkgo: >> Hi Andrey, >> Thanks for your feedback. If we are going to wait for http_cookie_set, then >> my guess will be that it will take a while before we see samesite cookie >> impl

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread li...@rhsoft.net
Am 18.07.2017 um 15:23 schrieb Frederik Bosch | Genkgo: Hi Andrey, Thanks for your feedback. If we are going to wait for http_cookie_set, then my guess will be that it will take a while before we see samesite cookie implemented. While I totally agree there is need for a new function with a

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Frederik Bosch | Genkgo
Hi Andrey, Thanks for your feedback. If we are going to wait for http_cookie_set, then my guess will be that it will take a while before we see samesite cookie implemented. While I totally agree there is need for a new function with a better API, I fail to see why that would mean we cannot ha

Re: [PHP-DEV] Re: Bundled libraries upgrade 'process'

2017-07-18 Thread Christoph M. Becker
On 18.07.2017 at 12:15, Anatol Belski wrote: >> -Original Message- >> From: Dan Ackroyd [mailto:dan...@basereality.com] >> Sent: Tuesday, July 18, 2017 10:42 AM >> To: Christoph M. Becker >> Cc: internals@lists.php.net >> Subject: [PHP-DEV] Re: Bundled libraries upgrade 'process' >> >> On

Re: [PHP-DEV] [RFC] samesite cookie implementation

2017-07-18 Thread Andrey Andreev
Hi Frederik, On Tue, Jul 18, 2017 at 12:11 AM, Frederik Bosch | Genkgo wrote: > LS, > > Today I finished writing the RFC for implementing same site cookies in PHP, > https://wiki.php.net/rfc/same-site-cookie. I am happy to receive your > remarks on the proposal, and improve when necessary. > > Fo

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Andrey Andreev
Hi Dan, On Tue, Jul 18, 2017 at 1:08 PM, Dan Ackroyd wrote: > On 18 July 2017 at 00:22, Andreas Treichel wrote: >> Hi, >> >> i want some feedback, about the following idea before i write a rfc. >> >> ... Most of them >> are optional and extensions (e.g. same-site) make it even more messy. > > >

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Andrey Andreev
Hi Andreas, On Tue, Jul 18, 2017 at 1:22 AM, Andreas Treichel wrote: > Hi, > > i want some feedback, about the following idea before i write a rfc. > > Problem: > The functions setcookie and setrawcookie has many parameters. Most of them > are optional and extensions (e.g. same-site) make it even

RE: [PHP-DEV] Re: Bundled libraries upgrade 'process'

2017-07-18 Thread Anatol Belski
Hi, > -Original Message- > From: Dan Ackroyd [mailto:dan...@basereality.com] > Sent: Tuesday, July 18, 2017 10:42 AM > To: Christoph M. Becker > Cc: internals@lists.php.net > Subject: [PHP-DEV] Re: Bundled libraries upgrade 'process' > > On 17 July 2017 at 20:09, Christoph M. Becker wro

Re: [PHP-DEV] http_cookie_set and http_cookie_remove

2017-07-18 Thread Dan Ackroyd
On 18 July 2017 at 00:22, Andreas Treichel wrote: > Hi, > > i want some feedback, about the following idea before i write a rfc. > > ... Most of them > are optional and extensions (e.g. same-site) make it even more messy. Two thoughts: i) Cookie functions are easily done in userland. ii) Addin

[PHP-DEV] Re: Bundled libraries upgrade 'process'

2017-07-18 Thread Dan Ackroyd
On 17 July 2017 at 20:09, Christoph M. Becker wrote: > On 17.07.2017 at 16:12, Dan Ackroyd wrote: > >> I just investigated an alleged bug related to the SQLite3 extension. > > Can you please report the bug and assign it to me. I can't promise that > I'll be able to fix it, but I would take a look