Re: [PHP-DEV] Write down a deprecation policy

2016-08-19 Thread Pierre Joye
Hi, On Aug 19, 2016 8:45 PM, "Rodrigue Villetard" wrote: > > Hello everyone, > > First post here, so please be gentle and pedagogic with me if I am > misbehaviouring… > > I am here for a pre-RFC feedback. It’s not coding related, but more about > convention. > > I’m a follower of the french maili

RE: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Anatol Belski
Hi Davey, > -Original Message- > From: Davey Shafik [mailto:da...@php.net] > Sent: Friday, August 19, 2016 7:09 PM > To: Christoph M. Becker > Cc: Anatol Belski ; internals@lists.php.net > Subject: Re: [PHP-DEV] SQLite 3.14 > > Christophe, > > I got the failure multiple times in my Debi

[PHP-DEV] RE: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Anatol Belski
> -Original Message- > From: Christoph M. Becker [mailto:cmbecke...@gmx.de] > Sent: Friday, August 19, 2016 4:29 PM > To: Anatol Belski ; PHP Internals > ; php-...@lists.php.net > Subject: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba > configuration for Windows: ext/dba/conf

Re: [PHP-DEV] [RFC][VOTE] Add session_create_id() function

2016-08-19 Thread Tom Worster
On 8/16/16 10:51 AM, Lester Caine wrote: On 16/08/16 13:08, Tom Worster wrote: The default 128 bits Session ID is large enough to ignore collisions https://wiki.php.net/rfc/session-create-id#discussions It describes for an application, but PHP is a platform. There are millions PHP apps or more

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Christoph M. Becker
On 19.08.2016 at 19:09, Davey Shafik wrote: > I got the failure multiple times in my Debian Jessie docker container that > I use for builds - you can check it out yourself at > https://github.com/dshafik/php-build to see the setup. > > Thanks for looking into this! Of course! And thanks for the

Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names

2016-08-19 Thread Stanislav Malyshev
Hi! > I explicitly asked Aaron to wait for me to check out things today. > Indeed, it is a mess, but it would probably already have been reverted > if we managed to verify the issues earlier on. :-) OK, please tell when you're ready :) Though checking could be done in a branch too... -- Stas Ma

Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names

2016-08-19 Thread Marco Pivetta
On Fri, Aug 19, 2016 at 8:40 PM, Stanislav Malyshev wrote: > Hi! > > > Looks like this problem is more complicated than I thought. I thought > > prepending the \ would mean little work on your end, but it appears I > > was wrong. > > I see that despite it not being as simple, BC break and clear l

Re: [PHP-DEV] Re: [RFC: PATCH v1] Implement mt_srand_array

2016-08-19 Thread Nikita Popov
On Fri, Aug 19, 2016 at 8:20 PM, Lauri Kenttä wrote: > On 2016-08-15 18:53, Tom Worster wrote: > >> Hi Lauri, >> >> Do you have a PR against php-src on github? It's easier to read and >> comment. >> >> Tom >> > > > Here's a PR with a revised patch (also accepts other than pure integers): > > http

Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names

2016-08-19 Thread Stanislav Malyshev
Hi! > Looks like this problem is more complicated than I thought. I thought > prepending the \ would mean little work on your end, but it appears I > was wrong. I see that despite it not being as simple, BC break and clear lack of consensus the change is still not reverted? -- Stas Malyshev sma

Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names

2016-08-19 Thread Marco Pivetta
Hi Aaron et all, I tried to implement support for 7.1 in zend-code as a start: https://github.com/zendframework/zend-code/pull/87 A few issues arise: * `ReflectionType#__toString()` is too volatile, especially if we want to support multiple versions of PHP, therefore it's a good idea to not th

[PHP-DEV] Re: [RFC: PATCH v1] Implement mt_srand_array

2016-08-19 Thread Lauri Kenttä
On 2016-08-15 18:53, Tom Worster wrote: Hi Lauri, Do you have a PR against php-src on github? It's easier to read and comment. Tom Here's a PR with a revised patch (also accepts other than pure integers): https://github.com/php/php-src/pull/2089 And here's an alternative with no sanit

Re: [PHP-DEV] ReflectionType::__toString() prepending \ to class names

2016-08-19 Thread Marco Pivetta
Hey Aaron, I am currently going through the changes, and just figured that 7.1 implements https://wiki.php.net/rfc/reflectiontypeimprovements, even though the RFC was declined: ./sapi/cli/php -r 'class Foo { public function bar() : ?Foo {} } var_dump((new ReflectionMethod("Foo", "bar"))->getRetur

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Davey Shafik
Argh! Apologies for autocomplete adding that 'e' to your name! - Davey On Sat, Aug 20, 2016 at 03:09 Davey Shafik wrote: > Christophe, > > I got the failure multiple times in my Debian Jessie docker container that > I use for builds - you can check it out yourself at > https://github.com/dshafi

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Davey Shafik
Christophe, I got the failure multiple times in my Debian Jessie docker container that I use for builds - you can check it out yourself at https://github.com/dshafik/php-build to see the setup. Thanks for looking into this! - Davey On Sat, Aug 20, 2016 at 01:35 Christoph M. Becker wrote: > Hi

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Christoph M. Becker
Hi Davey! On 19.08.2016 at 15:32, Davey Shafik wrote: > I saw this failure while packaging 7.1.0beta3, and assume it might be > related to your update: > > FAIL SQLite3 open_basedir checks > [ext/sqlite3/tests/sqlite3_21_security.phpt] > > DIFF > 006- > 007- Warning: SQLite3::__

Re: [PHP-DEV] [RFC][DISCUSSION] Remove utf8_decode() and utf8_encode()

2016-08-19 Thread Rowan Collins
On 19/08/2016 16:12, Pierre Joye wrote: I am against removing them, now or in 8.x. this is the kind of things that makes migrations painful. They are broken on some cases? Fix them maybe? The thing that is broken about the functions is not the functionality, but the name. I suppose you could

Re: [PHP-DEV] [RFC][DISCUSSION] Remove utf8_decode() and utf8_encode()

2016-08-19 Thread Pierre Joye
On Aug 15, 2016 10:18 AM, "Yasuo Ohgaki" wrote: > > Hi all, > > utf8_decode() and utf8_encode() are not needed and causing problems > than solving. > > https://wiki.php.net/rfc/remove_utf_8_decode_encode > > Proposal > - Document deprecation them now > - Remove them from 7.2 > > I think only f

Re: [PHP-DEV] PHP 7.1.0beta3 is available for testing

2016-08-19 Thread Marco Pivetta
Hello! As mentioned in http://marc.info/?l=php-internals&m=147145480117591&w=2, there is a BC break in this beta. I just tried this tag (compared to beta2) against zendframework/zend-code, and it breaks due to the discussed change. Fairly sure that other stuff broke as well. I'm currently lookin

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Christoph M. Becker
On 19.08.2016 at 15:22, Anatol Belski wrote: >> -Original Message- >> From: Christoph M. Becker [mailto:cmbecke...@gmx.de] >> Sent: Friday, August 19, 2016 1:38 PM >> To: Anatol Belski ; php-...@lists.php.net; >> internals@lists.php.net >> Subject: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix

Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-19 Thread Kalle Sommer Nielsen
2016-08-19 15:05 GMT+02:00 Davey Shafik : > Hey Internals, > > I'm working on the patch to change the error exception to > \ArgumentCountError instead of \Error when too few, or too many arguments > are passed in as discussed a couple of weeks ago. > > To be BC with 7.0, this extends \TypeError, wh

[PHP-DEV] Write down a deprecation policy

2016-08-19 Thread Rodrigue Villetard
Hello everyone, First post here, so please be gentle and pedagogic with me if I am misbehaviouring… I am here for a pre-RFC feedback. It’s not coding related, but more about convention. I’m a follower of the french mailing list about php internals where we discuss, chiefly thanks to Pascal Marti

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Davey Shafik
Hey Christoph, I saw this failure while packaging 7.1.0beta3, and assume it might be related to your update: FAIL SQLite3 open_basedir checks [ext/sqlite3/tests/sqlite3_21_security.phpt] DIFF 006- 007- Warning: SQLite3::__construct(): open_basedir restriction in effect. File(%s)

RE: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Anatol Belski
> -Original Message- > From: Christoph M. Becker [mailto:cmbecke...@gmx.de] > Sent: Friday, August 19, 2016 1:38 PM > To: Anatol Belski ; php-...@lists.php.net; > internals@lists.php.net > Subject: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for > Windows: ext/dba/config.w3

[PHP-DEV] Incorrect Argument Count Error

2016-08-19 Thread Davey Shafik
Hey Internals, I'm working on the patch to change the error exception to \ArgumentCountError instead of \Error when too few, or too many arguments are passed in as discussed a couple of weeks ago. To be BC with 7.0, this extends \TypeError, which is the exception currently thrown when strict_type

[PHP-DEV] GOOD Benchmark Results for PHP Master 2016-08-19

2016-08-19 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-08-19 06:23:00+03:00 commit: 6416312 previous commit:b97dc0b revision date: 2016-08-19 00:34:38+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Christoph M. Becker
Hi Anatol! On 19.08.2016 at 13:17, Anatol Belski wrote: > Hi Christoph, > >> -Original Message- >> From: Christoph Michael Becker [mailto:c...@php.net] >> Sent: Friday, August 19, 2016 11:42 AM >> To: php-...@lists.php.net >> Subject: [PHP-CVS] com php-src: Fix dba configuration for Wind

[PHP-DEV] RE: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Anatol Belski
Hi Christoph, > -Original Message- > From: Christoph Michael Becker [mailto:c...@php.net] > Sent: Friday, August 19, 2016 11:42 AM > To: php-...@lists.php.net > Subject: [PHP-CVS] com php-src: Fix dba configuration for Windows: > ext/dba/config.w32 > > Commit:ad76e8a529eabf150f17d313b

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-19 Thread Pierre Joye
On Aug 18, 2016 8:03 PM, "Christoph M. Becker" wrote: > > On 18.08.2016 at 01:32, Kalle Sommer Nielsen wrote: > > > 2016-08-15 7:53 GMT+02:00 Stanislav Malyshev : > >> Please comment and discuss! > > > > What about adding the following: > > ext/dba > > > > As for DBA, this extension have not reall

Re: [PHP-DEV] Namespaces internal refactoring

2016-08-19 Thread Michał Brzuchalski
Hi, As the initiator of this discussion, I would like to summarize it well, but I need this a little more time. Discussion was lively and I would like all the arguments to be included in the summary. It seems to me that I would need this help, and I am eager to progress and evolution of language

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-19 Thread Christoph M. Becker
On 18.08.2016 at 15:46, Christoph M. Becker wrote: > On 18.08.2016 at 15:12, Kalle Sommer Nielsen wrote: > >> But I will have to look at our deps and see if it is possible to get >> this running again with some cross reference to the m4. > > That would be great! I have just committed the minima

[PHP-DEV] PHP 7.1.0beta3 is available for testing

2016-08-19 Thread Davey Shafik
Hi, PHP 7.1.0beta3 was just released and can be downloaded from: https://downloads.php.net/~davey/ The Windows binaries will be available soon at http://windows.php.net/qa/ This release contains a number of bug fixes. For the list of bugfixes that you can target in your testing, pleas