[PHP-DEV] Re: [RFC][DISCUSSION] Add validation functions to filter

2016-08-05 Thread Yasuo Ohgaki
Hi all, On Fri, Aug 5, 2016 at 3:10 PM, Yasuo Ohgaki wrote: > > https://wiki.php.net/rfc/add_validate_functions_to_filter > > ToDo > - Rename function in PR > - Add flag for allowing TAB in string > - Use php_error_docref() for usage mistakes > - Finish filter_check_definition implementation(

[PHP-DEV] PHP 7.1.0beta2 is available for testing

2016-08-05 Thread Davey Shafik
Hi, PHP 7.1.0beta2 was just released and can be downloaded from: https://downloads.php.net/~davey/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer to

[PHP-DEV] Change to Too Few Args Exception RFC

2016-08-05 Thread Davey Shafik
Hey all, I know this is a little late in the process, but it's something I've noticed while prepping some content around 7.1. This RFC: https://wiki.php.net/rfc/too_few_args Passed, and has been implemented, but I feel that throwing an `\Error` exception is a mistake. I think we should another m

Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() towhich version?

2016-08-05 Thread Yasuo Ohgaki
Hi Christoph and all, On Fri, Aug 5, 2016 at 6:17 PM, Christoph Becker wrote: > > I think the names are okay, but it should be pointed out that they are > not related to assert() (particularly, that they are not affected by the > assert.* ini directives). Maybe "assume" or "require" instead of >

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Lauri Kenttä
On 2016-08-05 21:20, Charles R. Portwood II wrote: On Fri, Aug 5, 2016 at 12:12 PM, Tom Worster wrote: I can understand an argument that it's too much to expect a user to provide an options array when using Argon2. But I don't understand how my suggestion breaks BC. In my idea, a future RFC w

Re: [PHP-DEV] [RFC][VOTE] New operator (short tag) for context-dependent escaping

2016-08-05 Thread Pascal MARTIN, AFUP
Le 30/07/2016 à 17:09, Michael Vostrikov a écrit : Hello. The RFC 'New operator (short tag) for context-dependent escaping' is now in voting phase. Hi, Even if it could seem interesting at first, typically for beginners (hoping they use this operator instead of the current ones), we at AFUP

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Charles R. Portwood II
On Fri, Aug 5, 2016 at 12:12 PM, Tom Worster wrote: > > I can understand an argument that it's too much to expect a user to > provide an options array when using Argon2. But I don't understand how my > suggestion breaks BC. In my idea, a future RFC would propose default cost > constants. Changing

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Niklas Keller
2016-08-05 18:36 GMT+02:00 Charles R. Portwood II < charlesportwoo...@erianna.com>: > On Fri, Aug 5, 2016 at 10:08 AM, Ryan Pallas wrote: > > > > > > I think this is the most important part to consider. If you make $options > > required for this algo, then making this algo the PASSWORD_DEFAULT wo

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Tom Worster
On 8/5/16, 12:36 PM, "Charles R. Portwood II" wrote: >I understand what you're saying. Ryan said it a bit more clearly than I >did, making the options required causes backwards-incompatible changes to >the password_hash API. That's my real reservation behind not providing >defaults. > >A separat

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Charles R. Portwood II
On Fri, Aug 5, 2016 at 10:08 AM, Ryan Pallas wrote: > > > I think this is the most important part to consider. If you make $options > required for this algo, then making this algo the PASSWORD_DEFAULT would > mean that its a backwards incompatible change, because now all calls to > password_hash($

Re: [PHP-DEV] [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Niklas Keller
2016-08-05 14:47 GMT+02:00 Charles R. Portwood II < charlesportwoo...@erianna.com>: > Hello Internals, > > Due to a couple issue with the original RFC's scope, the RFC for > introducing Argon2 as an alternative hashing algorithm for the password_* > functions was closed shortly after starting on M

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Tom Worster
On 8/5/16, 11:08 AM, "Ryan Pallas" wrote: >Please keep it so that defaults will work, but $options is available for >tuning as that's how the feature currently works. My suggestion doesn't affect that. I agree that password_hash($password, PASSWORD_DEFAULT) should always "just work". Instead, I

Re: [PHP-DEV] UGLY Benchmark Results for PHP Master 2016-08-05

2016-08-05 Thread Nikita Popov
On Fri, Aug 5, 2016 at 4:30 PM, Matt Wilmas wrote: > Hi all, > > - Original Message - > From: > Sent: Friday, August 05, 2016 > > Results for project PHP master, build date 2016-08-05 06:26:56+03:00 >> commit: 65b6f20 >> previous commit: 69a72df >> revision date: 2016-08-04 22:27:42+02:0

[PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Tom Worster
On 8/5/16, 10:49 AM, "Charles R. Portwood II" wrote: >I think for clarity, PASSWORD_ARGON2I would be sufficient. What are your >thoughts? Looks good. >The rationale for providing defaults is to ensure the password_* >functions remain easy to use. I understand. I was actually suggesting that w

Re: [PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Ryan Pallas
On Fri, Aug 5, 2016 at 8:49 AM, Charles R. Portwood II < charlesportwoo...@erianna.com> wrote: > On Fri, Aug 5, 2016 at 9:19 AM, Tom Worster wrote: > > > On 8/5/16 8:47 AM, Charles R. Portwood II wrote: > > Finally, I wonder if it wouldn't be better if, for the time being, we > > do not provide d

[PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Charles R. Portwood II
On Fri, Aug 5, 2016 at 9:49 AM, Charles R. Portwood II < charlesportwoo...@erianna.com> wrote: > On Fri, Aug 5, 2016 at 9:19 AM, Tom Worster wrote: > >> On 8/5/16 8:47 AM, Charles R. Portwood II wrote: >> >> The RFC is available at: https://wiki.php.net/rfc/argon2_password_hash >>> >>> . >>> >> >

[PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Charles R. Portwood II
On Fri, Aug 5, 2016 at 9:19 AM, Tom Worster wrote: > On 8/5/16 8:47 AM, Charles R. Portwood II wrote: > > The RFC is available at: https://wiki.php.net/rfc/argon2_password_hash >> >> . >> > > Hi Charles, > > Thanks for doing this. I'm glad Argon2 is coming to PHP. > Hi Tom, Thanks for the feedb

Re: [PHP-DEV] UGLY Benchmark Results for PHP Master 2016-08-05

2016-08-05 Thread Matt Wilmas
Hi all, - Original Message - From: Sent: Friday, August 05, 2016 Results for project PHP master, build date 2016-08-05 06:26:56+03:00 commit: 65b6f20 previous commit: 69a72df revision date: 2016-08-04 22:27:42+02:00 environment: Haswell-EP cpu: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz

[PHP-DEV] Re: [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Tom Worster
On 8/5/16 8:47 AM, Charles R. Portwood II wrote: The RFC is available at: https://wiki.php.net/rfc/argon2_password_hash. Hi Charles, Thanks for doing this. I'm glad Argon2 is coming to PHP. You can have a longer voting period if you like, which I think would be a good idea. I think it's con

[PHP-DEV] [RFC][DISCUSSION] Argon2 Password Hash

2016-08-05 Thread Charles R. Portwood II
Hello Internals, Due to a couple issue with the original RFC's scope, the RFC for introducing Argon2 as an alternative hashing algorithm for the password_* functions was closed shortly after starting on Monday. The following details were adjusted. and I would appreciate your feedback before re-op

Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() to which version?

2016-08-05 Thread Christian Stadler
Am 04.08.2016 um 21:29 schrieb Yasuo Ohgaki: > On Thu, Aug 4, 2016 at 8:27 PM, Christian Stadler wrote: >> Am 04.08.2016 um 12:10 schrieb Yasuo Ohgaki: >>> On Thu, Aug 4, 2016 at 10:07 AM, Christian Stadler wrote: Am 01.08.2016 um 10:23 schrieb Yasuo Ohgaki: >>> I don't mind adding this feat

[PHP-DEV] UGLY Benchmark Results for PHP Master 2016-08-05

2016-08-05 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-08-05 06:26:56+03:00 commit: 65b6f20 previous commit:69a72df revision date: 2016-08-04 22:27:42+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() towhich version?

2016-08-05 Thread Christoph Becker
On 05.08.2016 at 02:15, Yasuo Ohgaki wrote: > Pierre suggested the functions should be named "filter_*" and I agree. > > On Fri, Aug 5, 2016 at 6:25 AM, Yasuo Ohgaki wrote: >> Input validation is like assertion shouldn't fail. > > How about > > filter_assert_var() <- validate_var(

Re: [PHP-DEV] Tracing exit()

2016-08-05 Thread Christoph Becker
On 05.08.2016 at 01:37, Sara Golemon wrote: > On Thu, Aug 4, 2016 at 11:10 AM, Bishop Bettini wrote: > >> Or, alternatively, I wonder if a method to convert an exit to an exception >> would be better: > > Eh... That feels less-obvious to me for the reasons you stated in your > OP. I'm not convin