Re: [PHP-DEV] Request for wiki karma

2016-07-09 Thread Scott Arciszewski
Version 1.3 of the Argon2 spec alleviated my concerns. I never completed my patch, and the past couple of months have been hectic. I can review the patch before it's merged if you want, but I still don't have the free time to author an alternative. If accepted in 7.1, I believe it can be the new

Re: [PHP-DEV] Request for wiki karma

2016-07-09 Thread Pierre Joye
On Jul 10, 2016 2:38 AM, "Charles R. Portwood II" < charlesportwoo...@erianna.com> wrote: > > Hello Internals, > > I'd like to improve the password_* functions by adding support for > Argon2[1], the winner of the Password Hasing Competition[2]. > > I've previously implemented an extension[3] to han

Re: [PHP-DEV] Request for wiki karma

2016-07-09 Thread Ferenc Kovacs
On Sat, Jul 9, 2016 at 9:37 PM, Charles R. Portwood II < charlesportwoo...@erianna.com> wrote: > Hello Internals, > > I'd like to improve the password_* functions by adding support for > Argon2[1], the winner of the Password Hasing Competition[2]. > > I've previously implemented an extension[3] to

[PHP-DEV] Request for wiki karma

2016-07-09 Thread Charles R. Portwood II
Hello Internals, I'd like to improve the password_* functions by adding support for Argon2[1], the winner of the Password Hasing Competition[2]. I've previously implemented an extension[3] to handle this, however I believe this would be better to have Argon2 implemented directly password_* functi

Re: [PHP-DEV] Re: [RFC][Vote] ReflectionType Improvements

2016-07-09 Thread Levi Morrison
On Sat, Jul 9, 2016 at 8:16 AM, Aaron Piotrowski wrote: >> >> On Jul 9, 2016, at 8:17 AM, Levi Morrison wrote: >>> >> >> The final vote was 5 in favor and 8 against. This RFC has been rejected. >> > > While this RFC was rejected, ReflectionType::__toString() should still be > updated to include

Re: [PHP-DEV] Re: [RFC][Vote] ReflectionType Improvements

2016-07-09 Thread Nikita Popov
On Sat, Jul 9, 2016 at 4:16 PM, Aaron Piotrowski wrote: > > > > On Jul 9, 2016, at 8:17 AM, Levi Morrison wrote: > >> > > > > The final vote was 5 in favor and 8 against. This RFC has been rejected. > > > > While this RFC was rejected, ReflectionType::__toString() should still be > updated to in

Re: [PHP-DEV] Re: [RFC][Vote] ReflectionType Improvements

2016-07-09 Thread Aaron Piotrowski
> > On Jul 9, 2016, at 8:17 AM, Levi Morrison wrote: >> > > The final vote was 5 in favor and 8 against. This RFC has been rejected. > While this RFC was rejected, ReflectionType::__toString() should still be updated to include a ? for nullable types. This is a consequence of the nullable t

[PHP-DEV] Re: [RFC][VOTE] Deprecate then Remove Mcrypt Closed (23-6)

2016-07-09 Thread Christoph Becker
Hi Scott! On 22.03.2016 at 18:00, Scott Arciszewski wrote: > https://wiki.php.net/rfc/mcrypt-viking-funeral > > The tally of closing (2016-03-22T17:00:00) is 23 Yes, 6 No. This is a 79.3% > favorable response, which exceeds the 2/3 majority by a significant margin. > > Thanks to everyone who vo

[PHP-DEV] Re: [RFC][Vote] ReflectionType Improvements

2016-07-09 Thread Levi Morrison
On Thu, Jun 30, 2016 at 10:06 AM, Levi Morrison wrote: > The RFC for improving ReflectionType[1] is now in voting phase. The voting > window is June 30th through July 8th. I have not finished the patch but I'll > have it done before the end of voting. > > [1]: https://wiki.php.net/rfc/Reflection

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Christoph Becker
On 09.07.2016 at 11:18, Leigh wrote: > On Sat, 9 Jul 2016 at 10:16 Christoph Becker wrote: > >> Assuming that "Make array_rand() more efficient" is indeed only about >> performance (and not about fixes for the broken implementation), it >> wouldn't be a bug fix, but as array_rand()'s behavior wo

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Christoph Becker
On 09.07.2016 at 10:49, Pierre Joye wrote: > On Jul 9, 2016 3:19 PM, "Leigh" wrote: >> >> On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: >>> >>> So, I voted no then as it is clear that you do not see a problem to >>> break codes without a single warning or time to adapt before. >>> >>> The other

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Leigh
On Sat, 9 Jul 2016 at 10:16 Christoph Becker wrote: > > Assuming that "Make array_rand() more efficient" is indeed only about > performance (and not about fixes for the broken implementation), it > wouldn't be a bug fix, but as array_rand()'s behavior would change > anyway as noted by the RFC, it

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Christoph Becker
On 09.07.2016 at 10:18, Leigh wrote: > On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: > >> So, I voted no then as it is clear that you do not see a problem to >> break codes without a single warning or time to adapt before. >> >> The other sections are fine and voted yes. > > For the part where

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Jul 9, 2016 4:05 PM, "Leigh" wrote: > > On Sat, 9 Jul 2016 at 09:49 Pierre Joye wrote: >> >> >> I am sorry but this PR possibly breaks BC and cases have been clearly explained how and why. Asking to show production code publically is not something that you should request. >> >> I can write a

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Leigh
On Sat, 9 Jul 2016 at 09:49 Pierre Joye wrote: > > I am sorry but this PR possibly breaks BC and cases have been clearly > explained how and why. Asking to show production code publically is not > something that you should request. > > I can write a sample app to show you how but given the expla

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Jul 9, 2016 3:49 PM, "Pierre Joye" wrote: > > > On Jul 9, 2016 3:19 PM, "Leigh" wrote: > > > > > > On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: > >> > >> So, I voted no then as it is clear that you do not see a problem to > >> break codes without a single warning or time to adapt before. >

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Jul 9, 2016 3:19 PM, "Leigh" wrote: > > > On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: >> >> So, I voted no then as it is clear that you do not see a problem to >> break codes without a single warning or time to adapt before. >> >> The other sections are fine and voted yes. > > > For the par

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Leigh
On Sat, 9 Jul 2016 at 08:48 Pierre Joye wrote: > So, I voted no then as it is clear that you do not see a problem to > break codes without a single warning or time to adapt before. > > The other sections are fine and voted yes. > For the part where you voted no. Still nobody has presented (publi

Re: [PHP-DEV] [RFC][VOTE] RNG fixes

2016-07-09 Thread Pierre Joye
On Thu, Jul 7, 2016 at 7:56 PM, Pierre Joye wrote: > > On Jul 7, 2016 7:53 PM, "Leigh" wrote: >> >> On 7 July 2016 at 13:39, Pierre Joye wrote: >> > Hi >> > >> > Looks good but missing an option to choose the default mode. >> > >> > I would choose BC as default at least for one release (7.1). >

Re: [PHP-DEV] Proposal for php7 class method return

2016-07-09 Thread Marco Pivetta
Hey Daniel, I've been playing around with `self` for a while (mostly dealing with code-generators and inheritance), and what I found is that it doesn't really make sense as a type-hint, not even in interfaces. Besides the type-work to be done to do `function setValue($value) : myClass`, what is t

[PHP-DEV] Proposal for php7 class method return

2016-07-09 Thread Daniel Ciochiu
Hi, I have a proposal that for a given method with a return type of , if method does not return anything than it should it's instance. It will reduce code by only one line, but will improve consecutive method calls. class myClass { protected $value; function setValue($value) : self {