Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

2015-05-08 Thread Sara Golemon
On Fri, May 8, 2015 at 9:23 PM, Pierre Joye wrote: > Maybe we can create a repo on github to share them? > > I can create one, yes I prefer github than PHP's git, much easier to > manage, issues, etc > I say go for it, since you're our liason to the MSVC team. For me, I agree with what Nikita sai

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-05-08 Thread Sebastian Bergmann
Am 09.05.2015 um 06:38 schrieb Stanislav Malyshev: > OK, if there's consensus we can go forward with this, then let's just do > that ASAP. Can you implement this? Thanks! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-05-08 Thread Stanislav Malyshev
Hi! > I feel like this one is different though, because there already was > consensus that the current naming isn't the best, and there was > support for Throwable, while voting on the "original" RFC was still > open. OK, if there's consensus we can go forward with this, then let's just do that A

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

2015-05-08 Thread Pierre Joye
Hi! Thanks! Maybe we can create a repo on github to share them? I can create one, yes I prefer github than PHP's git, much easier to manage, issues, etc Cheers, Pierre On May 9, 2015 11:10 AM, "Levi Morrison" wrote: > On Fri, May 8, 2015 at 7:13 AM, Levi Morrison wrote: > > On Fri, May 8, 20

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

2015-05-08 Thread Levi Morrison
On Fri, May 8, 2015 at 7:13 AM, Levi Morrison wrote: > On Fri, May 8, 2015 at 5:01 AM, Pierre Joye wrote: >> On May 8, 2015 4:42 AM, "Christoph Becker" wrote: >>> >>> Nikita Popov wrote: >>> >>> > [...] What's our current minimum required vc version? >>> >>> As of PHP 5.5 at least VC11 (Visual S

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-05-08 Thread David Zuelke
I feel like this one is different though, because there already was consensus that the current naming isn't the best, and there was support for Throwable, while voting on the "original" RFC was still open. To adhere to the RFC process, the open RFC wasn't changed accordingly, because voting was

Re: [PHP-DEV] PR 1217: Add support for upload files from buffer string in curl extenion

2015-05-08 Thread Alexander Moskalev
Hi! I try rewrite feature to use exists class: https://github.com/php/php-src/commit/6319f954ca0674c77bb1f8f8409c9ac841fe301d Please, take a look at this commit. 1) constructor does not require params 2) added curl_buffer_file_create function (like curl_file_create) 3) setters changed to allow b

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

2015-05-08 Thread Levi Morrison
On Fri, May 8, 2015 at 5:01 AM, Pierre Joye wrote: > On May 8, 2015 4:42 AM, "Christoph Becker" wrote: >> >> Nikita Popov wrote: >> >> > [...] What's our current minimum required vc version? >> >> As of PHP 5.5 at least VC11 (Visual Studio 2012) is required for Windows >> builds. The currently a

Re: [PHP-DEV] Thoughts on C version supported for PHP-Next

2015-05-08 Thread Pierre Joye
On May 8, 2015 4:42 AM, "Christoph Becker" wrote: > > Nikita Popov wrote: > > > [...] What's our current minimum required vc version? > > As of PHP 5.5 at least VC11 (Visual Studio 2012) is required for Windows > builds. The currently available snapshots of master are also built with > VC11[1].