[PHP-DEV] Objects-as-keys RFC

2015-01-06 Thread Stanislav Malyshev
Hi! The vote for the RFC https://wiki.php.net/rfc/objkey has concluded, the RFC was rejected 24 votes against to 6 votes for. Thanks to everybody who participated in the discussion, -- Stas Malyshev smalys...@gmail.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, vis

Re: [PHP-DEV] [VOTE][RFC] PHP 5.7

2015-01-06 Thread Andrea Faulds
Good evening, > On 29 Dec 2014, at 14:41, Andrea Faulds wrote: > > I’m going to put the PHP 5.7 RFC to a vote, since it’d been 2 weeks. I’m not > entirely certain myself whether it’s a good idea, but I’d like it for us to > vote on it so we can settle the matter. If people vote against 5.7, a

Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-06 Thread Andrea Faulds
Hey Dmitry, > On 23 Oct 2014, at 16:22, Dmitry Stogov wrote: > >> I’ve so far been scared to touch the asm… but actually, I don’t think it >> could be *that* hard. It’s not doing something especially complex. The >> bigint API looks fairly stable now and I’m unlikely to change it much >> further

[PHP-DEV] Re: hash_equals: leak less information about length

2015-01-06 Thread Kévin Dunglas
Hello internals, I've submitted this PR a long time ago: https://github.com/php/php-src/pull/792 I still think it's a good idea to mitigate the length leak (rather than returning immediately if strings are not of the same length) while advertising in docs that the length will leak in any case. p

[PHP-DEV] Re: Faster zend sorting implementation

2015-01-06 Thread Dmitry Stogov
I think this break is acceptable Of course, if the new sort implementation significantly improves performance on some cases and doesn't show degradation on the others. Thanks. Dmitry. On Jan 5, 2015 9:08 PM, "Xinchen Hui" wrote: > Hey: > > I was working on zend_qsort improvement. but I got

Re: [PHP-DEV] [RFC] Parameter skipping, take 3

2015-01-06 Thread Rowan Collins
On 05/01/2015 22:35, Andrea Faulds wrote: If the default values are obvious and intuitive, as they should be, you don’t need “default”. It's not always a case of not knowing what the default values are; sometimes it's a case of not knowing - and not wanting to worry about - what they might b

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Stanislav Malyshev
Hi! > The first reason is that, if we consider a released extension as a > conceptual unit, the best way to protect its integrity is to store it > as a single file. Storing it as separate files brings a lot of > potential issues : files can be renamed, deleted, etc. Offline tools Yet people have

Re: [PHP-DEV] Faster zend sorting implementation

2015-01-06 Thread David Zuelke
On 06.01.2015, at 05:42, Pierre Joye wrote: > I am not sure about that. Introducing a not easy to catch BC break for > 0.1% gain on function (or even for the whole app) is not very > appealing. > > However, there is nothing in the documentation actually describing how > it works and there are cl

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Pierre Joye
On Jan 6, 2015 9:53 PM, "Benjamin Eberlei" wrote: > > > > On Tue, Jan 6, 2015 at 3:50 PM, Pierre Joye wrote: >> >> >> On Jan 6, 2015 9:20 PM, "François Laupretre" wrote: >> The whole code to consider as part of an extension, whatever the language, must be kept in sync. And the best way to achiev

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Benjamin Eberlei
On Tue, Jan 6, 2015 at 3:50 PM, Pierre Joye wrote: > > On Jan 6, 2015 9:20 PM, "François Laupretre" wrote: > The whole code to consider as part of an extension, whatever the language, > must be kept in sync. And the best way to achieve this is to store it in a > single file. > > I would rather s

RE: [PHP-DEV] Cleaning up dangling whitespace

2015-01-06 Thread François Laupretre
> De : Pierre Joye [mailto:pierre@gmail.com] > > Even better than a server side hook, far less intrusive and rejecting > a commit when CS are broken before it even gets applied locally sounds > like the best solution so far. If it is technically possible, I think we need both. Local-side pre

RE: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Pierre Joye
On Jan 6, 2015 9:20 PM, "François Laupretre" wrote: The whole code to consider as part of an extension, whatever the language, must be kept in sync. And the best way to achieve this is to store it in a single file. I would rather say in a single release and package. Built in scripts in an extensi

RE: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread François Laupretre
> De : Pierre Joye [mailto:pierre@gmail.com] > 2. We have no easy way to actually release and deploy adhoc scripts, > used by a given extension > > For 2., it is one of the thing I can imagine implementing in pickle. > Or even better add it a s part of the build scripts and macros. Either > w

Re: [PHP-DEV] Cleaning up dangling whitespace

2015-01-06 Thread Pierre Joye
On Tue, Jan 6, 2015 at 3:33 AM, Nikita Popov wrote: > On Tue, Jan 6, 2015 at 12:26 PM, Derick Rethans wrote: > >> On Tue, 6 Jan 2015, Nikita Popov wrote: >> >> > On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev > > >> > wrote: >> > >> > > The code in the PHP source repo has a lot of random dan

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Pierre Joye
On Tue, Jan 6, 2015 at 3:37 AM, Benjamin Eberlei wrote: > The general plan seems to be to have a way to embed PHP code into the > shared object, for example using Autoconf Macros (like the embed extension > mentioned above does) Just for the record, stated it before but... :) I do think it is a

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Pierre Joye
On Tue, Jan 6, 2015 at 3:24 AM, Derick Rethans wrote: > On Mon, 5 Jan 2015, Stanislav Malyshev wrote: > >> > 2) Embedded text sections. It's possible to place the raw PHP code >> > into the compiled .so/.dylib/.dll file and fetch it out for >> > compilation at runtime. This enables easy bundling

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Benjamin Eberlei
On Tue, Jan 6, 2015 at 12:24 PM, Derick Rethans wrote: > On Mon, 5 Jan 2015, Stanislav Malyshev wrote: > > > > 2) Embedded text sections. It's possible to place the raw PHP code > > > into the compiled .so/.dylib/.dll file and fetch it out for > > > compilation at runtime. This enables easy bun

Re: [PHP-DEV] Cleaning up dangling whitespace

2015-01-06 Thread Nikita Popov
On Tue, Jan 6, 2015 at 12:26 PM, Derick Rethans wrote: > On Tue, 6 Jan 2015, Nikita Popov wrote: > > > On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev > > > wrote: > > > > > The code in the PHP source repo has a lot of random dangling > > > whitespace at the end of lines, which looks sloppy

Re: [PHP-DEV] Cleaning up dangling whitespace

2015-01-06 Thread Derick Rethans
On Tue, 6 Jan 2015, Nikita Popov wrote: > On Mon, Jan 5, 2015 at 11:58 PM, Stanislav Malyshev > wrote: > > > The code in the PHP source repo has a lot of random dangling > > whitespace at the end of lines, which looks sloppy and produces some > > weird effects in diffs because some editors aut

Re: [PHP-DEV] [RFC] Extension Prepend Files

2015-01-06 Thread Derick Rethans
On Mon, 5 Jan 2015, Stanislav Malyshev wrote: > > 2) Embedded text sections. It's possible to place the raw PHP code > > into the compiled .so/.dylib/.dll file and fetch it out for > > compilation at runtime. This enables easy bundling of the loaded > > I guess it is possible, but why - what's

Re: [PHP-DEV] Cleaning up dangling whitespace

2015-01-06 Thread Pierre Joye
On Mon, Jan 5, 2015 at 11:48 PM, Pierre Joye wrote: > On Mon, Jan 5, 2015 at 11:42 PM, Jacob Bednarz > wrote: >> Hey >> >>> That reminds me something I was wondering, would it be possible to >>> have a kind of CS check on push? :) >> >> >> Yep - PHPCS[1] is quite good, easy to configure and has

Re: [PHP-DEV] Cleaning up dangling whitespace

2015-01-06 Thread Jacob Bednarz
I did not PHPCS supports C. Or am I missing something? Nope, you are spot on :) - I read this as "let's clean up our repositories" not just php-src (which reading back through was my misinterpretation). Do you have a tool in mind? I see there are a few like indent[1], uncrustify[2] and as