Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-19 Thread Dmitry Stogov
1) INF conversion to zero seems wrong. May be +INF should be converted to MAX_LONG and -INF to MIN_LONG? 2) Negative shifts would be useful, as Sara mentioned. 3) a bit unrelated, but it also may make sense to introduce a logical right shift operator (>>> in Java) the rest seems fine, patch look

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-19 Thread Dmitry Stogov
Anyone objects about it or thinks it needs RFC? Thanks. Dmitry. On Wed, Aug 20, 2014 at 6:48 AM, Laruence wrote: > Hey: > > > On Tue, Aug 19, 2014 at 10:10 PM, Dmitry Stogov wrote: > > Hi, > > > > Yesterday we discussed with Nikta the failure of > > ext/standard/tests/http/bug60570.phpt. It w

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-19 Thread Sara Golemon
On Tue, Aug 19, 2014 at 3:36 PM, Andrea Faulds wrote: > https://wiki.php.net/rfc/integer_semantics > In a perfect world, I'd rather see "<< -X" be equivalent to ">> X", but since we do something very different currently, I think your approach of throw an error and ask questions later seems appropr

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-19 Thread Laruence
Hey: On Wed, Aug 20, 2014 at 6:36 AM, Andrea Faulds wrote: > Good evening, > > I have made an RFC which would make some small changes to how integers are > handled, targeted at PHP 7: > > https://wiki.php.net/rfc/integer_semantics I'd like don't change the works behavior. make it act the simil

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-19 Thread Laruence
Hey: On Tue, Aug 19, 2014 at 10:10 PM, Dmitry Stogov wrote: > Hi, > > Yesterday we discussed with Nikta the failure of > ext/standard/tests/http/bug60570.phpt. It was in context of AST patch, but > the failure is not related to AST at all. It's just a bad test that makes > wrong assumption. > >

Re: [PHP-DEV] [RFC] Integer Semantics

2014-08-19 Thread Kris Craig
On Tue, Aug 19, 2014 at 3:36 PM, Andrea Faulds wrote: > Good evening, > > I have made an RFC which would make some small changes to how integers are > handled, targeted at PHP 7: > > https://wiki.php.net/rfc/integer_semantics > > Thoughts and questions are appreciated. Thanks! > -- > Andrea Fauld

[PHP-DEV] [RFC] Integer Semantics

2014-08-19 Thread Andrea Faulds
Good evening, I have made an RFC which would make some small changes to how integers are handled, targeted at PHP 7: https://wiki.php.net/rfc/integer_semantics Thoughts and questions are appreciated. Thanks! -- Andrea Faulds http://ajf.me/ -- PHP Internals - PHP Runtime Development Mailing

Re: [PHP-DEV] Re: 5.6.0 final is near

2014-08-19 Thread Lior Kaplan
Please make sure these security fixes are included: fileinfo: Fixed bug #67716 (Segfault in cdf.c). (CVE-2014-3587) gd: Fixed bug #67730 (Null byte injection possible with imagexxx functions). (CVE-2014-5120) Thanks, Kaplan On Mon, Aug 18, 2014 at 5:46 PM, Ferenc Kovacs wrote: > On Sun, Aug

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-19 Thread Andi Gutmans
got it. thanks! On Aug 18, 2014, at 11:36 PM, Dmitry Stogov wrote: > Hi Andi, > > We already discussed most of semantic changes introduced in AST patch. > Most of them came from another approved RFC > https://wiki.php.net/rfc/uniform_variable_syntax > > Thanks. Dmitry. > > > On Tue, Aug 19,

Re: [PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-19 Thread Pierre Joye
hi, On Tue, Aug 19, 2014 at 4:10 PM, Dmitry Stogov wrote: > Hi, > > Yesterday we discussed with Nikta the failure of > ext/standard/tests/http/bug60570.phpt. It was in context of AST patch, but > the failure is not related to AST at all. It's just a bad test that makes > wrong assumption. > > Res

[PHP-DEV] ext/standard/tests/http/bug60570.phpt failure

2014-08-19 Thread Dmitry Stogov
Hi, Yesterday we discussed with Nikta the failure of ext/standard/tests/http/bug60570.phpt. It was in context of AST patch, but the failure is not related to AST at all. It's just a bad test that makes wrong assumption. Resource leaks can't be caught using get_memory_usage(). To have a robust wa

[PHP-DEV] Re: [RFC] pecl_http

2014-08-19 Thread Michael Wallner
On 19/08/14 09:49, Michael Wallner wrote: > Hi PHP internals! > > I've created an RFC for discussion: > > Whether it is feasible to add pecl_http v2 to the core. > > https://wiki.php.net/rfc/pecl_http > Just a heads up. People seem very confused because they read the docs on php.net and

Re: [PHP-DEV] 5.4 security only

2014-08-19 Thread Ferenc Kovacs
2014.08.19. 1:59 ezt írta ("Stas Malyshev" ): > > Hi! > > Moving this out of other topics into its own: according to the release > RFC, we should have 5.4 have 2 years of bugfixes & one year of security > fixes. Since 5.4 was released in March 2012, we're already past 2 year > mark. However, we're

Re: [PHP-DEV] Re: [RFC] pecl_http

2014-08-19 Thread Pierre Joye
On Tue, Aug 19, 2014 at 2:19 PM, Michael Wallner wrote: > On 19 August 2014 11:24, Pierre Joye wrote: >> >> On Tue, Aug 19, 2014 at 11:17 AM, Jan Ehrhardt wrote: >> > Is pecl_http v2 still dependent on propro and raphf? If so, they should >> > be in core as well. >> > >> >> I never really unders

Re: [PHP-DEV] [RFC] pecl_http

2014-08-19 Thread Michael Wallner
On 19 August 2014 13:53, Johannes Schlüter wrote: > > In my opinion when moving this to core the http(s):// stream should use > the same HTTP implementation so one has consistent behavior. > > This would add a hard dependency on libcurl, which I'd be obviously fine with. > I also see that HTTP

Re: [PHP-DEV] Re: [RFC] pecl_http

2014-08-19 Thread Michael Wallner
On 19 August 2014 11:24, Pierre Joye wrote: > On Tue, Aug 19, 2014 at 11:17 AM, Jan Ehrhardt wrote: > > Is pecl_http v2 still dependent on propro and raphf? If so, they should > > be in core as well. > > > > I never really understood why they are needed or why they have been > splitted off. I ca

Re: [PHP-DEV] Re: [RFC] pecl_http

2014-08-19 Thread Michael Wallner
On 19 August 2014 11:17, Jan Ehrhardt wrote: > > Is pecl_http v2 still dependent on propro and raphf? If so, they should > be in core as well. > > Yes, they are mentioned in the "Open Issues" section. -- Regards, Mike

Re: [PHP-DEV] [RFC] pecl_http

2014-08-19 Thread Johannes Schlüter
On Tue, 2014-08-19 at 09:49 +0200, Michael Wallner wrote: > Hi PHP internals! > > I've created an RFC for discussion: > > Whether it is feasible to add pecl_http v2 to the core. > > https://wiki.php.net/rfc/pecl_http In my opinion when moving this to core the http(s):// stream should use

Re: [PHP-DEV] 5.4 security only

2014-08-19 Thread Julien Pauli
On Tue, Aug 19, 2014 at 1:59 AM, Stas Malyshev wrote: > Hi! > > Moving this out of other topics into its own: according to the release > RFC, we should have 5.4 have 2 years of bugfixes & one year of security > fixes. Since 5.4 was released in March 2012, we're already past 2 year > mark. However,

Re: [PHP-DEV] 5.4 security only

2014-08-19 Thread David Zuelke
I'd like to see https://github.com/php/php-src/pull/694 / https://github.com/php/php-src/pull/765 in so FPM in 5.4 will work properly with Apache 2.4.10+'s mod_proxy_fcgi. David On 19 Aug 2014, at 01:59, Stas Malyshev wrote: > Hi! > > Moving this out of other topics into its own: according

[PHP-DEV] 回复: [PHP-DEV] 回复: [PHP-DEV] How should I call a PHP function

2014-08-19 Thread Wei Dai
> On Tue, 19 Aug 2014, Wei Dai wrote: > > > > On Mon, 18 Aug 2014, Wei Dai wrote: > > > > > > > > I'm trying to call a function inside a module, a PHP_FUNCTION. > > > > > Other than zend_eval_stringl, what's the direct way to do it? > > > > > > > > > > > > > Please refer to call_user_funct

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-19 Thread Nikita Popov
On Tue, Aug 19, 2014 at 11:21 AM, Laruence wrote: > Hey: > >the problem came from zend_ast_size for 0 children node.. > Thanks for the report, this should be fixed now: https://github.com/nikic/php-src/commit/69f0deb399eec76bc8afa97fa383b08a207582fb Nikita

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-19 Thread Pierre Joye
On Tue, Aug 19, 2014 at 11:30 AM, Laruence wrote: > Hey: > > a fix could be: > diff --git a/Zend/zend_ast.c b/Zend/zend_ast.c > index eb35a51..f738e34 100644 > --- a/Zend/zend_ast.c > +++ b/Zend/zend_ast.c > @@ -33,11 +33,11 @@ static inline void *zend_ast_realloc(void *old, > size_t old_size, s

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-19 Thread Laruence
Hey: a fix could be: diff --git a/Zend/zend_ast.c b/Zend/zend_ast.c index eb35a51..f738e34 100644 --- a/Zend/zend_ast.c +++ b/Zend/zend_ast.c @@ -33,11 +33,11 @@ static inline void *zend_ast_realloc(void *old, size_t old_size, size_t new_size return new; } -size_t zend_ast_size(zend_uint chi

Re: [PHP-DEV] Re: [RFC] pecl_http

2014-08-19 Thread Pierre Joye
On Tue, Aug 19, 2014 at 11:17 AM, Jan Ehrhardt wrote: > Michael Wallner in php.internals (Tue, 19 Aug 2014 09:49:34 +0200): >>Hi PHP internals! >> >>I've created an RFC for discussion: >> >> Whether it is feasible to add pecl_http v2 to the core. >> >>https://wiki.php.net/rfc/pecl_http > > I

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-19 Thread Laruence
Hey: the problem came from zend_ast_size for 0 children node.. backtrace: Program terminated with signal 6, Aborted. #0 0x0034dc030285 in raise () from /lib64/libc.so.6 (gdb) bt #0 0x0034dc030285 in raise () from /lib64/libc.so.6 #1 0x0034dc031d30 in abort () from /lib64/lib

Re: [PHP-DEV] Re: 回复: [PHP-DEV] 回复: [PHP-DEV] How should I call a PHP function

2014-08-19 Thread Pierre Joye
On Tue, Aug 19, 2014 at 11:11 AM, Wei Dai wrote: > > On Tue, Aug 19, 2014 at 10:55 AM, Derick Rethans wrote: > > On Tue, 19 Aug 2014, Wei Dai wrote: > > On Mon, 18 Aug 2014, Wei Dai wrote: > > > so, i have two options: > > 1. copy the duplicate code into my extension, It can be fast in this > way

[PHP-DEV] Re: [RFC] pecl_http

2014-08-19 Thread Jan Ehrhardt
Michael Wallner in php.internals (Tue, 19 Aug 2014 09:49:34 +0200): >Hi PHP internals! > >I've created an RFC for discussion: > > Whether it is feasible to add pecl_http v2 to the core. > >https://wiki.php.net/rfc/pecl_http Is pecl_http v2 still dependent on propro and raphf? If so, they sho

Re: [PHP-DEV] [VOTE] Abstract Syntax Tree

2014-08-19 Thread Laruence
Hey: I find a problem while I was trying play with the patch Generating phar.php Generating phar.phar Fatal error: Out of memory (allocated 786432) at /home/huixinchen/opensource/github/php-src/Zend/zend_arena.h:69 (tried to allocate 34359738400 bytes) in /home/huixinchen/opensource/github/p

[PHP-DEV] 回复: [PHP-DEV] Re: 回复: [PHP-DEV] 回复: [PHP-DEV] How should I call a PHP function

2014-08-19 Thread Wei Dai
> On Tue, Aug 19, 2014 at 10:55 AM, Derick Rethans (mailto:der...@php.net)> wrote: > > On Tue, 19 Aug 2014, Wei Dai wrote: > > > > > > On Mon, 18 Aug 2014, Wei Dai wrote: > > > > so, i have two options: > > > > > > 1. copy the duplicate code into my extension, It can be fast in this > > > w

Re: [PHP-DEV] Re: 回复: [PHP-DEV] 回复: [PHP-DEV] How should I call a PHP function

2014-08-19 Thread Pierre Joye
On Tue, Aug 19, 2014 at 10:55 AM, Derick Rethans wrote: > On Tue, 19 Aug 2014, Wei Dai wrote: > >> > On Mon, 18 Aug 2014, Wei Dai wrote: >> so, i have two options: >> >> 1. copy the duplicate code into my extension, It can be fast in this >> way, but the code is not beautiful. >> >> 2. call call_

[PHP-DEV] Re: 回复: [PHP-DEV] 回复: [PHP-DEV] How should I call a PHP function

2014-08-19 Thread Derick Rethans
On Tue, 19 Aug 2014, Wei Dai wrote: > > On Mon, 18 Aug 2014, Wei Dai wrote: > > > > > > I'm trying to call a function inside a module, a PHP_FUNCTION. > > > > Other than zend_eval_stringl, what's the direct way to do it? > > > Please refer to call_user_function and call_user_function_ex. > > >

[PHP-DEV] [RFC] pecl_http

2014-08-19 Thread Michael Wallner
Hi PHP internals! I've created an RFC for discussion: Whether it is feasible to add pecl_http v2 to the core. https://wiki.php.net/rfc/pecl_http -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php