Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_spki_

2013-05-12 Thread Pierre Joye
On Mon, May 13, 2013 at 2:09 AM, Stas Malyshev wrote: > Hi! > >> Not really, features freeze means features free, not less not much. We >> can't keep adding things endlessly and expect a release in a >> foreseeable period. > > You seem not have misunderstood me, I was talking about 5.5.1, i.e. pos

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Dmitry Stogov
Hi Nikita, The patch looks quite good. However, it must slow down each comparison operator (even if it compares two integers). I would suggest overloading of CMP operator instead of separate <, <=, ==, !=, >, >=. Also it may make sense to think about overloading of unary operators to provide a s

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_spki_

2013-05-12 Thread Stas Malyshev
Hi! > Not really, features freeze means features free, not less not much. We > can't keep adding things endlessly and expect a release in a > foreseeable period. You seem not have misunderstood me, I was talking about 5.5.1, i.e. post 5.5.0 release. > Those with interest to have them in PECL. It

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Sara Golemon
> > > Why would this be confusing? I'd agree if this happened in userland > (people > > could wonder why the operators are swapped), but internally we are > already > > dealing with this anyway. E.g. when you implement compare_objects you > have > > to be aware of this (to understand stuff like the

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Stas Malyshev
Hi! > Why would this be confusing? I'd agree if this happened in userland (people > could wonder why the operators are swapped), but internally we are already > dealing with this anyway. E.g. when you implement compare_objects you have > to be aware of this (to understand stuff like the return 1 t

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Nikita Popov
On Sun, May 12, 2013 at 9:57 PM, Sara Golemon wrote: > Are we ignoring the ZEND_IS_SMALLER issue? > Not ignoring it :) It's mentioned in one sentence: "The operators >, >=, [...] are indirectly supported by the following compiler transformations: [...]" if ($gmp > 123) { ... } > > There's no ZEN

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Sara Golemon
Are we ignoring the ZEND_IS_SMALLER issue? if ($gmp > 123) { ... } There's no ZEND_IS_GREATER opcode, so it gets quietly turned into: if (123 < $gmp) { ... } Which will be confusing. I dealt with this in operator by having the user apply a patch before building: https://github.com/php/pecl-php

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Nikita Popov
On Sun, May 12, 2013 at 9:02 PM, Nikita Popov wrote: > I think this is a misunderstanding. I do not suggest to use GMP for all > arithmetic and also do not suggest to auto-promote to GMP for large numbers. > > The operator overloading only comes into play if one of the operands is > already a GMP

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Nikita Popov
On Sun, May 12, 2013 at 7:50 PM, Antony Dovgal wrote: > On 2013-05-12 19:25, Nikita Popov wrote: > >> Hi internals! >> >> https://wiki.php.net/rfc/**operator_overloading_gmp >> >> This RFC proposes to add operator overloading for INTERNAL classes

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Pierre Joye
On Sun, May 12, 2013 at 7:50 PM, Antony Dovgal wrote: > On 2013-05-12 19:25, Nikita Popov wrote: >> >> Hi internals! >> >> https://wiki.php.net/rfc/operator_overloading_gmp >> >> This RFC proposes to add operator overloading for INTERNAL classes. >> Furthermore it exemplarily implements the new AP

Re: [PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Antony Dovgal
On 2013-05-12 19:25, Nikita Popov wrote: Hi internals! https://wiki.php.net/rfc/operator_overloading_gmp This RFC proposes to add operator overloading for INTERNAL classes. Furthermore it exemplarily implements the new API for GMP. IMO the proposal B is quite reasonable change, but the propos

[PHP-DEV] [RFC] Internal operator overloading and GMP improvements

2013-05-12 Thread Nikita Popov
Hi internals! https://wiki.php.net/rfc/operator_overloading_gmp This RFC proposes to add operator overloading for INTERNAL classes. Furthermore it exemplarily implements the new API for GMP. Thanks, Nikita

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Address feature request #38917 for native SPKAC (HTML5 keygen element) support: ext/openssl/openssl.c ext/openssl/php_openssl.h ext/openssl/tests/openssl_spki_

2013-05-12 Thread Pierre Joye
hi, On Sun, May 12, 2013 at 12:18 AM, Stas Malyshev wrote: > Hi! > >> I'd to disagree. Besides the lack of testing (openssl is stable, or do >> we begin to say feature a is not and feature b is beta but everything >> else is stable?), the nightmare about what is available in which >> version is r