Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Stas Malyshev
Hi! >> - Variables may be used as input to out/ref arguments. Properties >> may not. This will probably be true for properties too, in some cases. However, it is in no way an advantage. >> - Properties may throw exceptions - variables will never do that. In PHP, properties can not throw excepti

[PHP-DEV] Translating nNextFreeElement from user land

2012-04-24 Thread Yader Hernandez
Hello, Originally I was managing the indexes of an internal array I have. But I ran into issues when calling zend_hash_rehash so I started relying on nNextFreeElement from HashTable. If a user gives me 12 as their index they would like to look up, how would I translate that into the real value ne

Re: [PHP-DEV] Re: internals Digest 24 Apr 2012 22:20:08 -0000 Issue 2675

2012-04-24 Thread Anthony Ferrara
Rasmus: On Tue, Apr 24, 2012 at 10:01 PM, Rasmus Schultz wrote: > I agree, overloading isset() for properties is somewhat creepy - as > that would mean you can no longer rely on isset() to actually work the > way it works for any other value. I understand that's actually the > intent, but I think

[PHP-DEV] Re: internals Digest 24 Apr 2012 22:20:08 -0000 Issue 2675

2012-04-24 Thread Rasmus Schultz
I agree, overloading isset() for properties is somewhat creepy - as that would mean you can no longer rely on isset() to actually work the way it works for any other value. I understand that's actually the intent, but I think this would be confusing - isset() is supposed to behave a certain way dep

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Kris Craig
On Tue, Apr 24, 2012 at 5:54 PM, Tom Boutell wrote: > Please review the section titled "Inclusion of Mixed Code," which > contains the quoted conversation I referred to, with commentary about > "bad, lazy" architecture that is currently standard in numerous > frameworks. I understand that you fee

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Tom Boutell
Please review the section titled "Inclusion of Mixed Code," which contains the quoted conversation I referred to, with commentary about "bad, lazy" architecture that is currently standard in numerous frameworks. I understand that you feel that in future such frameworks will make a different set of

Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Philip Olson
On Apr 24, 2012, at 4:46 PM, Stas Malyshev wrote: > Hi! > >> The less people beginning to rely on this bug the better, and this is >> a critical time. The impact of this BC break feels larger considering >> MQ is enabled by default in PHP 5.3 and below. > > I understand but a) nobody should be

RE: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Clint Priest
That makes sense to me, a number (possibly all) of the errors I've added/modified could be eligible for this. In those cases it would do "the next best thing," such as ignore a setter definition, etc. I may not have a perfect understanding of what would leave the "engine in an unstable state

Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Stas Malyshev
Hi! > The less people beginning to rely on this bug the better, and this is > a critical time. The impact of this BC break feels larger considering > MQ is enabled by default in PHP 5.3 and below. I understand but a) nobody should be using magic quotes anyway and b) holding release for 5.4.1 bec

Re: [PHP-DEV] freeing zvals ref count

2012-04-24 Thread Etienne Kneuss
Hi, On Wed, Apr 25, 2012 at 01:25, Yader Hernandez wrote: > Hello, > > In the extension I'm currently working on, I call add_index_zval and on > success, I call Z_ADDREF_P on the new zval. > > When I'm freeing everything, I need to remove the ref count. Digging > through the source code, I found

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Kris Craig
On Tue, Apr 24, 2012 at 4:00 PM, Tjerk Meesters wrote: > > On 25 Apr, 2012, at 5:42 AM, Kris Craig wrote: > > > On Tue, Apr 24, 2012 at 1:10 PM, Tom Boutell wrote: > > > >> * The RFC starts off immediately talking about file extensions, but > >> the actual implementation proposed doesn't rely on

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Tjerk Meesters
On 25 Apr, 2012, at 5:42 AM, Kris Craig wrote: > On Tue, Apr 24, 2012 at 1:10 PM, Tom Boutell wrote: > >> * The RFC starts off immediately talking about file extensions, but >> the actual implementation proposed doesn't rely on file extensions or >> suggest any enforcement of them. That dispar

Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Philip Olson
On Apr 24, 2012, at 9:43 AM, Stas Malyshev wrote: > Hi! > >> https://bugs.php.net/61784 >> >> The get_magic_quotes_gpc() function returns 0/1 before 5.4, but now >> it returns boolean false. Instead it should return 0. Fixing this >> feels like a bug fix, which would go in 5.4.1. Thoughts? >

RE: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Clint Priest
Here is a copy of what Dennis had written to me regarding automatic implementations from C# (the model): > Originally, C# did not support automatically implemented properties. > There are several reasons why they were added. The first reason, is that > while the syntax for properties is the sa

RE: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Clint Priest
I will double-check (that it doesn't) but it should not per the spec, in the case of an interface this is not an automatic implementation but instead a 'must-have' declaration, which could later become an automatic implementation when defined within a class which implements that interface.

Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Ángel González
On 24/04/12 18:11, Paul Dragoonis wrote: > Happy to patch this once someone confirms this is a bug and not > "changed behaviour" in 5.4. > > - Paul. Why would such behavior change be desired? get_magic_quotes_gpc() is kept only for compatibility with scripts which did magic quote detection. As suc

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Kris Craig
2012/4/24 Tom Boutell > That's a good point, it should say the PHP tokenizer, or something to > that effect (folks who spend more time with the internals could say > better what to call it). > Hmm yeah I guess that wording is a bit sloppy, isn't it? I'm not sure what the "proper" terminology wo

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Kris Craig
On Tue, Apr 24, 2012 at 1:10 PM, Tom Boutell wrote: > * The RFC starts off immediately talking about file extensions, but > the actual implementation proposed doesn't rely on file extensions or > suggest any enforcement of them. That disparity should be addressed > for clarity. > Did you read th

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Tom Boutell
That's a good point, it should say the PHP tokenizer, or something to that effect (folks who spend more time with the internals could say better what to call it). The major difference from his previous version of the RFC is his addition of the .phpf format, which would allow including a .php file

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Arvids Godjuks
As far as I read there is no difference from the previous RFC - it says essentially the same. " The tag is reached, the webserver “switches back” and resumes parsing it as HTML. If no tags are given, the webserver will parse the file data as HTML code until a написал: > Hi all, > > I finally fou

Re: [PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Tom Boutell
* The RFC starts off immediately talking about file extensions, but the actual implementation proposed doesn't rely on file extensions or suggest any enforcement of them. That disparity should be addressed for clarity. * The RFC quotes an entire discussion with a lot of harsh language about coding

[PHP-DEV] [RFC] Pure PHP Scripts (Updated)

2012-04-24 Thread Kris Craig
Hi all, I finally found some time today to update the RFC based on discussions here. Please have a look and let me know if I missed anything or if there's anything else that needs clarifying: https://wiki.php.net/rfc/phpp I also want to know if this is sufficient to satisfy some of the concern

Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Stas Malyshev
Hi! > These would also include automatic implementations which call the > respective functions on the backing field. I could see only allowing > isset/unset automatic implementations if get/set were also specified > as automatic implementations. Another thing about that. The "automatic implement

Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Stas Malyshev
Hi! > public $dataArray { > > &get { return &$this->_dataArray; } This is not correct. Please read: http://php.net/manual/en/language.references.return.php > These would also include automatic implementations which call the > respective functions on the backing field. I could see only allowin

Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Stas Malyshev
Hi! > would it be possible to add a second shorthand syntax to the complete > automatic implementation? > > Examples: > > class TimePeriod > { > public $Hours {}; > public property $Hours; > public $Hours {property}; > } How it is different from just public $Hours and why one would

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Andrey Hristov
Hi, On 04/24/2012 03:32 PM, jpauli wrote: On Tue, Apr 24, 2012 at 2:34 PM, Ulf Wendel wrote: Am 24.04.2012 14:27, schrieb jpauli: I understand your thoughts, but I disagree as I think it would be much more clean to expose it via mysqlnd_***() API than through each MySQL ext (and for PDO that

Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Stas Malyshev
Hi! > https://bugs.php.net/61784 > > The get_magic_quotes_gpc() function returns 0/1 before 5.4, but now > it returns boolean false. Instead it should return 0. Fixing this > feels like a bug fix, which would go in 5.4.1. Thoughts? I do not see a reason to hold 5.4.1 for this. -- Stanisla

Re: [PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Paul Dragoonis
Happy to patch this once someone confirms this is a bug and not "changed behaviour" in 5.4. - Paul. On Tue, Apr 24, 2012 at 4:29 PM, Philip Olson wrote: > Hello everyone, > > The following bug report brings up a good point: > >  https://bugs.php.net/61784 > > The get_magic_quotes_gpc() function

Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Anthony Ferrara
Clint, Additionally, one more comment related to the read-only and write-only. I noticed that you're using E_ERROR for improper access. Obviously you don't want this to be a warning, as the execution shouldn't continue because that would be undefined. However, what about setting it to E_RECOVERA

[PHP-DEV] get_magic_quotes_gpc() returns false instead of 0

2012-04-24 Thread Philip Olson
Hello everyone, The following bug report brings up a good point: https://bugs.php.net/61784 The get_magic_quotes_gpc() function returns 0/1 before 5.4, but now it returns boolean false. Instead it should return 0. Fixing this feels like a bug fix, which would go in 5.4.1. Thoughts? Regards,

[PHP-DEV] display_errors=stderr is treated as display_errors=on

2012-04-24 Thread Franklin Tse
Hello, I have PHP 5.4.0 running on IIS 7.5, of which the stderrMode setting has been ReturnStdErrIn500. A 500 response is expected when display_errors is set to stderr. However, a 200 response with error message is returned and instead of stderr, on is displayed in phpinfo. A bug report was fi

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
2012/4/24 Johannes Schlüter : > On Tue, 2012-04-24 at 14:27 +0200, jpauli wrote: >> Aha, I like when an internals guy teach me internals stuff :) >> So, OK for 5.3 , what about supporting that for >=5.4 ? > > Maybe. ;-) I can start working on ideas/patches > >> > >> > The other reason is that one

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
On Tue, Apr 24, 2012 at 2:34 PM, Ulf Wendel wrote: > Am 24.04.2012 14:27, schrieb jpauli: > >> I understand your thoughts, but I disagree as I think it would be much >> more clean to expose it via mysqlnd_***() API than through each MySQL >> ext (and for PDO that would be even more dirty). That wo

Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Benjamin Eberlei
Hi! would it be possible to add a second shorthand syntax to the complete automatic implementation? Examples: class TimePeriod { public $Hours {}; public property $Hours; public $Hours {property}; } That could save quite some typing. Overall, i really like it. On Tue, Apr 24, 2012

Re: [PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Anthony Ferrara
Clint, Very nice job overall! Looking quite good. > Alternatively we could throw an error to a call on isset and/or unset > against a property which didn't define an implementation. I don't care for that concept much. All it's doing is trading one set of boilerplate for another. I'd prefer

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Johannes Schlüter
On Tue, 2012-04-24 at 14:27 +0200, jpauli wrote: > Aha, I like when an internals guy teach me internals stuff :) > So, OK for 5.3 , what about supporting that for >=5.4 ? Maybe. ;-) > > > > The other reason is that one idea for mysqlnd was that it doesn't expose > > anything to the userland while

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Ulf Wendel
Am 24.04.2012 14:27, schrieb jpauli: I understand your thoughts, but I disagree as I think it would be much more clean to expose it via mysqlnd_***() API than through each MySQL ext (and for PDO that would be even more dirty). That would as well add more and more #ifdef MYSQLND inside their sourc

[PHP-DEV] RFC: Property get/set syntax (added isset/unset and references)

2012-04-24 Thread Clint M Priest
I've updated the RFC to include details on adding isset/unset as well as references, detailed below: isset/unset: class TimePeriod { private $Seconds = 3600; public $Hours { get { return $this->Seconds / 3600; } set { $this->Seconds = $value; } isset { return !is

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
2012/4/24 Johannes Schlüter : > On Tue, 2012-04-24 at 13:35 +0200, jpauli wrote: >> - mysqli_get_client_stats() >> - mysqli_get_connection_stats() >> - mysqli_get_cache_stats() >> >> Those three functions are ext/mysqlnd related, they are #ifdef 'ed in >> the source code of ext/mysqli and not defin

Re: [PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread Johannes Schlüter
On Tue, 2012-04-24 at 13:35 +0200, jpauli wrote: > - mysqli_get_client_stats() > - mysqli_get_connection_stats() > - mysqli_get_cache_stats() > > Those three functions are ext/mysqlnd related, they are #ifdef 'ed in > the source code of ext/mysqli and not defined if ext/mysqli has been > compiled

[PHP-DEV] Expose mysqlnd API through all MySQL extensions

2012-04-24 Thread jpauli
Hi all, I'm actually putting my head into ext/mysqlnd and I noticed weird things about its API. As you should know, ext/mysqlnd is a replacement for libmysql, that is, all our 3 MySQL-related extensions may use it, and it is done by default for 5.4 branch. However, I've been surprised that ext/my

Re: [PHP-DEV] Fixing bug #18556 (was: Complete case-sensitivity in PHP)

2012-04-24 Thread Hartmut Holzgraefe
On 04/24/2012 01:06 AM, Galen Wright-Watson wrote: > http://svn.php.net/viewvc?view=revision&revision=128060, same author) then > changes zend_str_tolower to use tolower instead of its custom ASCII-based > conversion. The commit message is: "make this faster and sexier". Within > these revisions,

Re: [PHP-DEV] Fixing bug #18556 (was: Complete case-sensitivity in PHP)

2012-04-24 Thread Ferenc Kovacs
> > > ps: you had a few extra > at the end of the first lines of your sentences, > I experienced similar problems with gmail, the solution for me was to > always put an extra new line after the quoted text. > > what I meant is the beginning of the first line, not the end. -- Ferenc Kovács @Tyr43l

Re: [PHP-DEV] Fixing bug #18556 (was: Complete case-sensitivity in PHP)

2012-04-24 Thread Ferenc Kovacs
On Tue, Apr 24, 2012 at 1:06 AM, Galen Wright-Watson wrote: > On Mon, Apr 23, 2012 at 3:22 AM, C.Koy wrote: > > > On 4/22/2012 11:32 PM, Galen Wright-Watson wrote: > > > >> 2012/4/22 C.Koy > >> > >> On 4/21/2012 4:37 AM, Galen Wright-Watson wrote: > >>> > >> > >> But, I did not start this threa