Re: [PHP-DEV] Q: ZEND_HANDLE_STREAM and wincache extension on PHP 5.4

2012-03-20 Thread Dmitry Stogov
Hi Eric, Sorry, I don't read @internals every day. Please CC me if you need quick answer. Really I don't see the reason why wincache stores the PHP file source. Storing compiled opcodes must be enough. To avoid re-reading of already cached file. opcode cache should override zend_stream_open(

Re: [PHP-DEV] ECDSA support in the openssl extension

2012-03-20 Thread Alexey Shein
21 марта 2012 г. 3:34 пользователь Sergey Ryazanov написал: > Hello all. > > Openssl starting from version 0.9.8 supports the ECDSA signature > algorithm. Return value of the openssl_get_md_methods() also includes > "ecdsa-with-SHA1" string. But if I call openssl_sign() with EC key > then I have a

[PHP-DEV] Lots of people read this list. Please be courteous of their time. [was: Re: [PHP-DEV] Github Pull Request]

2012-03-20 Thread Sean Coates
> Thanks for the reminder! If it ever looks like I'm getting carried away > while standing up to these guys, please don't be afraid to let me know. I hate to even get involved in this thread, but [especially] now that the issue is resolved, could you please start replying to people in private in

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
Arpad, On Tue, Mar 20, 2012 at 6:23 PM, Arpad Ray wrote: > Hi Kris, > > On 20 Mar 2012 23:29, "Kris Craig" wrote: > > > > On Tue, Mar 20, 2012 at 4:08 PM, Ferenc Kovacs wrote: > > > > > >> But just because you and a few other stuffed shirts don't understand > the > > >> value of dissenting vie

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Arpad Ray
Hi Kris, On 20 Mar 2012 23:29, "Kris Craig" wrote: > > On Tue, Mar 20, 2012 at 4:08 PM, Ferenc Kovacs wrote: > > > >> But just because you and a few other stuffed shirts don't understand the > >> value of dissenting viewpoints, > > > > > > that's so nice of you > > > > You're welcome. > Your to

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
On Tue, Mar 20, 2012 at 4:08 PM, Ferenc Kovacs wrote: > >> The horse is already dead. Why are you still wacking it with a stick? >> > > that was my first and only reply to you about this issue, and this will be > my last one, I promise. > I was referring to you guys piling on as a group. Try n

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Ferenc Kovacs
> > > The horse is already dead. Why are you still wacking it with a stick? > that was my first and only reply to you about this issue, and this will be my last one, I promise. > Last time I checked, the PHP Group doesn't take orders from Github. we don't, my point was that if you really want

Re: [PHP-DEV] DOMDocument->saveXML with node parameter

2012-03-20 Thread Nicolai Scheer
Hi! On 20.03.2012 23:33, Gustavo Lopes wrote: > On Tue, 20 Mar 2012 23:27:50 +0100, Nicolai Scheer > wrote: > >> >> > $doc = new DOMDocument(); >> $doc->loadHTML( 'Test' ); >> $body = $doc->getElementsByTagName( 'body' )->item( 0 ); >> echo $doc->saveHTML( $body ); >> >> If I compile 5.3.10 myse

[PHP-DEV] ECDSA support in the openssl extension

2012-03-20 Thread Sergey Ryazanov
Hello all. Openssl starting from version 0.9.8 supports the ECDSA signature algorithm. Return value of the openssl_get_md_methods() also includes "ecdsa-with-SHA1" string. But if I call openssl_sign() with EC key then I have an error: "key type not supported in this PHP build!". After some time o

Re: [PHP-DEV] DOMDocument->saveXML with node parameter

2012-03-20 Thread Gustavo Lopes
On Tue, 20 Mar 2012 23:27:50 +0100, Nicolai Scheer wrote: loadHTML( 'Test' ); $body = $doc->getElementsByTagName( 'body' )->item( 0 ); echo $doc->saveHTML( $body ); If I compile 5.3.10 myself (RHEL 5.7), I get the very same behaviour as described in the last comment of bug 39771: "PHP Warn

[PHP-DEV] DOMDocument->saveXML with node parameter

2012-03-20 Thread Nicolai Scheer
Hi! Just stumbled upon the issue described in https://bugs.php.net/bug.php?id=39771 during a Windows -> Linux migration. The windows binaries for php 5.3.10 and 5.4 got no problems executing the following: loadHTML( 'Test' ); $body = $doc->getElementsByTagName( 'body' )->item( 0 ); echo $doc->

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
On Tue, Mar 20, 2012 at 3:04 PM, Ferenc Kovacs wrote: > > > On Tue, Mar 20, 2012 at 9:14 PM, Kris Craig wrote: > >> On Tue, Mar 20, 2012 at 12:56 PM, Stas Malyshev > >wrote: >> >> > Hi! >> > >> > > Yeah I know. That doesn't mean I have to like it though lol. ;P >> > >> > You may like it or not

Re: [PHP-DEV] php-src is now on git

2012-03-20 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/20/2012 09:48 PM, Ángel González wrote: > El 19/03/12 21:29, David Soria Parra escribió: >> On 2012-03-19, Kris Craig wrote: >>> The workflow page currently recommends the "git:" one for >>> cloning (which doesn't work for me, either). >> git://

Re: [PHP-DEV] php-src is now on git

2012-03-20 Thread Ángel González
El 19/03/12 21:29, David Soria Parra escribió: > On 2012-03-19, Kris Craig wrote: >> The workflow page currently recommends the "git:" one for cloning (which >> doesn't work for me, either). > git:// is recommended when you can use it. The access is limited due to > port limiations, but the protoc

Re: [PHP-DEV] php-src is now on git

2012-03-20 Thread Ángel González
El 20/03/12 21:45, David Soria Parra escribió: > On 03/20/2012 09:48 PM, Ángel González wrote: > > El 19/03/12 21:29, David Soria Parra escribió: > >> On 2012-03-19, Kris Craig wrote: > >>> The workflow page currently recommends the "git:" one for > >>> cloning (which doesn't work for me, either).

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Ferenc Kovacs
On Tue, Mar 20, 2012 at 9:14 PM, Kris Craig wrote: > On Tue, Mar 20, 2012 at 12:56 PM, Stas Malyshev >wrote: > > > Hi! > > > > > Yeah I know. That doesn't mean I have to like it though lol. ;P > > > > You may like it or not like it, but it's established terminology so > > we're going to use it

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Matthew Weier O'Phinney
On 2012-03-20, Kris Craig wrote: > --f46d043892b5d6413304bbb15eed > Content-Type: text/plain; charset=ISO-8859-1 > > On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 03/20/2012 06:29 PM, Kris Craig wrote: > > > Quick cla

Re: [PHP-DEV] Fixing a bug : a personal report

2012-03-20 Thread Barbu Paul Gheorghe
On 03/20/2012 02:43 PM, François Gannaz wrote: Hi I wrote a report of my first dive into php-src in an attempt to fix a bug. https://github.com/mytskine/php-src/wiki/bug40531-mbsubstr Hi. I must admit that I haven't read the whole article, but I read that you used ack to search through co

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
On Tue, Mar 20, 2012 at 12:56 PM, Stas Malyshev wrote: > Hi! > > > Yeah I know. That doesn't mean I have to like it though lol. ;P > > You may like it or not like it, but it's established terminology so > we're going to use it. Let's not add noise to our lists. > -- > Stanislav Malyshev, Softwar

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Stas Malyshev
Hi! > Yeah I know. That doesn't mean I have to like it though lol. ;P You may like it or not like it, but it's established terminology so we're going to use it. Let's not add noise to our lists. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227

Re: [PHP-DEV] [PATCH] readline extension bug fixes and enhancements

2012-03-20 Thread Johannes Schlüter
Hi, On Tue, 2012-03-20 at 21:06 +0200, Osama Abu Elsorour wrote: > All, > > I was recently involved in a project that relied heavily on readline > to provide console text input capabilities. However I soon noticed > that the current readline extension has a serious bug and is lacking > some impor

[PHP-DEV] [PATCH] Meaningful data type for _parameter_reference's "required" field

2012-03-20 Thread Barbu Paul Gheorghe
Hello. I submitted a patch for PHP-5.4, you can check it here: https://github.com/php/php-src/pull/15 It's about removing some redundacy in the reflection extension on ReflectionParameter by changing _parameter_reference's required field data type. -- Barbu Paul - Gheorghe Common sense is no

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
Yeah I know. That doesn't mean I have to like it though lol. ;P --Kris On Tue, Mar 20, 2012 at 12:11 PM, Hugo Peixoto wrote: > Kris, > > "Pull request" is a generally accepted term, specially when it comes to > github: http://help.github.com/send-pull-requests/ > > Hugo Peixoto > -- > > websi

Re: [PHP-DEV] [PATCH] readline extension bug fixes and enhancements

2012-03-20 Thread Christopher Jones
On 03/20/2012 12:06 PM, Osama Abu Elsorour wrote: All, I was recently involved in a project that relied heavily on readline to provide console text input capabilities. However I soon noticed that the current readline extension has a serious bug and is lacking some important functionality.

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Hugo Peixoto
Kris, "Pull request" is a generally accepted term, specially when it comes to github: http://help.github.com/send-pull-requests/ Hugo Peixoto -- website: http://hugopeixoto.net On Tue, Mar 20, 2012 at 7:06 PM, Kris Craig wrote: > On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra > wrote:

[PHP-DEV] [PATCH] readline extension bug fixes and enhancements

2012-03-20 Thread Osama Abu Elsorour
All, I was recently involved in a project that relied heavily on readline to provide console text input capabilities. However I soon noticed that the current readline extension has a serious bug and is lacking some important functionality. This patch applies only to PHP compiled with libreadli

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/20/2012 06:29 PM, Kris Craig wrote: > > Quick clarification: On the other hand, by "pull request" are you > > simply referring to somebody else requesting that you "pull" their >

Re: [PHP-DEV] Fixing a bug : a personal report

2012-03-20 Thread Adam Jon Richardson
2012/3/20 François Gannaz > Hi > > I wrote a report of my first dive into php-src in an attempt to fix a bug. > https://github.com/mytskine/php-src/wiki/bug40531-mbsubstr > I tried to detail everything as a personal memo, then for a friend of mine, > and now I've put it into a github wiki page.

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Kris Craig
Quick clarification: On Tue, Mar 20, 2012 at 7:11 AM, Paul Dragoonis wrote: > thanks dsp and johannes for this nice tool. > > On Tue, Mar 20, 2012 at 10:16 AM, David Soria Parra wrote: > > Hi > > > > with the php-src migrated to git we start receiving > > pull request on github. A few things to

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/20/2012 06:29 PM, Kris Craig wrote: > Quick clarification: On the other hand, by "pull request" are you > simply referring to somebody else requesting that you "pull" their > submission and merge/push it? If so, I get it, but I really think > we

Re: [PHP-DEV] Fixing a bug : a personal report

2012-03-20 Thread Christopher Jones
On 03/20/2012 05:43 AM, François Gannaz wrote: Hi I wrote a report of my first dive into php-src in an attempt to fix a bug. https://github.com/mytskine/php-src/wiki/bug40531-mbsubstr I tried to detail everything as a personal memo, then for a friend of mine, and now I've put it into a gith

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Paul Dragoonis
thanks dsp and johannes for this nice tool. On Tue, Mar 20, 2012 at 10:16 AM, David Soria Parra wrote: > Hi > > with the php-src migrated to git we start receiving > pull request on github. A few things to notice: > >  - developers can pull the requests as described here: >    https://wiki.php.ne

[PHP-DEV] Fixing a bug : a personal report

2012-03-20 Thread François Gannaz
Hi I wrote a report of my first dive into php-src in an attempt to fix a bug. https://github.com/mytskine/php-src/wiki/bug40531-mbsubstr I tried to detail everything as a personal memo, then for a friend of mine, and now I've put it into a github wiki page. I wonder if it can be useful to anyon

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/20/2012 11:42 AM, Ferenc Kovacs wrote: > I think it would be a good idea to explain why are we (not) doing > that. AFAIR the reason is that if we hand out accounts on github, > and somebody by mistake merges the pull request there (instead of > p

Re: [PHP-DEV] Github Pull Request

2012-03-20 Thread Ferenc Kovacs
> > > Note that we DONT hand out access to the > github repository and will we not add > you to the PHP organization on github. > I think it would be a good idea to explain why are we (not) doing that. AFAIR the reason is that if we hand out accounts on github, and somebody by mistake merges the p

[PHP-DEV] Github Pull Request

2012-03-20 Thread David Soria Parra
Hi with the php-src migrated to git we start receiving pull request on github. A few things to notice: - developers can pull the requests as described here: https://wiki.php.net/vcs/gitfaq#github_pull_requests - people with valid github accounts can comment on pull request - people