On 2012-03-20, Kris Craig <kris.cr...@gmail.com> wrote: > --f46d043892b5d6413304bbb15eed > Content-Type: text/plain; charset=ISO-8859-1 > > On Tue, Mar 20, 2012 at 10:34 AM, David Soria Parra <dso...@gmx.net> wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On 03/20/2012 06:29 PM, Kris Craig wrote: > > > Quick clarification: On the other hand, by "pull request" are you > > > simply referring to somebody else requesting that you "pull" their > > > submission and merge/push it? If so, I get it, but I really think > > > we should come up with another term to describe it because it > > > really does sound kinda backwards IMHO. I just woke up less than > > > an hour ago though so maybe I'm just groggy lol.... > > > > Drink a coffee wake up, think first and write the mail then and help > > reducing mailinglist noise by trying to figure it out yourself. > > > > We are referring to pull requests in the sense of pulling stuff from > > another repository into ours. We talk about pull requests made on > > github for the php/php-src repository. We use pull request the same > > way everyone else uses. Someone requests via github or a pull request > > mail (linux style) to pull his changes and merge them into our repository. > > Yeah I get that. It just feels imprecise to me. Wouldn't "external merge > request" be more descriptive? Generally, a pull request refers to a pull > from a remote repository. While that's an initial component of this, the > fact that it ends with a push request just makes the terminology needlessly > confusing IMHO. But if nobody else is bothered by it then I guess I'll > just have to suck it up lol.
This is how the general population of git users understands it; I don't see any reason to introduce additional terminology. -- Matthew Weier O'Phinney Project Lead | matt...@zend.com Zend Framework | http://framework.zend.com/ PGP key: http://framework.zend.com/zf-matthew-pgp-key.asc -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
