Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread guilhermebla...@gmail.com
hi Will, That's what I've been thinking about. I have a special necessity to overload a class in a Proxy implementation (an instance that wraps a real Entity), demanding the load when any getter is active. This implementation seems to fit perfectly my needs, while still be cleaning. I wonder if

[PHP-DEV] Accessors v2.2 Patch

2011-12-11 Thread Clint M Priest
https://bugs.php.net/patch-display.php?bug=49526&patch=v2.2&revision=1323662103 This one addresses the read-only, write-only aspects. Though they are not quite what the RFC specifies... class TimePeriod { public $Hours { get { return 5; } } } $o = new TimePeriod(); $o->Hours = 4;

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Will Fitch
This approach, in theory, is an interceptor itself. Most use-cases around this approach will be changing or augmenting an existing property that is not public. If you wanted to modify this interception, you'd need to extend the class using it and redefine the getter and/or setter. On Dec

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread guilhermebla...@gmail.com
I have just one question, partially unrelated. How can I make something similar to Interceptors of Java according to your approach? For those that have no idea, interceptors is a way to intercept get/set of a property inside the class and act under this circumstance. []s, On Sun, Dec 11, 2011 at

Re: [PHP-DEV] [RFC] Const array/string dereference

2011-12-11 Thread Laruence
Hi: reminding for discussion :) thanks On Wed, Nov 30, 2011 at 5:49 PM, Laruence wrote: > Hi peter: > > On Wed, Nov 30, 2011 at 5:23 PM, Peter Cowburn wrote: >> Hi Laruence et al. >> >> On 30 November 2011 06:06, Laruence wrote: >>> Hi: >>> >>>   base on feature request: https://bugs.php.ne

RE: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
To be complete I should probably add something to the reflection system as well. At present the getters/setters would show up as functions. What would be preferable? 1) Show up as regular functions and let users fend for themselves? 2) Hide from getMethods() and: 2.1) Provide getAccessors() -

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Pierre Joye
oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest wrote: > There are already two tests against private read and private write, should I > add two for protected as well? Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www

RE: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
There are already two tests against private read and private write, should I add two for protected as well? -Original Message- From: Pierre Joye [mailto:pierre@gmail.com] Sent: Sunday, December 11, 2011 6:36 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Acc

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Pierre Joye
Hi Clint, Thanks for the updated patch :) Some suggestions (did not test it yet only review it), - add test cases for non public property (private, protected) - show examples of the concept of readonly property (as it is allowed in the C# equivalent I would also suggest to either take over the

RE: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
https://bugs.php.net/patch-display.php?bug_id=49526&patch=v2.1&revision=latest Alright, nevermind on the failing tests, figured that out. I didn't realize the test structure doesn't indicate that it was segfaulting, that fixed all of the failing tests. So... I guess this patch is up for discu

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Will Fitch
Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug statements (e.g. printf). Sent from my iPhone On Dec 11, 2011, at 2:27 PM, Clint M Priest wrote: > https://bugs.php.net/patch-display.php?bug_id=49526&patch=accessor_v2.diff&r

[PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
https://bugs.php.net/patch-display.php?bug_id=49526&patch=accessor_v2.diff&revision=latest I rewrote part of how it handles the job due to abysmal performance of version 1. This one is near the same performance as without the code changes using __get() and is actually faster in some cases (publ

Re: [PHP-DEV] Local time zone

2011-12-11 Thread Pierre Joye
hi, On Sun, Dec 11, 2011 at 1:59 AM, Oleg Oshmyan wrote: > I am willing to work on patches but I suppose some consensus should be > reached first. The consensus was that you have to set a valid default timezone in php.ini Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.l

Re: [PHP-DEV] SVN Account Request: jbondc

2011-12-11 Thread Hannes Magnusson
Can anyone verify this request? -Hannes On Mon, Nov 7, 2011 at 20:23, Jonathan Bond-Caron wrote: > Bring improvements to serialize() and unserialize() -- a consistent > serialize_text() which does change based on config + no more NULL bytes. > > Possible improvements to PDO and stream related e

Re: [PHP-DEV] commit rights for NEWS

2011-12-11 Thread Hannes Magnusson
On Sat, Dec 10, 2011 at 23:18, marius adrian popa wrote: > svn commit NEWS  -m "bug fixed #48877 - bindValue and bindParam do not > work for PDO Firebird" > WARNING: gnome-keyring:: no socket to connect to > Sending        NEWS > Transmitting file data .svn: Commit failed (details follow): > svn: