https://bugs.php.net/patch-display.php?bug_id=49526&patch=accessor_v2.diff&revision=latest
I rewrote part of how it handles the job due to abysmal performance of version 1. This one is near the same performance as without the code changes using __get() and is actually faster in some cases (public getter). I also checked all the tests and fixed the issues I found related. There is however some strange behavior that I do not understand. For some reason if I run all of the tests, 100+ or so will fail. If I have the test script write those failed tests to a file and just run those tests, all but four work fine. It appears to be something to do with line endings, in other cases the output does not match expected because of the addition of 'unicode' to the output. I've no idea what's going on here but after 3 days of mucking around, I can't find a solution as to why this is occurring. These failures do not occur on a fresh checkout but nothing I've changed should be causing any of the issues, just no idea here, any help would be appreciated. Felipe: I could not find any segmentation fault tests from before when you posted, nor now. Are you still seeing segmentation faults? Thoughts? -Clint
