[PHP-DEV] Re: [patch] export zend_on_timeout()

2011-11-21 Thread Stas Malyshev
Hi! I'd like to commit a one-liner to 5_4/trunk if there are no objections. See it in the attachment. Stas, do you mind if I commit it to 5_4 now? I think it's ok. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] pg_escape_literal(), pg_escape_identifier() patch

2011-11-21 Thread Yasuo Ohgaki
Hi all, I've posted pgsql patch that adds pg_escape_literal()/pg_escape_identifier() which escapes SQL literal and idetifier. (i.e. table names, filed names, etc) https://gist.github.com/1381181 When I post a patch while ago, someone mentioned about that pgsql module own escape implementation ma

[PHP-DEV] [patch] export zend_on_timeout()

2011-11-21 Thread Antony Dovgal
Hello all. I'd like to commit a one-liner to 5_4/trunk if there are no objections. See it in the attachment. Stas, do you mind if I commit it to 5_4 now? -- Wbr, Antony Dovgal --- http://pinba.org - realtime profiling for PHP Index: Zend/zend.h ==

[PHP-DEV] Supprting static getter/setter

2011-11-21 Thread Clint M Priest
I've implemented a good majority of the getter/setter syntax for objects which was pretty easy due to the already implemented functionality of __get()/__set(). For static getters/setters there is no such obvious place to hook the new functionality, I was considering modifying the ZEND_ASSIGN opc

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Gustavo Lopes
Em Mon, 21 Nov 2011 12:42:08 -, Hannes Magnusson escreveu: On Mon, Nov 21, 2011 at 13:35, Ferenc Kovacs wrote: * Add a second new parameter, by reference, wherein this extra information is written. * Instead of returning a string, return an array with all the new information. Fr

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Hannes Magnusson
On Mon, Nov 21, 2011 at 13:35, Ferenc Kovacs wrote: >> >> However there's a little problem. The new interface reports errors via the >> usual ICU mechanism AND it also uses a new structure to pass IDNA specific >> errors. Also, it reports whether the use of the transitional mechanism >> affects th

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Ferenc Kovacs
> > However there's a little problem. The new interface reports errors via the > usual ICU mechanism AND it also uses a new structure to pass IDNA specific > errors. Also, it reports whether the use of the transitional mechanism > affects the result. So I see only two solutions so that that extra >

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Pierre Joye
hi, After a short talk on IRC, we agreed to go with the solution 1. David, Stas, any objection for 5.4? As it adds a new feature it is actually a bug fix too. Cheers, On Mon, Nov 21, 2011 at 11:46 AM, Pierre Joye wrote: > Hi Gustavo! > > Thanks for the quick action :) > > I prefer however the

Re: [PHP-DEV] Curl extension

2011-11-21 Thread Pierre Joye
Hi Pierrick! Yes it us still maintained however it is hard to keep adding every new features. They are quite active :) As of 5.4 it is now in RC phase. Please add new features in trunk for now. Thanks! On Nov 21, 2011 1:19 AM, "Pierrick Charron" wrote: > Hi all, > > I started today to play wi

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Pierre Joye
Hi Gustavo! Thanks for the quick action :) I prefer however the 1st solution so that the code using the function can use transparently the returned value. At some point we may add classes as well, for those interested in more details. Cheers, On Nov 21, 2011 4:53 AM, "Gustavo Lopes" wrote: >

Re: [PHP-DEV] Curl extension

2011-11-21 Thread Kalle Sommer Nielsen
2011/11/21 Yasuo Ohgaki : > I'm also holding pgsql patch that adds pg_escape_literal() which > escapes SQL literal. (i.e. table names, filed names, etc) By making a separate topic instead of cluttering it into this one, alternatively open a report at bugs.php.net -- regards, Kalle Sommer Nielse

Re: [PHP-DEV] datetime status

2011-11-21 Thread Stas Malyshev
Hi! For fixing the TLA / Zone Type 2 bugs, focus on the following tests: bug55253.phpt rfc-datetime_and_daylight_saving_time-type2.phpt Those are exactly the two xfails fixed by my patch. DateTime_*-type2-type2.phpt These aren't fixed but it may be related to the f

Re: [PHP-DEV] datetime status

2011-11-21 Thread Derick Rethans
On Mon, 21 Nov 2011, Stas Malyshev wrote: > > That is incorrect, not every timezone DST change is 60 minutes. > > The I would guess this code in do_adjust_timezone() also wrong: > > case TIMELIB_ZONETYPE_ABBR: { > timelib_sll tmp; > > tz

Re: [PHP-DEV] datetime status

2011-11-21 Thread Stas Malyshev
Hi! That is incorrect, not every timezone DST change is 60 minutes. The I would guess this code in do_adjust_timezone() also wrong: case TIMELIB_ZONETYPE_ABBR: { timelib_sll tmp; tz->is_localtime = 1; tmp

Re: [PHP-DEV] datetime status

2011-11-21 Thread Derick Rethans
On Sun, 20 Nov 2011, Stas Malyshev wrote: > We're in RC now, and I'm very concerned about the status of DateTime > functionality (see bugs 60236, 60237 and XFAILs) - I've reported these > problems in June, but not much happened since then. I'm trying to > figure out what's going on there, but I

Re: [PHP-DEV] datetime status

2011-11-21 Thread Derick Rethans
On Sun, 20 Nov 2011, Stas Malyshev wrote: > If it is the former, the patch seems to be pretty simple: > > --- lib/unixtime2tm.c (revision 319533) > +++ lib/unixtime2tm.c (working copy) > @@ -146,7 +146,7 @@ > int z = tm->z; > signed int dst = tm->dst; >

Re: [PHP-DEV] New dereferencing syntaxes in 5.4

2011-11-21 Thread Александр Москалёв
Amateurish question to internals: Why can not we do more general cases? For example (expr)[3]; (expr)->foo->bar; (expr)()->baz[3]()->makeSomething()[4] = 16; etc. Now we have (new some)->something; and doSomething()[12], but why only this cases? Big trouble in parser to do this? Can someone help