Em Mon, 21 Nov 2011 12:42:08 -0000, Hannes Magnusson
<hannes.magnus...@gmail.com> escreveu:
On Mon, Nov 21, 2011 at 13:35, Ferenc Kovacs <tyr...@gmail.com> wrote:
* Add a second new parameter, by reference, wherein this extra
information is written.
* Instead of returning a string, return an array with all the new
information.
From what I can understand, if we go with option 1, then this patch
would preserve BC, as it would only introduce additional arguments for
the
existing method.
Did you checked that the tests are still passing with this patch? Could
you also create a couple of tests covering the new behavior?
Both options would preserve BC. I still haven't run or create new tests,
but rest assured I will.
..And it bumps the minimal required ICU dependency, right?
Yes. Obviously, this must be ifdef'd (and already is in the patch).
--
Gustavo Lopes
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
