[PHP-DEV] simplexml inconsistencies in the last few releases (the same issue already discussed)

2011-08-31 Thread Christian Stocker
Hi It's about the two tests in http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/simplexml/tests/008.phpt and http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/simplexml/tests/bug48601.phpt which contractited themself and we had back and forth commits due to this. So we had th

[PHP-DEV] 2 new test failures

2011-08-31 Thread Rasmus Lerdorf
Pierre, your changes today caused 2 new test failures: Bug #51709 (Can't use keywords as method names) [tests/basic/bug51709_1.phpt] Bug #51709 (Can't use keywords as method names) [tests/basic/bug51709_2.phpt] The diffs: 001+ Parse error: syntax error, unexpected 'for' (T_FOR), expecting identi

[PHP-DEV] 5.4 beta postponing

2011-08-31 Thread Stas Malyshev
Hi! I see we're making good progress on unit tests fails, though a bunch still remains. So in case somebody didn't read the discussion - I'm moving beta target to next week, September 8, in hope we'll have 0 unit test fails by then. Thanks for everybody contributing to fixing the tests and k

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Johannes Schlüter
On Wed, 2011-08-31 at 10:42 -0400, Matthew Weier O'Phinney wrote: > On 2011-08-31, Rasmus Lerdorf wrote: > > I am down to 34 test failures compiling against mysqlnd instead of libmysql > > > > http://codepad.org/ZV8imUuc > > > > I did have to set MYSQL_TEST_SOCKET=/var/run/mysqld/mysqld.sock in my

Re: [PHP-DEV] Latest Revsion to PDO_MySQL

2011-08-31 Thread Johannes Schlüter
On Wed, 2011-08-31 at 16:54 +0100, Keloran wrote: > http://svn.php.net/viewvc?view=revision&sortby=date&revision=315905 > > shouldnt the php pages for this, really use preg instead of ereg, Well it's a utility for maintainers, no page or something, run every few years. Yes using preg might be bet

[PHP-DEV] Latest Revsion to PDO_MySQL

2011-08-31 Thread Keloran
http://svn.php.net/viewvc?view=revision&sortby=date&revision=315905 shouldnt the php pages for this, really use preg instead of ereg, just a wonder really

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/ext/standard/tests/strings/htmlentities15.phpt trunk/ext/standard/tests/strings/htmlentities15.phpt

2011-08-31 Thread Gustavo Lopes
On Wed, 31 Aug 2011 07:39:43 +0100, Stas Malyshev wrote: Hi! On 8/30/11 11:32 PM, Gustavo André dos Santos Lopes wrote: cataphract Wed, 31 Aug 2011 06:32:05 + Revision: http://svn.php.net/viewvc?view=revision&revision=315851 Log: - Fixed test htmlentities

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Matthew Weier O'Phinney
On 2011-08-31, Rasmus Lerdorf wrote: > I am down to 34 test failures compiling against mysqlnd instead of libmysql > > http://codepad.org/ZV8imUuc > > I did have to set MYSQL_TEST_SOCKET=/var/run/mysqld/mysqld.sock in my > environment though. It was defaulting to /tmp/mysql.sock I've noticed this

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Tjerk Meesters
On Aug 31, 2011 12:14 PM, "Rasmus Lerdorf" wrote: > > On 08/30/2011 08:39 PM, Stas Malyshev wrote: > > Hi! > > > > I've checked the unit tests on my Mac and I see 48 failures so far. I've > > put them here: > > https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x > > > > Most of them

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
On 31.08.11 13:32, Ilia Alshanetsky wrote: > Revert sounds find to me, the change was indeed to fix the test. Ok. Committed. JFTR, I also fixed the tests in xsl and libxml. They should pass now (at least on my machine they do :)) chregu > > On Wed, Aug 31, 2011 at 6:58 AM, Christian Stocker

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Rob Richards
On Aug 31, 2011, at 5:39 AM, Christian Stocker wrote: > > > On 31.08.11 09:47, Stas Malyshev wrote: >> Hi! >> >> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >> Ilia reverted the fix for bug #48601 with this: >> >> http://svn.php.net/viewvc/php/php-src/branches/PHP

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Ilia Alshanetsky
Revert sounds find to me, the change was indeed to fix the test. On Wed, Aug 31, 2011 at 6:58 AM, Christian Stocker wrote: > > > On 31.08.11 12:25, Laruence wrote: >> Hi: >>     I think you should not commit untill ask ilia for the reason of >> previous change, > > sure, but my guess is he just f

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
On 31.08.11 12:25, Laruence wrote: > Hi: > I think you should not commit untill ask ilia for the reason of > previous change, sure, but my guess is he just fixed the code to pass the test, but IMHO the test was wrong (and my patches fixes that). ilia? chregu > > thanks > > 2011/8/31 Chris

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Laruence
Hi: I think you should not commit untill ask ilia for the reason of previous change, thanks 2011/8/31 Christian Stocker : > Hi > > Here's my proposed patch > https://gist.github.com/1183212 > > If noone objects, I'll commit it soon > > chregu > > On 31.08.11 11:39, Christian Stocker wrote: >>

Re: [PHP-DEV] Cannot build ext/intl on Fedora 15

2011-08-31 Thread Ferenc Kovacs
On Wed, Aug 31, 2011 at 11:32 AM, Pierre Joye wrote: > you are the only one to actually experience this, so I suppose you are > the only who can fix it as well :) > from Gwynne: "This issue exists on Darwin (OS X) as well." this will also happen with debian wheezy(next stable version): http://wi

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
Hi Here's my proposed patch https://gist.github.com/1183212 If noone objects, I'll commit it soon chregu On 31.08.11 11:39, Christian Stocker wrote: > > > On 31.08.11 09:47, Stas Malyshev wrote: >> Hi! >> >> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >> Ilia reverte

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
On 31.08.11 09:47, Stas Malyshev wrote: > Hi! > > For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like > Ilia reverted the fix for bug #48601 with this: > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874 > > > I'm not sure

Re: [PHP-DEV] Cannot build ext/intl on Fedora 15

2011-08-31 Thread Pierre Joye
you are the only one to actually experience this, so I suppose you are the only who can fix it as well :) On Wed, Aug 31, 2011 at 11:18 AM, Sebastian Bergmann wrote: > On 08/27/2011 10:49 AM, Sebastian Bergmann wrote: >> >> /usr/bin/ld: ext/intl/msgformat/msgformat_helpers.o: >> undefined referen

Re: [PHP-DEV] Cannot build ext/intl on Fedora 15

2011-08-31 Thread Sebastian Bergmann
On 08/27/2011 10:49 AM, Sebastian Bergmann wrote: /usr/bin/ld: ext/intl/msgformat/msgformat_helpers.o: undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3' /usr/bin/ld: note: '__gxx_personality_v0@@CXXABI_1.3' is defined in DSO /usr/lib64/libstdc++.so.6 so try adding it to the linker

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Stas Malyshev
Hi! For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like Ilia reverted the fix for bug #48601 with this: http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874 I'm not sure what simplexml is supposed to return in each case, the t

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Laruence
Hi: it's odd that parse_ini_*.phpt failed in my built environ, but seems didn't fail in your list. so maybe my changes is not appropriate? thanks 2011/8/31 Stas Malyshev : > Hi! > > I've checked the unit tests on my Mac and I see 48 failures so far. I've put > them here: https://wiki.php