On Aug 31, 2011 12:14 PM, "Rasmus Lerdorf" <ras...@lerdorf.com> wrote: > > On 08/30/2011 08:39 PM, Stas Malyshev wrote: > > Hi! > > > > I've checked the unit tests on my Mac and I see 48 failures so far. I've > > put them here: > > https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x > > > > Most of them are mysql, but others too. > > So, is there anybody working or willing to work to fix them all for > > beta? Should we postpone the beta for a week to wait for that or it > > doesn't make difference? > > I say we postpone. We really need to get used to the fact that failing > tests matter and that they block releases. > > Why is your tests/func/005a.phpt failing? That seems to pass > consistently for most people. > > tests/lang/045.phpt is the one that fails for everyone because we don't > re-apply the timeout for a registered shutdown function. We should > either fix that or mark it as an XFAIL.
The timeout gets applied but the SIG_ALARM gets filtered by the signal handler because SIGG(running) is still true. Setting running to false inside zend_timeout before calling the other functions seems a (hack?) solution. > > The two openbasedir tests were broken by these commits: > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/tests/security/open_basedir_linkinfo.phpt?r1=311033&r2=311509 > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/tests/security/open_basedir_readlink.phpt?r1=311033&r2=311507 > > which you merged from trunk based on changes by jeraimee: > > http://svn.php.net/viewvc/php/php-src/trunk/tests/security/open_basedir_linkinfo.phpt?r1=296679&r2=311141 > > so we should figure out why that was changed. I don't think this > behaviour is difference between trunk and 5.4 so I don't understand the > change. > > ext/date/tests/bug33532.phpt doesn't fail for me. LOCALE differences? > What is your diff on that one? > > I'm not sure how we should attack it, but I think with a little bit of > discussion on each failing test we can plow through these pretty quickly. > > -Rasmus > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
