Re: [PHP-DEV] phpinfo html broken in 5.3.8!?

2011-08-22 Thread Adam Harvey
On 23 August 2011 15:16, Chad Emrys wrote: > I emailed here because I'm afraid no one will notice the bug in time for > this 5.3.8 release you may be releasing for the crypt() fix: I'm not sure I'd class this one as mission critical, but it's fixed, anyway. :) Adam -- PHP Internals - PHP Runti

[PHP-DEV] phpinfo html broken in 5.3.8!?

2011-08-22 Thread Chad Emrys
Just noticed this in ext/standard/info.c source line 629 629 PUTS("http://www.w3.org/1999/xhtml\";>>"); note the extra > at the end of the tag. I emailed here because I'm afraid no one will notice the bug in time for this 5.3.8 release you may be releasing for the crypt() fix: bug report

Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token

2011-08-22 Thread Xinchen Hui
Hi: I found this feature was decided to do in PHP 5.3 TODO list : http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/TODO?revision=242949&view=markup so I was wondering does this previous decision still shoudl be think as valid? hehe thanks 2011/7/7 Xinchen Hui : > Hi: > >   thanks

[PHP-DEV] Re: Doc #55472 [Ana->Asn]ip2long(integer) returns integer

2011-08-22 Thread Laruence
Hi: well, seems we need win32 engineer to have look at this issue, is there a chance that ip2long fall back to inet_addr() on windows? if there is, it should be a bug :) thanks 2011/8/22 : > laruence you have just been assigned to this bug by ka...@php.net > > Edit report at https:

Re: [PHP-DEV] 5.3.6-13 -> 5.3.7-1 test result diff

2011-08-22 Thread Daniel Convissor
Hi Stas: On Mon, Aug 22, 2011 at 03:31:56PM -0700, Stas Malyshev wrote: > > We still have tons of failures in DateTime IIRC and that's because > of the buggy three-letter timezones. There are bugs with both type 1 (regularly created datetimes) and type 2 (datetimes created using three letter tim

Re: [PHP-DEV] Activation of IGBinary serialization extension in 5.4 by default

2011-08-22 Thread David Muir
The gain is that those without the extension can still unserialize the data and read it. It solves the problem discussed where older versions of PHP without IGBinary built in would be locked out from being able to unserialise data. Didn't realise the reply was private. I did a reply-to-list, but T

Re: [PHP-DEV] Choosing a distributed version control system for PHP - problems

2011-08-22 Thread David Muir
On 22/08/11 17:44, Lester Caine wrote: > Lester Caine wrote: >> Just for the record ... the libreoffice clone I started 9 hours ago is >> still going strong, and I'm estimating that it will finish some time >> tomorrow afternoon, another 20 hours or so. A single huge repo is going >> to take time t

Re: [PHP-DEV] 5.3.6-13 -> 5.3.7-1 test result diff

2011-08-22 Thread Stas Malyshev
Hi! On 8/22/11 3:27 PM, Pierre Joye wrote: hi Ondrej! As far I remember, Daniel fixed some of the (numerous) failing datetime tests. Can you try to give it a run using current 5.3 branche pls? We still have tons of failures in DateTime IIRC and that's because of the buggy three-letter timezo

Re: [PHP-DEV] 5.3.6-13 -> 5.3.7-1 test result diff

2011-08-22 Thread Pierre Joye
hi Ondrej! As far I remember, Daniel fixed some of the (numerous) failing datetime tests. Can you try to give it a run using current 5.3 branche pls? On Tue, Aug 23, 2011 at 12:21 AM, Ondřej Surý wrote: > This is stripped down bug list diff (only + or - lines included) > between *Debian* 5.3.6-1

[PHP-DEV] 5.3.6-13 -> 5.3.7-1 test result diff

2011-08-22 Thread Ondřej Surý
This is stripped down bug list diff (only + or - lines included) between *Debian* 5.3.6-13 and 5.3.7-1 (almost same patch list, removed patches were merged upstream). Ideally the FAILED test list should be empty, so we (the packagers) would know that we created the regression in the distribution, w

Re: [PHP-DEV] Use system crypt() when possible

2011-08-22 Thread Pierre Joye
hi, On Mon, Aug 22, 2011 at 9:51 PM, Ondřej Surý wrote: > Hi, > > I wrote this patch sometime ago and Debian package uses it: > > https://bugs.php.net/bug.php?id=51254 > > which in turn made Debian packages not-vulnerable to #55439. That's a bit easy to come up with that, I don't think either

[PHP-DEV] Use system crypt() when possible

2011-08-22 Thread Ondřej Surý
Hi, I wrote this patch sometime ago and Debian package uses it: https://bugs.php.net/bug.php?id=51254 which in turn made Debian packages not-vulnerable to #55439. (But I have failed too, I should really start to check to output of the tests when building the package and compare them for any regr

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Stas Malyshev
Hi! On 8/21/11 11:22 PM, Mads Lie Jensen wrote: Ah, I now see that it only happens when trying to check something which is not actually an object: Not a bug. $var is interpreted as a class name. To know if one class extends another, the class in question (first one) should be loaded. There

[PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_4/NEWS branches/PHP_5_4/sapi/cli/php_cli_server.c trunk/NEWS trunk/sapi/cli/php_cli_server.c

2011-08-22 Thread Laruence
Hi: Added SERVER[SERVER_SOFTWARE], http://svn.php.net/viewvc?view=revision&revision=315300 but server_addr is a litte diffcult since there is no a ready value for that, needs a litte more works, I think we'd better not do that much changes for this, at least need the author to review, :) thank

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-08-22 Thread Solar Designer
On Mon, Aug 22, 2011 at 04:01:46PM +0200, Pierre Joye wrote: > On Mon, Aug 22, 2011 at 3:52 PM, Solar Designer wrote: > >> On Mon, Aug 22, 2011 at 3:05 PM, Pierre Joye wrote: > >> > it seems that the changes break BC too, pls see > >> > https://bugs.php.net/bug.php?id=55477 > > > > We may recomme

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-08-22 Thread Pierre Joye
On Mon, Aug 22, 2011 at 3:52 PM, Solar Designer wrote: > On Mon, Aug 22, 2011 at 03:19:53PM +0200, Ferenc Kovacs wrote: >> we expected this imo. >> http://www.mail-archive.com/internals@lists.php.net/msg51683.html >> http://www.mail-archive.com/internals@lists.php.net/msg51687.html > > Definitely.

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-08-22 Thread Solar Designer
On Mon, Aug 22, 2011 at 03:19:53PM +0200, Ferenc Kovacs wrote: > we expected this imo. > http://www.mail-archive.com/internals@lists.php.net/msg51683.html > http://www.mail-archive.com/internals@lists.php.net/msg51687.html Definitely. > On Mon, Aug 22, 2011 at 3:05 PM, Pierre Joye wrote: > > it

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Etienne Kneuss
The actual question is whether the "fix" makes sense or not in the first place. Please debate in the bug report directly to avoid a schizophrenic discussion. Best, On Mon, Aug 22, 2011 at 15:12, Ilia Alshanetsky wrote: > The fix looks good, Dmitry can you please review it, if it is good > let's

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-08-22 Thread Ferenc Kovacs
we expected this imo. http://www.mail-archive.com/internals@lists.php.net/msg51683.html http://www.mail-archive.com/internals@lists.php.net/msg51687.html On Mon, Aug 22, 2011 at 3:05 PM, Pierre Joye wrote: > hi, > > it seems that the changes break BC too, pls see > https://bugs.php.net/bug.php?i

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Ilia Alshanetsky
The fix looks good, Dmitry can you please review it, if it is good let's get it into 5.3.8 On Mon, Aug 22, 2011 at 6:33 AM, Kalle Sommer Nielsen wrote: > 2011/8/22 Mads Lie Jensen : >> On Mon, 22 Aug 2011 10:00:11 +0200, hannes.magnus...@gmail.com (Hannes >> Magnusson) wrote: >> >>>I can reproduc

Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk

2011-08-22 Thread Pierre Joye
hi, it seems that the changes break BC too, pls see https://bugs.php.net/bug.php?id=55477 Does that ring a bell to you? On Wed, Jul 20, 2011 at 1:44 AM, Solar Designer wrote: > Hi, > > These tests fail in trunk on my x86_64 build: > > crypt_sha256.phpt > crypt_variation1.phpt > > The difference

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Reindl Harald
Am 22.08.2011 13:08, schrieb Lester Caine: > Reindl Harald wrote: >> there should be placed diff-files for security fixes directly on the >> download-page >> they could be easily included in rpmbuild/spec-file if they are matching to >> the latest >> tar.bz2, but the current release process doe

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Lester Caine
Reindl Harald wrote: there should be placed diff-files for security fixes directly on the download-page they could be easily included in rpmbuild/spec-file if they are matching to the latest tar.bz2, but the current release process does not support this and forces users if they wanting their ma

Re: [PHP-DEV] php.exe crashes on infinite recursion (PHP 5.3.5)

2011-08-22 Thread Kalle Sommer Nielsen
2011/8/22 speedy : > Hello PHP dev crew, > >      The screenshot of the crash is in the attachment. > >      The problem is easily reproducible, just make a PHP function >      call itself. Infinite recursions have always crashed, while Dmitry patched some of those in the early 5.3 development it

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Kalle Sommer Nielsen
2011/8/22 Mads Lie Jensen : > On Mon, 22 Aug 2011 10:00:11 +0200, hannes.magnus...@gmail.com (Hannes > Magnusson) wrote: > >>I can reproduce that in 5.3-svn and 5.4-svn. >> >>Please file a bug report for it, this should probably be fixed in 5.3.8 too. > > Done: > > Bug #55475      is_a() triggers a

Re: [PHP-DEV] php.exe crashes on infinite recursion (PHP 5.3.5)

2011-08-22 Thread Ferenc Kovacs
On Mon, Aug 22, 2011 at 12:27 PM, speedy wrote: > Hello PHP dev crew, > >      The screenshot of the crash is in the attachment. > >      The problem is easily reproducible, just make a PHP function >      call itself. > >      I think the stack grows too big and the php interpreter crashes >    

[PHP-DEV] php.exe crashes on infinite recursion (PHP 5.3.5)

2011-08-22 Thread speedy
Hello PHP dev crew, The screenshot of the crash is in the attachment. The problem is easily reproducible, just make a PHP function call itself. I think the stack grows too big and the php interpreter crashes inside the MSVCRT.dll. Maybe it could be handled wi

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Pierre Joye
btw, pls commit to 5.3 after 5.3.8 (to be pkged today) On Mon, Aug 22, 2011 at 12:04 PM, Andrey Hristov wrote: >  Hi, > I have a fix, currently running the full test suite. Will commit soon. > > Best, > Andrey > > On 08/22/2011 11:56 AM, Pierre Joye wrote: >> >> it is attached to the bug :) >> >>

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Reindl Harald
Am 22.08.2011 11:33, schrieb Lester Caine: > Pierre Joye wrote: >> but does it work with 5.3.6? On the servers where 5.3.7 fails? > > While switching back should simply be a matter of telling the package manager > to use the older version with full disclosed security-bugs they are open and kno

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Andrey Hristov
Hi, I have a fix, currently running the full test suite. Will commit soon. Best, Andrey On 08/22/2011 11:56 AM, Pierre Joye wrote: it is attached to the bug :) On Mon, Aug 22, 2011 at 11:47 AM, Andrey Hristov wrote: Hi, On 08/22/2011 10:40 AM, Laruence wrote: georg, andery, ulf:

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Pierre Joye
it is attached to the bug :) On Mon, Aug 22, 2011 at 11:47 AM, Andrey Hristov wrote: >  Hi, > > On 08/22/2011 10:40 AM, Laruence wrote: >> >> georg, andery, ulf: >> >>     hello,  there is a bug in mysqlnd,  the details about this bug can >> be found at https://bugs.php.net/bug.php?id=55473 >> >>

Re: [PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Andrey Hristov
Hi, On 08/22/2011 10:40 AM, Laruence wrote: georg, andery, ulf: hello, there is a bug in mysqlnd, the details about this bug can be found at https://bugs.php.net/bug.php?id=55473 I found the reason is that mysqlnd_connect didn't free the stream when doing reconnect. I have s

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Lester Caine
Pierre Joye wrote: but does it work with 5.3.6? On the servers where 5.3.7 fails? While switching back should simply be a matter of telling the package manager to use the older version ... how many people actually get that process to work? Not a PHP problem, but one that affects most of us now

[PHP-DEV] Re: [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Laruence
Hi: and the reason for why this cleanup cound not be done in dtor, is that in dtor, it also clean the content, option, which should not free at that memont, alos IMO, that is not a dtor time in theory(reconnecting with a same mysql->conn). thanks 2011/8/22 Laruence : > georg, andery, u

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Reindl Harald
YES how often shoud i reapeat this? * < 5.3.6 since a year on several machines cronjobs connecting per WAN to mysql * update to 5.3.7 * it takes 30 minutes to get the first error-mails from cronjobs * it takes so long because they all run in a timeout * after an hour you have 50 instances of every

[PHP-DEV] [PATCH]mysql_pconnect leaks file descriptors on reconnect

2011-08-22 Thread Laruence
georg, andery, ulf: hello, there is a bug in mysqlnd, the details about this bug can be found at https://bugs.php.net/bug.php?id=55473 I found the reason is that mysqlnd_connect didn't free the stream when doing reconnect. I have submitted a patch for this, but I am not very sure

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Pierre Joye
but does it work with 5.3.6? On the servers where 5.3.7 fails? On Mon, Aug 22, 2011 at 10:26 AM, Reindl Harald wrote: > i can not easily replace files because rpmbuild does > unpack and patch the source automated and some patches > are needed since ages to get PHP even compiled on fedora > > Am 2

Re: [PHP-DEV] Failing Autotests / Bugs

2011-08-22 Thread Reindl Harald
i can not easily replace files because rpmbuild does unpack and patch the source automated and some patches are needed since ages to get PHP even compiled on fedora Am 22.08.2011 10:05, schrieb Andrey Hristov: > Hi guys, > what I observe is hanging on the client side with SSL. Pconn doesn't matte

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Etienne Kneuss
Hi, On Mon, Aug 22, 2011 at 08:22, Mads Lie Jensen wrote: > On Mon, 22 Aug 2011 08:10:28 +0200, ka...@php.net (Kalle Sommer Nielsen) > wrote: > >>> After upgrading to php 5.3.7, whenever I use is_a($object, 'ClassName'); >>> the autoloader of classes is now called. >>> >>> This did not happen in

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Mads Lie Jensen
On Mon, 22 Aug 2011 10:00:11 +0200, hannes.magnus...@gmail.com (Hannes Magnusson) wrote: >I can reproduce that in 5.3-svn and 5.4-svn. > >Please file a bug report for it, this should probably be fixed in 5.3.8 too. Done: Bug #55475 is_a() triggers autoloader -- Mads Lie Jensen - m...@gart

Re: [PHP-DEV] 5.3.7pl1

2011-08-22 Thread Ferenc Kovacs
On Mon, Aug 22, 2011 at 10:12 AM, Hannes Magnusson wrote: > On Mon, Aug 22, 2011 at 10:07, Hannes Magnusson > wrote: >> On Mon, Aug 22, 2011 at 09:42, Ferenc Kovacs wrote: >>> On Sun, Aug 21, 2011 at 12:10 PM, Pierre Joye wrote: hi, On Sun, Aug 21, 2011 at 3:57 AM, Adam Harvey w

Re: [PHP-DEV] 5.3.7pl1

2011-08-22 Thread Hannes Magnusson
On Mon, Aug 22, 2011 at 10:07, Hannes Magnusson wrote: > On Mon, Aug 22, 2011 at 09:42, Ferenc Kovacs wrote: >> On Sun, Aug 21, 2011 at 12:10 PM, Pierre Joye wrote: >>> hi, >>> >>> On Sun, Aug 21, 2011 at 3:57 AM, Adam Harvey wrote: >>> Depending on the timeframe for 5.3.8, should we be pu

Re: [PHP-DEV] 5.3.7pl1

2011-08-22 Thread Hannes Magnusson
On Mon, Aug 22, 2011 at 09:42, Ferenc Kovacs wrote: > On Sun, Aug 21, 2011 at 12:10 PM, Pierre Joye wrote: >> hi, >> >> On Sun, Aug 21, 2011 at 3:57 AM, Adam Harvey wrote: >> >>> Depending on the timeframe for 5.3.8, should we be pulling 5.3.7 from the >>> front page (or posting additional news)

Re: [PHP-DEV] is_a() triggers __autoload() in 5.3.7

2011-08-22 Thread Hannes Magnusson
On Mon, Aug 22, 2011 at 08:22, Mads Lie Jensen wrote: > On Mon, 22 Aug 2011 08:10:28 +0200, ka...@php.net (Kalle Sommer Nielsen) > wrote: > >>> After upgrading to php 5.3.7, whenever I use is_a($object, 'ClassName'); >>> the autoloader of classes is now called. >>> >>> This did not happen in earli

Re: [PHP-DEV] Choosing a distributed version control system for PHP - problems

2011-08-22 Thread Lester Caine
Lester Caine wrote: Just for the record ... the libreoffice clone I started 9 hours ago is still going strong, and I'm estimating that it will finish some time tomorrow afternoon, another 20 hours or so. A single huge repo is going to take time to handle? Or am I doing something wrong? All I've d

Re: [PHP-DEV] 5.3.7pl1

2011-08-22 Thread Ferenc Kovacs
On Sun, Aug 21, 2011 at 12:10 PM, Pierre Joye wrote: > hi, > > On Sun, Aug 21, 2011 at 3:57 AM, Adam Harvey wrote: > >> Depending on the timeframe for 5.3.8, should we be pulling 5.3.7 from the >> front page (or posting additional news) so users don't inadvertently end up >> with crypt() issues?