Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Tjerk Anne Meesters
On Wed, Aug 25, 2010 at 2:22 PM, Lester Caine wrote: > Johannes Schlüter wrote: >> >> On Tue, 2010-08-24 at 18:49 +0800, Adam Harvey wrote: >>> >>> Johannes has pointed out on IRC that E_NONE does already exist in some >>> projects, so that's an argument against it. >> >> Yeah, I did a quick code

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Lester Caine
Johannes Schlüter wrote: On Tue, 2010-08-24 at 18:49 +0800, Adam Harvey wrote: Johannes has pointed out on IRC that E_NONE does already exist in some projects, so that's an argument against it. Yeah, I did a quick code search, which gave some results defining a constant with that name. This me

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Nicolas A . Bérard-Nault
http://thedailywtf.com/Articles/Avoiding-Magic-Constants.aspx I'm sorry, I could not resist. On Tue, Aug 24, 2010 at 5:26 PM, Giovanni Giacobbi wrote: > On Tue, Aug 24, 2010 at 11:14:05AM -0700, Stas Malyshev wrote: > > Hi! > > > > >use an E_ constant with error_reporting" and not have the curre

[PHP-DEV] Re: Multithreading: I'm not complaining--I did something! (and itworkson Windows)

2010-08-24 Thread Alec
Another update! Added a new function and a new argument to a function. Check out example05.php for an example using curl. I am working on getting example02 and 03 to work. There is a bug when parameters are streams, the program crashes. Fun. -Alec On 8/23/2010 8:35 PM, Alec wrote: As an upda

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Giovanni Giacobbi
On Tue, Aug 24, 2010 at 11:14:05AM -0700, Stas Malyshev wrote: > Hi! > > >use an E_ constant with error_reporting" and not have the current > >situation where sometimes you use a constant (or constants) and > >sometimes you use a bare number, depending on what you want to > >achieve. > > What's w

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Johannes Schlüter
On Tue, 2010-08-24 at 22:23 +0400, Alexey Zakhlestin wrote: > The only downside is, that programmer will need to know, that E_* > constants do mean numbers. > With adding E_NONE this knowledge would be unnecessary and people > would be able just to think in terms of abstract "symbols" Users should

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Pierre Joye
On Tue, Aug 24, 2010 at 8:14 PM, Stas Malyshev wrote: > Hi! > >> use an E_ constant with error_reporting" and not have the current >> situation where sometimes you use a constant (or constants) and >> sometimes you use a bare number, depending on what you want to >> achieve. > > What's wrong with

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Johannes Schlüter
On Tue, 2010-08-24 at 18:49 +0800, Adam Harvey wrote: > Johannes has pointed out on IRC that E_NONE does already exist in some > projects, so that's an argument against it. Yeah, I did a quick code search, which gave some results defining a constant with that name. This means adding this in 5.3 wo

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Alexey Zakhlestin
On Tue, Aug 24, 2010 at 10:14 PM, Stas Malyshev wrote: > Hi! > >> use an E_ constant with error_reporting" and not have the current >> situation where sometimes you use a constant (or constants) and >> sometimes you use a bare number, depending on what you want to >> achieve. > > What's wrong with

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Stas Malyshev
Hi! use an E_ constant with error_reporting" and not have the current situation where sometimes you use a constant (or constants) and sometimes you use a bare number, depending on what you want to achieve. What's wrong with using 0? 0 means "nothing", how hard is that? ` -- Stanislav Maly

[PHP-DEV] [PATCH] #52045: FPM tries to open php.ini from the current dir

2010-08-24 Thread Jérôme Loyet
hi, when looking at the bug http://bugs.php.net/52045, I figure out that the CLI sapi need to not check php.ini in the current directory (in main/php_ini.c from line 436 to line 442). I need to change this file to make FPM another exception by not adding cwd in the php.ini search path. When talki

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Pierre Joye
On Tue, Aug 24, 2010 at 7:47 PM, Stas Malyshev wrote: > Hi! > >> Rhetorical question: Why do we need constants when the values never >> change? :) > > You seriously don't know why one needs constants or don't see a difference > between constant E_WARNING equal to 8 and constant E_NONE meaning "not

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Adam Harvey
On 25 August 2010 01:47, Stas Malyshev wrote: > You seriously don't know why one needs constants or don't see a difference > between constant E_WARNING equal to 8 and constant E_NONE meaning "nothing" > and equal to 0? How about having constants ONE, TWO, THREE, FOUR? Just in > case, won't hurt

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Stas Malyshev
Hi! Rhetorical question: Why do we need constants when the values never change? :) You seriously don't know why one needs constants or don't see a difference between constant E_WARNING equal to 8 and constant E_NONE meaning "nothing" and equal to 0? How about having constants ONE, TWO, THRE

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Pierre Joye
On Tue, Aug 24, 2010 at 6:27 PM, Stas Malyshev wrote: >> http://bugs.php.net/52563 suggests adding an E_NONE constant (set to 0) to >> go with the various other E_* constants we have. I've hacked up a quick > > I'm kind of confused - why we need E_NONE? In case value of 0 should ever > change? R

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Stas Malyshev
Hi! http://bugs.php.net/52563 suggests adding an E_NONE constant (set to 0) to go with the various other E_* constants we have. I've hacked up a quick I'm kind of confused - why we need E_NONE? In case value of 0 should ever change? -- Stanislav Malyshev, Software Architect SugarCRM: http://

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Adam Harvey
On 24 August 2010 21:46, Pierre Joye wrote: > I don't see it as an argument against as the fix is rather easy: > > if (!defined('E_NONE')) { > ... > > But it should not be added in a minor release. Agreed. To be clear: the patch is against trunk, and I wouldn't suggest it even be considered for 5

Re: [PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Pierre Joye
hi, On Tue, Aug 24, 2010 at 12:49 PM, Adam Harvey wrote: > http://bugs.php.net/52563 suggests adding an E_NONE constant (set to 0) to > go with the various other E_* constants we have. I've hacked up a quick > patch against trunk (attached to the report) that would add that, but don't > have Zen

[PHP-DEV] [PATCH] #52563: Adding E_NONE and/or E_EVERYTHING constants

2010-08-24 Thread Adam Harvey
Folks, http://bugs.php.net/52563 suggests adding an E_NONE constant (set to 0) to go with the various other E_* constants we have. I've hacked up a quick patch against trunk (attached to the report) that would add that, but don't have Zend karma to add it, so I'll open it up to the floor: (a) shou