On 24 August 2010 21:46, Pierre Joye <pierre....@gmail.com> wrote:
> I don't see it as an argument against as the fix is rather easy:
>
> if (!defined('E_NONE')) {
> ...
>
> But it should not be added in a minor release.

Agreed. To be clear: the patch is against trunk, and I wouldn't
suggest it even be considered for 5.3.

Johannes has already said he wouldn't accept it for 5.3 anyway. :)

> I would like something like E_DEVELOPMENT (notices, warnings,
> deprecated and the classic fatal), to strongly advice developers to
> use it. On the same line, we could add E_PRODUCTION to set the error
> reporting we recommend in production (fatal and warning).

I'd be happy enough with E_DEVELOPMENT instead of E_EVERYTHING. The
point is that everything should be on — we should be encouraging
developers to fix up E_STRICT notices as well as the usual array of
things E_ALL shows.

Of course, another option is to put E_ALL back to truly being "all".

Adam

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to