Re: [PHP-DEV] Re: [ANNOUNCE] Scanner to be based on re2c

Marcus Boerger wrote: > Another option is to always generate both versions > and then select the correc one form the build system. +1 -- Edward Z. YangGnuPG: 0x869C48DA HTML Purifier Anti-XSS Filter [[ 3FA8 E9A9 7385 B691 A6FC B3CB A933 BE7D 8

Re: [PHP-DEV] Re: [ANNOUNCE] Scanner to be based on re2c

Hello Edward, Sunday, March 16, 2008, 11:25:34 PM, you wrote: > Here is a patch that appears to fix the Windows build: > http://www.thewritingpot.com/patches/php-re2c-windows.patch > I made re2c required; if pre-generated files are supplied, however, we > might be able to get away without it. I

[PHP-DEV] Re: [ANNOUNCE] Scanner to be based on re2c

Edward Z. Yang wrote: > Here is a patch [snip] Marcus beat me to it. :-) -- Edward Z. YangGnuPG: 0x869C48DA HTML Purifier Anti-XSS Filter [[ 3FA8 E9A9 7385 B691 A6FC B3CB A933 BE7D 869C 48DA ]] -- PHP Internals - PHP Runtime Development Mail

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt stri

Marcus Boerger wrote: > Yeah, thats right. That is also the reason why we spent several weeks > working on thjise with a small team prior to comitting the work. Also > note that plans for this move are in place for over two years now. And > of course we document changes as we find them, though none

[PHP-DEV] Re: [ANNOUNCE] Scanner to be based on re2c

Here is a patch that appears to fix the Windows build: http://www.thewritingpot.com/patches/php-re2c-windows.patch I made re2c required; if pre-generated files are supplied, however, we might be able to get away without it. I also had to download re2c binaries from http://sourceforge.net/project/s

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt stri

Hello Edward, Sunday, March 16, 2008, 11:04:56 PM, you wrote: > Marcus Boerger wrote: >> Of course it affects that kind of tools. But the scanner was changed a lot >> of times for 5.3 already, so you have to do that anyway. That is the cost >> of making progress - changes. > Agreed; I'm in favor

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt stri

Marcus Boerger wrote: > Of course it affects that kind of tools. But the scanner was changed a lot > of times for 5.3 already, so you have to do that anyway. That is the cost > of making progress - changes. Agreed; I'm in favor of changes. But to make things as painless as possible those changes s

Re: [PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt stri

Hello Edward, Sunday, March 16, 2008, 10:42:43 PM, you wrote: > Marcus Boerger wrote: >> - the tokenizer works a bit different as tokenizing works better now, that >> is uses less tokens. >> - the scanner is about 20% faster, overall execution is about 2% faster >> when not using compiler cac

[PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt strip_ta

Marcus Boerger wrote: > - the tokenizer works a bit different as tokenizing works better now, that > is uses less tokens. > - the scanner is about 20% faster, overall execution is about 2% faster > when not using compiler caches like APC > - in some edgecases error messages are no longer corrup

[PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt strip_ta

that, if you had read the patch you could have decided for your self. marcus Sunday, March 16, 2008, 10:24:58 PM, you wrote: > Marcus Boerger wrote: >> - Rewrite scanner to be based on re2c instead of flex >> The full patch is available as: >> http://php.net/~helly/

[PHP-DEV] [ANNOUNCE] Scanner to be based on re2c

ase you are interested at a full patch: http://php.net/~helly/php-re2c-5.3-20080316.diff.txt In case you like to get more involved: http://blog.somabo.de/2008/02/php-on-re2c.html Care to help? Write tests that use --enable-zend-multibyte or define how multibyte support should work. Best rega

[PHP-DEV] Re: cvs: php-src(PHP_5_3) / Makefile.frag NEWS acinclude.m4 configure.in /ext/spl php_spl.c /ext/standard/tests/strings 006.phpt 007.phpt highlight_file.phpt strip_tags_basic1.phpt strip_t

Marcus Boerger wrote: > - Rewrite scanner to be based on re2c instead of flex > The full patch is available as: > http://php.net/~helly/php-re2c-5.3-20080316.diff.txt > This is against php-re2c repository version 98 > An older patch against version 97 is