Re: AW: [PHP-DEV] A rebuttal to Re: RFC: Dropping Namespace

2007-12-09 Thread Dmitry Stogov
Jessie Hernandez wrote: I thought global names were considered in the patch, but now that I re-read Dmitry's post, only symbols in the namespace and internal symbols are considered. I read through most of the posts regarding namespaces, but could not find a reason why global names are not l

Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)

2007-12-09 Thread Stanislav Malyshev
Right, that's what "l" parameter spec is doing, doesn't it? Why convert it manually? Because it doesn't know the difference between NULL and 0 if it's a long. And why this difference is important in array_slice()? I don't see anything in manual that says anything about NULLs. Could you explai

Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)

2007-12-09 Thread Steph Fox
I think in fact it should just parse it as long and not as zval - what would be any reason to parse it as zval and then convert to long anyway? The problem is that this function's always been wrong, so it doesn't really care what you throw at it - it just does a silent conversion to long if yo

Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)

2007-12-09 Thread Stanislav Malyshev
I think in fact it should just parse it as long and not as zval - what would be any reason to parse it as zval and then convert to long anyway? The problem is that this function's always been wrong, so it doesn't really care what you throw at it - it just does a silent conversion to long if yo

Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)

2007-12-09 Thread Steph Fox
all of a sudden the fourth parameter, preserve_keys, doesn't throw zend_parse_parameter() warnings any more, regardless of the type you give it. (You tell me...) ... because I re-used the same variable in the test script after it had been converted to long. OK, so that mystery's solved. But

Re: AW: [PHP-DEV] A rebuttal to Re: RFC: Dropping Namespace

2007-12-09 Thread Gregory Beaver
Sam Barrow wrote: > I agree with this 100%, is this something that could be changed? I don't > see a reason behind it. > > On Sun, 2007-12-09 at 16:24 -0500, Jessie Hernandez wrote: > >> internal class/function with the same name. >> >> Dmitry, what's the reason this lookup logic wasn't used in

Re: [PHP-DEV] question regarding type hinting parameters of php functions (array_slice)

2007-12-09 Thread Steph Fox
Hi Stas, I just spent most of two evenings looking at this one - so much for an easy fix. Read on... the code is if (ZEND_NUM_ARGS() >= 3 && Z_TYPE_P(length_param) != IS_NULL) { length = Z_LVAL_P(length_param); } else { length = num_in; } and afaik should be I think in fact it should just

[PHP-DEV] Fw: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/array array_unique_basic.phpt array_unique_error.phpt array_unique_variation1.phpt array_unique_variation2.phpt array_unique_variation

2007-12-09 Thread Steph Fox
OK, I've split the test down now (and found the bug in my fix). I also extended the parameter checking, the old test missed the bug I was trying to fix (bug #43541). Tarred tests to replace array_slice.phpt attached, along with one-line patch. I hope this-all makes it past the attachment stripper

Re: AW: [PHP-DEV] A rebuttal to Re: RFC: Dropping Namespace

2007-12-09 Thread Sam Barrow
I agree with this 100%, is this something that could be changed? I don't see a reason behind it. On Sun, 2007-12-09 at 16:24 -0500, Jessie Hernandez wrote: > > internal class/function with the same name. > > Dmitry, what's the reason this lookup logic wasn't used in your patch? > -- PHP Inter

Re: AW: [PHP-DEV] A rebuttal to Re: RFC: Dropping Namespace

2007-12-09 Thread Jessie Hernandez
I thought global names were considered in the patch, but now that I re-read Dmitry's post, only symbols in the namespace and internal symbols are considered. I read through most of the posts regarding namespaces, but could not find a reason why global names are not looked up. Classes/functions

[PHP-DEV] Re: faster & public domain MD5 implementation

2007-12-09 Thread Solar Designer
On Sun, Dec 09, 2007 at 12:53:56PM +0100, Peter Brodersen wrote: > A bit on a side note regarding the php function md5(): In general it > is possible to supply an arbitrary number of bits as input to MD5. > However, the implementation of md5() only takes a sting with octets as > the smallest fragme

Re: [PHP-DEV] PHP 5.3 bug or changed feature??

2007-12-09 Thread Marco Kaiser
This happens with many more functions. So i can verify this bug. php -r "echo md5(serialize(simplexml_load_file('example.xml'))) . PHP_EOL . phpversion() . PHP_EOL;" Output PHP 5.2.5: a6d7776fcb0e9c085b0d5972df792dac 5.2.5 Output PHP 5.3.0-dev (latest snap) 3e442cb7c8507c8941011735bb46e6de 5.3.0

Re: [PHP-DEV] PHP 5.3 bug or changed feature??

2007-12-09 Thread Rob Richards
Hi Frank, Frank M. Kromann wrote: Hello Everyon, Casting a SimpleXML object to an array gives different results in PHP 5.2.5 and PHP 5.3-dev. This is due to the implementation of the get_debug_info handler merged from HEAD. The same result happens when calling get_object_vars on a SimpleXM

[PHP-DEV] Re: faster & public domain MD5 implementation

2007-12-09 Thread Peter Brodersen
On Sun, 9 Dec 2007 04:05:52 +0300, in php.internals [EMAIL PROTECTED] (Solar Designer) wrote: >Attached is a quick patch for PHP 5.2.5 that replaces RSA's copyrighted >implementation of MD5 with my public domain one: > > > http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/popa3d/popa3d