OK, I've split the test down now (and found the bug in my fix). I also extended the parameter checking, the old test missed the bug I was trying to fix (bug #43541).
Tarred tests to replace array_slice.phpt attached, along with one-line patch. I hope this-all makes it past the attachment stripper... - Steph----- Original Message ----- From: "Steph Fox" <[EMAIL PROTECTED]>
To: "Raghubansh Kumar" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Sunday, December 09, 2007 3:31 PMSubject: Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/array array_unique_basic.phpt array_unique_error.phpt array_unique_variation1.phpt array_unique_variation2.phpt array_unique_variation3.phpt array_unique_variation4.phpt array_unique_variation5.phpt a
Hi Raghubansh,Do you have plans to break down the array_slice.phpt test? It has an expected output of over 1000 lines at present... I can't tell from that, what's broken and what isn't.Thanks for all your work, - Steph----- Original Message ----- From: "Raghubansh Kumar" <[EMAIL PROTECTED]>To: <[EMAIL PROTECTED]> Sent: Sunday, December 09, 2007 2:41 PMSubject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/standard/tests/array array_unique_basic.phpt array_unique_error.phpt array_unique_variation1.phpt array_unique_variation2.phpt array_unique_variation3.phpt array_unique_variation4.phpt array_unique_variation5.phpt array_unique_variation6.phpt array_unique_variation7.phpt array_unique_variation8.phptkraghuba Sun Dec 9 14:41:11 2007 UTC Added files: (Branch: PHP_5_3) /php-src/ext/standard/tests/array array_unique_variation1.phpt array_unique_variation4.phpt array_unique_variation7.phpt array_unique_error.phpt array_unique_variation3.phpt array_unique_variation6.phpt array_unique_variation2.phpt array_unique_variation5.phpt array_unique_variation8.phpt array_unique_basic.phpt Log: new testcases for array_unique() function---------------------------------------------------------------------------------- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
array_slice_tests.tar.gz
Description: GNU Zip compressed data
-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php