Re: [PHP-DEV] RFC: mark functions as const for possible optimizations

2007-09-14 Thread Nuno Lopes
Nuno Lopes wrote: > My proposal is the following: > some functions when fed with constant arguments always return a constant > value, too. e.g.: > strlen('abcd') === 4. wouldn't that be called "deterministic" and not "const"? yeah, exactly. I was missing the correct wording. (btw, appart of b

Re: [PHP-DEV] RFC: mark functions as const for possible optimizations

2007-09-14 Thread Hartmut Holzgraefe
Nuno Lopes wrote: My proposal is the following: some functions when fed with constant arguments always return a constant value, too. e.g.: strlen('abcd') === 4. wouldn't that be called "deterministic" and not "const"? -- Hartmut Holzgraefe, Principal Support Engineer . Discover

[PHP-DEV] RFC: mark functions as const for possible optimizations

2007-09-14 Thread Nuno Lopes
Hi, Following my last post on bytecode optimization (http://news.php.net/php.internals/32113), I would like to discuss a few more things. The patch in that e-mail allowed the engine itself to do transformations like, e.g.: $a = 1*2*3*4*5+1-0; --> $a = 121; However the patch is now a bit d

[PHP-DEV] CVS Account Request: lucas

2007-09-14 Thread Lucas Nealan
Update APD documentation. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Zoe Slattery
Zoe Slattery wrote: It is a nice patch - but I'm seeing some errors that I don't understand yet when I use it - like this: Warning: preg_match(): Compilation failed: missing terminating ] for character class at offset 5 in /home/zoe/BUILDS/php52/run-tests.php on line 1609 I'm not having t

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Nuno Lopes
It is a nice patch - but I'm seeing some errors that I don't understand yet when I use it - like this: Warning: preg_match(): Compilation failed: missing terminating ] for character class at offset 5 in /home/zoe/BUILDS/php52/run-tests.php on line 1609 I'm not having the best afternoon :-( -

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Zoe Slattery
Marcus Boerger wrote: Hello Nuno, Thursday, September 13, 2007, 9:20:51 PM, you wrote: now i get the issue. It grabbs more than one line! This means run-tests.php has to be fixed. The whole thing is designed under the assumption that %s catches no new lines and hence only one line.

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Nuno Lopes
OK, so basically it is impossible to fix the current regex to match what we want (I had a quick chat with the PCRE author and he thinks the same). I propose the following patch: http://web.ist.utl.pt/nuno.lopes/php_run_tests_%s.txt The main changes are: '%s' => '[^\r\n]+' Nice patch! The onl

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Marcus Boerger
Hello Nuno, Thursday, September 13, 2007, 9:20:51 PM, you wrote: >>> now i get the issue. It grabbs more than one line! This means >>> run-tests.php has to be fixed. The whole thing is designed under >>> the assumption that %s catches no new lines and hence only one >>> line. >> >> That would b

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Zoe Slattery
Hi again On second thoughts - cancel my last two notes - yours is a better fix. :-) Zoe Johannes Schlüter wrote: Hi Nuno, On Thu, 2007-09-13 at 20:20 +0100, Nuno Lopes wrote: now i get the issue. It grabbs more than one line! This means run-tests.php has to be fixed. The whole thing is

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Zoe Slattery
..PS - here is a slightly longer explanation of how I got to the idea that to removing the "s" modifier would be a better fix. I did a little more work to understand how the regex matching for %s was working in run-tests.php. In the current version %s maps to .+? This *should* match one or

Re: [PHP-DEV] Re: [PHP-QA] run-tests.php

2007-09-14 Thread Zoe Slattery
Hi guys - There is an alternative patch if you have't already committed this. The line: if (preg_match("/^$wanted_re$/s", $output)) can just be changed to remove the "s" modifier, I was working on trying to fix up the tests and make sure that they all work. The problematic ones are the php_i