Hi guys - There is an alternative patch if you have't already committed
this. The line:
if (preg_match("/^$wanted_re$/s", $output))
can just be changed to remove the "s" modifier, I was working on trying
to fix up the tests and make sure that they all work. The problematic
ones are the php_info and php_credits which rely on the %s matching over
line endings.
Zoe
The main changes are:
'%s' => '[^\r\n]+'
'%a' => '.+'
This means that some tests have to be fixed, but the majority passes. Most
important is that with this patch I found some tests that had the expected
output wrong.
So unless someone rejects this patch, I'll commit it (and update the
http://qa.php.net/write-test.php page too).
Anyway, I don't think that a function name should be replaced by %s. The
expected output should be as stricter as possible.
from a short review of the patch I think it's fine and a good idea. So
please go on and commit.
johannes
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
